public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Aaron Williams <awilliams@marvell.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [EXT] Re: Question about device tree usage and ranges
Date: Thu, 19 Sep 2019 22:39:41 +0000	[thread overview]
Message-ID: <2563828.m5mLYZvmcG@flash> (raw)
In-Reply-To: <1a1e1028-6abf-6883-89b9-13a23441fecb@denx.de>

Hi Stefan,

That doesn't explain the wrong endian. The code should be using fdt32_to_cpu 
for little-endian CPUs.

-Aaron

On Thursday, September 19, 2019 4:43:27 AM PDT Stefan Roese wrote:
> 
> ----------------------------------------------------------------------
> Hi Aaron,
> 
> On 19.09.19 13:35, Aaron Williams wrote:
> > Hi,
> > 
> > In my device tree I need to translate some address via ranges but I'm
> > running into some issues. If I use ofnode_get_addr_size() it is not using
> > the #address-cells and #size-cells nor is it performing the ranges
> > translation. It always assumes #address-cells and #size-cells is 2 and
> > doesn't translate.  Is this by design?
> > 
> > If, on the other hand, I use ofnode_get_addr_size_index, it is having
> > problems on ARM64. One problem I see is in of_translate_one in
> > fdt_support.c. Shouldn't there be a fdt32_to_cpu or fdt64_to_cpu for the
> > address after the memcpy in of_translate_one? I'm seeing the wrong endian
> > address and size show up.
> > 
> > OF: ** translation for device console at 0 **
> > __of_translate_address: bus: default, address: 00000007fff46d7d
> > OF: bus is default (na=1, ns=1) on pci-console at 0x03000000
> > OF: translating address: 00000000
> > OF: parent bus is default (na=2, ns=2) on soc at 0
> > OF: walking ranges...
> > OF: default map, cp=0, s=1, da=0
> > OF: parent translation for: 80003000 80400000 <======= WRONG ENDIAN!
> > OF: with offset: 0
> > OF: one level translation: 80003000 80400000 <======= WRONG ENDIAN!
> > OF: parent bus is default (na=2, ns=2) on
> > OF: no ranges, 1:1 translation
> 
> Without looking deeper into your mail, let me ask if you enabled
> CONFIG_(SPL_)OF_TRANSLATE?
> 
> Thanks,
> Stefan

  reply	other threads:[~2019-09-19 22:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-19 11:35 [U-Boot] Question about device tree usage and ranges Aaron Williams
2019-09-19 11:43 ` Stefan Roese
2019-09-19 22:39   ` Aaron Williams [this message]
2019-09-19 22:59   ` [U-Boot] [EXT] " Aaron Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2563828.m5mLYZvmcG@flash \
    --to=awilliams@marvell.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox