public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [PATCH v2 1/6] rockchip: gpio: rk_gpio: use ROCKCHIP_GPIOS_PER_BANK as divider
@ 2023-03-19 15:02 Johan Jonker
  2023-03-19 15:05 ` [PATCH v2 2/6] arm: dts: rockchip: rk3066a-u-boot: add gpio-ranges Johan Jonker
                   ` (5 more replies)
  0 siblings, 6 replies; 12+ messages in thread
From: Johan Jonker @ 2023-03-19 15:02 UTC (permalink / raw)
  To: kever.yang; +Cc: sjg, philipp.tomsich, u-boot

The current divider to calculate the bank ID can change.
Given the Rockchip TRM not all gpio-banks have 32 pins per bank.
The "gpio-ranges" syntax allows multiple items with variable number
of pins. Use a constant ROCKCHIP_GPIOS_PER_BANK as fixed divider.

Signed-off-by: Johan Jonker <jbx6244@gmail.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
---
 drivers/gpio/rk_gpio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/rk_gpio.c b/drivers/gpio/rk_gpio.c
index f7ad4d68..0a2acf18 100644
--- a/drivers/gpio/rk_gpio.c
+++ b/drivers/gpio/rk_gpio.c
@@ -160,7 +160,7 @@ static int rockchip_gpio_probe(struct udevice *dev)
 					     0, &args);
 	if (!ret || ret != -ENOENT) {
 		uc_priv->gpio_count = args.args[2];
-		priv->bank = args.args[1] / args.args[2];
+		priv->bank = args.args[1] / ROCKCHIP_GPIOS_PER_BANK;
 	} else {
 		uc_priv->gpio_count = ROCKCHIP_GPIOS_PER_BANK;
 		end = strrchr(dev->name, '@');
--
2.20.1


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH v2 2/6] arm: dts: rockchip: rk3066a-u-boot: add gpio-ranges
  2023-03-19 15:02 [PATCH v2 1/6] rockchip: gpio: rk_gpio: use ROCKCHIP_GPIOS_PER_BANK as divider Johan Jonker
@ 2023-03-19 15:05 ` Johan Jonker
  2023-03-21  3:08   ` Kever Yang
  2023-03-19 15:05 ` [PATCH v2 3/6] arm: dts: rockchip: rk3188-u-boot: " Johan Jonker
                   ` (4 subsequent siblings)
  5 siblings, 1 reply; 12+ messages in thread
From: Johan Jonker @ 2023-03-19 15:05 UTC (permalink / raw)
  To: kever.yang; +Cc: sjg, philipp.tomsich, u-boot

The gpio node names are made generic, but without
gpio bank ID. Add gpio-ranges to rk3066a-u-boot.dtsi
for now till a better method is found.
Disable gpio6 as the driver gives an error code
on return as status.

Signed-off-by: Johan Jonker <jbx6244@gmail.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
---

Changed V2:
  disable gpio6
---
 arch/arm/dts/rk3066a-u-boot.dtsi | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/arch/arm/dts/rk3066a-u-boot.dtsi b/arch/arm/dts/rk3066a-u-boot.dtsi
index bc6e609d..06f405ca 100644
--- a/arch/arm/dts/rk3066a-u-boot.dtsi
+++ b/arch/arm/dts/rk3066a-u-boot.dtsi
@@ -2,3 +2,28 @@

 #include "rockchip-u-boot.dtsi"
 #include "rk3xxx-u-boot.dtsi"
+
+&gpio0 {
+	gpio-ranges = <&pinctrl 0 0 32>;
+};
+
+&gpio1 {
+	gpio-ranges = <&pinctrl 0 32 32>;
+};
+
+&gpio2 {
+	gpio-ranges = <&pinctrl 0 64 32>;
+};
+
+&gpio3 {
+	gpio-ranges = <&pinctrl 0 96 32>;
+};
+
+&gpio4 {
+	gpio-ranges = <&pinctrl 0 128 32>;
+};
+
+&gpio6 {
+	status = "disabled";
+};
+
--
2.20.1


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH v2 3/6] arm: dts: rockchip: rk3188-u-boot: add gpio-ranges
  2023-03-19 15:02 [PATCH v2 1/6] rockchip: gpio: rk_gpio: use ROCKCHIP_GPIOS_PER_BANK as divider Johan Jonker
  2023-03-19 15:05 ` [PATCH v2 2/6] arm: dts: rockchip: rk3066a-u-boot: add gpio-ranges Johan Jonker
@ 2023-03-19 15:05 ` Johan Jonker
  2023-03-21  3:08   ` Kever Yang
  2023-03-19 15:05 ` [PATCH v2 4/6] arm: dts: rockchip: sync rk3066/rk3188 DT files from linux-next v6.2-rc4 Johan Jonker
                   ` (3 subsequent siblings)
  5 siblings, 1 reply; 12+ messages in thread
From: Johan Jonker @ 2023-03-19 15:05 UTC (permalink / raw)
  To: kever.yang; +Cc: sjg, philipp.tomsich, u-boot

The gpio node names are made generic, but without
gpio bank ID. Add gpio-ranges to rk3188-u-boot.dtsi
for now till a better method is found.

Signed-off-by: Johan Jonker <jbx6244@gmail.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
---
 arch/arm/dts/rk3188-u-boot.dtsi | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/arch/arm/dts/rk3188-u-boot.dtsi b/arch/arm/dts/rk3188-u-boot.dtsi
index 735776c1..176f9e65 100644
--- a/arch/arm/dts/rk3188-u-boot.dtsi
+++ b/arch/arm/dts/rk3188-u-boot.dtsi
@@ -12,6 +12,19 @@

 &gpio0 {
 	compatible = "rockchip,gpio-bank";
+	gpio-ranges = <&pinctrl 0 0 32>;
+};
+
+&gpio1 {
+	gpio-ranges = <&pinctrl 0 32 32>;
+};
+
+&gpio2 {
+	gpio-ranges = <&pinctrl 0 64 32>;
+};
+
+&gpio3 {
+	gpio-ranges = <&pinctrl 0 96 32>;
 };

 &pmu {
--
2.20.1


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH v2 4/6] arm: dts: rockchip: sync rk3066/rk3188 DT files from linux-next v6.2-rc4
  2023-03-19 15:02 [PATCH v2 1/6] rockchip: gpio: rk_gpio: use ROCKCHIP_GPIOS_PER_BANK as divider Johan Jonker
  2023-03-19 15:05 ` [PATCH v2 2/6] arm: dts: rockchip: rk3066a-u-boot: add gpio-ranges Johan Jonker
  2023-03-19 15:05 ` [PATCH v2 3/6] arm: dts: rockchip: rk3188-u-boot: " Johan Jonker
@ 2023-03-19 15:05 ` Johan Jonker
  2023-03-21  3:09   ` Kever Yang
  2023-03-19 15:06 ` [PATCH v2 5/6] rockchip: configs: mk808: change CONFIG_TPL_TEXT_BASE Johan Jonker
                   ` (2 subsequent siblings)
  5 siblings, 1 reply; 12+ messages in thread
From: Johan Jonker @ 2023-03-19 15:05 UTC (permalink / raw)
  To: kever.yang; +Cc: sjg, philipp.tomsich, u-boot

Sync rk3066/rk3188 DT files from Linux.
This is the state as of linux-next v6.2-rc4.
New nfc node for MK808 rk3066a.
CRU nodes now have a clock property.
To prefend dtoc errors a fixed clock must also be
included for tpl/spl in the rk3xxx-u-boot.dtsi file.

Signed-off-by: Johan Jonker <jbx6244@gmail.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
---
 arch/arm/dts/rk3066a-mk808.dts    | 27 ++++++++++++++++++++++++++-
 arch/arm/dts/rk3066a.dtsi         |  3 ++-
 arch/arm/dts/rk3188-radxarock.dts | 24 +++++++++++++-----------
 arch/arm/dts/rk3188.dtsi          | 27 ++++++++++++++++-----------
 arch/arm/dts/rk3xxx-u-boot.dtsi   |  4 ++++
 arch/arm/dts/rk3xxx.dtsi          |  9 +++++++--
 6 files changed, 68 insertions(+), 26 deletions(-)

diff --git a/arch/arm/dts/rk3066a-mk808.dts b/arch/arm/dts/rk3066a-mk808.dts
index 667d57a4..06790f05 100644
--- a/arch/arm/dts/rk3066a-mk808.dts
+++ b/arch/arm/dts/rk3066a-mk808.dts
@@ -32,7 +32,7 @@
 		keyup-threshold-microvolt = <2500000>;
 		poll-interval = <100>;

-		recovery {
+		button-recovery {
 			label = "recovery";
 			linux,code = <KEY_VENDOR>;
 			press-threshold-microvolt = <0>;
@@ -157,7 +157,32 @@
 	pinctrl-0 = <&sd1_clk &sd1_cmd &sd1_bus4>;
 	pinctrl-names = "default";
 	vmmc-supply = <&vcc_wifi>;
+	#address-cells = <1>;
+	#size-cells = <0>;
 	status = "okay";
+
+	brcmf: wifi@1 {
+		compatible = "brcm,bcm4329-fmac";
+		reg = <1>;
+	};
+};
+
+&nfc {
+	#address-cells = <1>;
+	#size-cells = <0>;
+	status = "okay";
+
+	nand@0 {
+		reg = <0>;
+		label = "rk-nand";
+		nand-bus-width = <8>;
+		nand-ecc-mode = "hw";
+		nand-ecc-step-size = <1024>;
+		nand-ecc-strength = <40>;
+		nand-is-boot-medium;
+		rockchip,boot-blks = <8>;
+		rockchip,boot-ecc-strength = <24>;
+	};
 };

 &pinctrl {
diff --git a/arch/arm/dts/rk3066a.dtsi b/arch/arm/dts/rk3066a.dtsi
index c25b9695..de9915d9 100644
--- a/arch/arm/dts/rk3066a.dtsi
+++ b/arch/arm/dts/rk3066a.dtsi
@@ -202,8 +202,9 @@
 	cru: clock-controller@20000000 {
 		compatible = "rockchip,rk3066a-cru";
 		reg = <0x20000000 0x1000>;
+		clocks = <&xin24m>;
+		clock-names = "xin24m";
 		rockchip,grf = <&grf>;
-
 		#clock-cells = <1>;
 		#reset-cells = <1>;
 		assigned-clocks = <&cru PLL_CPLL>, <&cru PLL_GPLL>,
diff --git a/arch/arm/dts/rk3188-radxarock.dts b/arch/arm/dts/rk3188-radxarock.dts
index e7138a4a..118deacd 100644
--- a/arch/arm/dts/rk3188-radxarock.dts
+++ b/arch/arm/dts/rk3188-radxarock.dts
@@ -6,7 +6,6 @@
 /dts-v1/;
 #include <dt-bindings/input/input.h>
 #include "rk3188.dtsi"
-#include "rk3188-radxarock-u-boot.dtsi"

 / {
 	model = "Radxa Rock";
@@ -25,7 +24,7 @@
 		compatible = "gpio-keys";
 		autorepeat;

-		power {
+		key-power {
 			gpios = <&gpio0 RK_PA4 GPIO_ACTIVE_LOW>;
 			linux,code = <KEY_POWER>;
 			label = "GPIO Key Power";
@@ -72,7 +71,7 @@
 		#sound-dai-cells = <0>;
 	};

-	ir_recv: gpio-ir-receiver {
+	ir_recv: ir-receiver {
 		compatible = "gpio-ir-receiver";
 		gpios = <&gpio0 RK_PB2 GPIO_ACTIVE_LOW>;
 		pinctrl-names = "default";
@@ -127,18 +126,21 @@
 };

 &emac {
-	status = "okay";
-
+	phy = <&phy0>;
+	phy-supply = <&vcc_rmii>;
 	pinctrl-names = "default";
 	pinctrl-0 = <&emac_xfer>, <&emac_mdio>, <&phy_int>;
+	status = "okay";

-	phy = <&phy0>;
-	phy-supply = <&vcc_rmii>;
+	mdio {
+		#address-cells = <1>;
+		#size-cells = <0>;

-	phy0: ethernet-phy@0 {
-		reg = <0>;
-		interrupt-parent = <&gpio3>;
-		interrupts = <RK_PD2 IRQ_TYPE_LEVEL_LOW>;
+		phy0: ethernet-phy@0 {
+			reg = <0>;
+			interrupt-parent = <&gpio3>;
+			interrupts = <RK_PD2 IRQ_TYPE_LEVEL_LOW>;
+		};
 	};
 };

diff --git a/arch/arm/dts/rk3188.dtsi b/arch/arm/dts/rk3188.dtsi
index 9a80f83a..44b54af0 100644
--- a/arch/arm/dts/rk3188.dtsi
+++ b/arch/arm/dts/rk3188.dtsi
@@ -54,7 +54,7 @@
 		};
 	};

-	cpu0_opp_table: opp_table0 {
+	cpu0_opp_table: opp-table-0 {
 		compatible = "operating-points-v2";
 		opp-shared;

@@ -195,8 +195,9 @@
 	cru: clock-controller@20000000 {
 		compatible = "rockchip,rk3188-cru";
 		reg = <0x20000000 0x1000>;
+		clocks = <&xin24m>;
+		clock-names = "xin24m";
 		rockchip,grf = <&grf>;
-
 		#clock-cells = <1>;
 		#reset-cells = <1>;
 	};
@@ -223,7 +224,7 @@
 		#size-cells = <1>;
 		ranges;

-		gpio0: gpio0@2000a000 {
+		gpio0: gpio@2000a000 {
 			compatible = "rockchip,rk3188-gpio-bank0";
 			reg = <0x2000a000 0x100>;
 			interrupts = <GIC_SPI 54 IRQ_TYPE_LEVEL_HIGH>;
@@ -236,7 +237,7 @@
 			#interrupt-cells = <2>;
 		};

-		gpio1: gpio1@2003c000 {
+		gpio1: gpio@2003c000 {
 			compatible = "rockchip,gpio-bank";
 			reg = <0x2003c000 0x100>;
 			interrupts = <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>;
@@ -249,7 +250,7 @@
 			#interrupt-cells = <2>;
 		};

-		gpio2: gpio2@2003e000 {
+		gpio2: gpio@2003e000 {
 			compatible = "rockchip,gpio-bank";
 			reg = <0x2003e000 0x100>;
 			interrupts = <GIC_SPI 56 IRQ_TYPE_LEVEL_HIGH>;
@@ -262,7 +263,7 @@
 			#interrupt-cells = <2>;
 		};

-		gpio3: gpio3@20080000 {
+		gpio3: gpio@20080000 {
 			compatible = "rockchip,gpio-bank";
 			reg = <0x20080000 0x100>;
 			interrupts = <GIC_SPI 57 IRQ_TYPE_LEVEL_HIGH>;
@@ -275,15 +276,15 @@
 			#interrupt-cells = <2>;
 		};

-		pcfg_pull_up: pcfg_pull_up {
+		pcfg_pull_up: pcfg-pull-up {
 			bias-pull-up;
 		};

-		pcfg_pull_down: pcfg_pull_down {
+		pcfg_pull_down: pcfg-pull-down {
 			bias-pull-down;
 		};

-		pcfg_pull_none: pcfg_pull_none {
+		pcfg_pull_none: pcfg-pull-none {
 			bias-disable;
 		};

@@ -378,7 +379,7 @@
 				rockchip,pins = <2 RK_PD3 1 &pcfg_pull_none>;
 			};

-			lcdc1_rgb24: ldcd1-rgb24 {
+			lcdc1_rgb24: lcdc1-rgb24 {
 				rockchip,pins = <2 RK_PA0 1 &pcfg_pull_none>,
 						<2 RK_PA1 1 &pcfg_pull_none>,
 						<2 RK_PA2 1 &pcfg_pull_none>,
@@ -606,7 +607,6 @@

 &global_timer {
 	interrupts = <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_EDGE_RISING)>;
-	status = "disabled";
 };

 &local_timer {
@@ -641,6 +641,11 @@
 &grf {
 	compatible = "rockchip,rk3188-grf", "syscon", "simple-mfd";

+	io_domains: io-domains {
+		compatible = "rockchip,rk3188-io-voltage-domain";
+		status = "disabled";
+	};
+
 	usbphy: usbphy {
 		compatible = "rockchip,rk3188-usb-phy";
 		#address-cells = <1>;
diff --git a/arch/arm/dts/rk3xxx-u-boot.dtsi b/arch/arm/dts/rk3xxx-u-boot.dtsi
index e67432fb..c77d1fae 100644
--- a/arch/arm/dts/rk3xxx-u-boot.dtsi
+++ b/arch/arm/dts/rk3xxx-u-boot.dtsi
@@ -33,3 +33,7 @@
 &uart2 {
 	clock-frequency = <24000000>;
 };
+
+&xin24m {
+	u-boot,dm-pre-reloc;
+};
diff --git a/arch/arm/dts/rk3xxx.dtsi b/arch/arm/dts/rk3xxx.dtsi
index 616a828e..cb4e42ed 100644
--- a/arch/arm/dts/rk3xxx.dtsi
+++ b/arch/arm/dts/rk3xxx.dtsi
@@ -76,6 +76,13 @@
 		reg = <0x1013c200 0x20>;
 		interrupts = <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_EDGE_RISING)>;
 		clocks = <&cru CORE_PERI>;
+		status = "disabled";
+		/* The clock source and the sched_clock provided by the arm_global_timer
+		 * on Rockchip rk3066a/rk3188 are quite unstable because their rates
+		 * depend on the CPU frequency.
+		 * Keep the arm_global_timer disabled in order to have the
+		 * DW_APB_TIMER (rk3066a) or ROCKCHIP_TIMER (rk3188) selected by default.
+		 */
 	};

 	local_timer: local-timer@1013c600 {
@@ -186,8 +193,6 @@
 		compatible = "snps,arc-emac";
 		reg = <0x10204000 0x3c>;
 		interrupts = <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>;
-		#address-cells = <1>;
-		#size-cells = <0>;

 		rockchip,grf = <&grf>;

--
2.20.1


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH v2 5/6] rockchip: configs: mk808: change CONFIG_TPL_TEXT_BASE
  2023-03-19 15:02 [PATCH v2 1/6] rockchip: gpio: rk_gpio: use ROCKCHIP_GPIOS_PER_BANK as divider Johan Jonker
                   ` (2 preceding siblings ...)
  2023-03-19 15:05 ` [PATCH v2 4/6] arm: dts: rockchip: sync rk3066/rk3188 DT files from linux-next v6.2-rc4 Johan Jonker
@ 2023-03-19 15:06 ` Johan Jonker
  2023-03-21  3:09   ` Kever Yang
  2023-03-19 15:06 ` [PATCH v2 6/6] rockchip: configs: mk808: enable usb support Johan Jonker
  2023-03-21  3:08 ` [PATCH v2 1/6] rockchip: gpio: rk_gpio: use ROCKCHIP_GPIOS_PER_BANK as divider Kever Yang
  5 siblings, 1 reply; 12+ messages in thread
From: Johan Jonker @ 2023-03-19 15:06 UTC (permalink / raw)
  To: kever.yang; +Cc: sjg, philipp.tomsich, u-boot

Currently the Rockchip rk3066a u-boot-tpl.bin file needs
to add the characters "RK30", while the other SoCs replace
the first 4 bytes. Bring this in line with the rest by
lowering CONFIG_TPL_TEXT_BASE and update rockchip.rst
instructions.

Signed-off-by: Johan Jonker <jbx6244@gmail.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
---

Changed V2:
  use lower case hex
---
 configs/mk808_defconfig         | 2 +-
 doc/board/rockchip/rockchip.rst | 7 +++----
 2 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/configs/mk808_defconfig b/configs/mk808_defconfig
index c080706d..5a264eb9 100644
--- a/configs/mk808_defconfig
+++ b/configs/mk808_defconfig
@@ -18,7 +18,7 @@ CONFIG_SPL_TEXT_BASE=0x60000000
 CONFIG_DM_RESET=y
 CONFIG_ROCKCHIP_RK3066=y
 # CONFIG_ROCKCHIP_STIMER is not set
-CONFIG_TPL_TEXT_BASE=0x10080C04
+CONFIG_TPL_TEXT_BASE=0x10080c00
 CONFIG_TPL_STACK=0x1008FFFF
 CONFIG_TARGET_MK808=y
 CONFIG_SPL_STACK_R_ADDR=0x70000000
diff --git a/doc/board/rockchip/rockchip.rst b/doc/board/rockchip/rockchip.rst
index b5563b8f..7d903946 100644
--- a/doc/board/rockchip/rockchip.rst
+++ b/doc/board/rockchip/rockchip.rst
@@ -380,9 +380,8 @@ Program with commands in a bash script ./flash.sh:

         #!/bin/sh

-        printf "RK30" > tplspl.bin
-        dd if=u-boot-tpl.bin >> tplspl.bin
-        truncate -s %2048 tplspl.bin
+        printf "RK30" | dd conv=notrunc bs=4 count=1 of=u-boot-tpl.bin
+        truncate -s %2048 u-boot-tpl.bin
         truncate -s %2048 u-boot-spl.bin
         ../tools/boot_merger --verbose config-flash.ini
         ../tools/upgrade_tool ul ./RK30xxLoader_uboot.bin
@@ -406,7 +405,7 @@ config-flash.ini:
         NUM=2
         LOADER1=FlashData
         LOADER2=FlashBoot
-        FlashData=tplspl.bin
+        FlashData=u-boot-tpl.bin
         FlashBoot=u-boot-spl.bin
         [OUTPUT]
         PATH=RK30xxLoader_uboot.bin
--
2.20.1


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH v2 6/6] rockchip: configs: mk808: enable usb support
  2023-03-19 15:02 [PATCH v2 1/6] rockchip: gpio: rk_gpio: use ROCKCHIP_GPIOS_PER_BANK as divider Johan Jonker
                   ` (3 preceding siblings ...)
  2023-03-19 15:06 ` [PATCH v2 5/6] rockchip: configs: mk808: change CONFIG_TPL_TEXT_BASE Johan Jonker
@ 2023-03-19 15:06 ` Johan Jonker
  2023-03-21  3:09   ` Kever Yang
  2023-03-21  3:08 ` [PATCH v2 1/6] rockchip: gpio: rk_gpio: use ROCKCHIP_GPIOS_PER_BANK as divider Kever Yang
  5 siblings, 1 reply; 12+ messages in thread
From: Johan Jonker @ 2023-03-19 15:06 UTC (permalink / raw)
  To: kever.yang; +Cc: sjg, philipp.tomsich, u-boot

Enable usb support in the mk808_defconfig.

Signed-off-by: Johan Jonker <jbx6244@gmail.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
---
 configs/mk808_defconfig | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/configs/mk808_defconfig b/configs/mk808_defconfig
index 5a264eb9..b7dcd163 100644
--- a/configs/mk808_defconfig
+++ b/configs/mk808_defconfig
@@ -53,6 +53,9 @@ CONFIG_SYS_PBSIZE=276
 # CONFIG_BOOTM_VXWORKS is not set
 CONFIG_CMD_GPT=y
 CONFIG_CMD_MMC=y
+CONFIG_CMD_USB=y
+CONFIG_CMD_ROCKUSB=y
+CONFIG_CMD_USB_MASS_STORAGE=y
 # CONFIG_CMD_SETEXPR is not set
 CONFIG_CMD_CACHE=y
 CONFIG_CMD_TIME=y
@@ -78,6 +81,7 @@ CONFIG_TPL_SYSCON=y
 CONFIG_CLK=y
 CONFIG_SPL_CLK=y
 CONFIG_TPL_CLK=y
+CONFIG_FASTBOOT_BUF_ADDR=0x80000000
 CONFIG_ROCKCHIP_GPIO=y
 # CONFIG_SPL_DM_I2C is not set
 CONFIG_LED=y
@@ -106,6 +110,12 @@ CONFIG_TIMER=y
 CONFIG_SPL_TIMER=y
 CONFIG_TPL_TIMER=y
 CONFIG_DESIGNWARE_APB_TIMER=y
+CONFIG_USB=y
+CONFIG_USB_DWC2=y
+CONFIG_ROCKCHIP_USB2_PHY=y
+CONFIG_USB_GADGET=y
+CONFIG_USB_GADGET_DWC2_OTG=y
+CONFIG_USB_FUNCTION_ROCKUSB=y
 CONFIG_SPL_TINY_MEMSET=y
 CONFIG_ERRNO_STR=y
 # CONFIG_TPL_OF_LIBFDT is not set
--
2.20.1


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* Re: [PATCH v2 1/6] rockchip: gpio: rk_gpio: use ROCKCHIP_GPIOS_PER_BANK as divider
  2023-03-19 15:02 [PATCH v2 1/6] rockchip: gpio: rk_gpio: use ROCKCHIP_GPIOS_PER_BANK as divider Johan Jonker
                   ` (4 preceding siblings ...)
  2023-03-19 15:06 ` [PATCH v2 6/6] rockchip: configs: mk808: enable usb support Johan Jonker
@ 2023-03-21  3:08 ` Kever Yang
  5 siblings, 0 replies; 12+ messages in thread
From: Kever Yang @ 2023-03-21  3:08 UTC (permalink / raw)
  To: Johan Jonker; +Cc: sjg, philipp.tomsich, u-boot


On 2023/3/19 23:02, Johan Jonker wrote:
> The current divider to calculate the bank ID can change.
> Given the Rockchip TRM not all gpio-banks have 32 pins per bank.
> The "gpio-ranges" syntax allows multiple items with variable number
> of pins. Use a constant ROCKCHIP_GPIOS_PER_BANK as fixed divider.
>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>   drivers/gpio/rk_gpio.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/rk_gpio.c b/drivers/gpio/rk_gpio.c
> index f7ad4d68..0a2acf18 100644
> --- a/drivers/gpio/rk_gpio.c
> +++ b/drivers/gpio/rk_gpio.c
> @@ -160,7 +160,7 @@ static int rockchip_gpio_probe(struct udevice *dev)
>   					     0, &args);
>   	if (!ret || ret != -ENOENT) {
>   		uc_priv->gpio_count = args.args[2];
> -		priv->bank = args.args[1] / args.args[2];
> +		priv->bank = args.args[1] / ROCKCHIP_GPIOS_PER_BANK;
>   	} else {
>   		uc_priv->gpio_count = ROCKCHIP_GPIOS_PER_BANK;
>   		end = strrchr(dev->name, '@');
> --
> 2.20.1
>

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v2 2/6] arm: dts: rockchip: rk3066a-u-boot: add gpio-ranges
  2023-03-19 15:05 ` [PATCH v2 2/6] arm: dts: rockchip: rk3066a-u-boot: add gpio-ranges Johan Jonker
@ 2023-03-21  3:08   ` Kever Yang
  0 siblings, 0 replies; 12+ messages in thread
From: Kever Yang @ 2023-03-21  3:08 UTC (permalink / raw)
  To: Johan Jonker; +Cc: sjg, philipp.tomsich, u-boot


On 2023/3/19 23:05, Johan Jonker wrote:
> The gpio node names are made generic, but without
> gpio bank ID. Add gpio-ranges to rk3066a-u-boot.dtsi
> for now till a better method is found.
> Disable gpio6 as the driver gives an error code
> on return as status.
>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>
> Changed V2:
>    disable gpio6
> ---
>   arch/arm/dts/rk3066a-u-boot.dtsi | 25 +++++++++++++++++++++++++
>   1 file changed, 25 insertions(+)
>
> diff --git a/arch/arm/dts/rk3066a-u-boot.dtsi b/arch/arm/dts/rk3066a-u-boot.dtsi
> index bc6e609d..06f405ca 100644
> --- a/arch/arm/dts/rk3066a-u-boot.dtsi
> +++ b/arch/arm/dts/rk3066a-u-boot.dtsi
> @@ -2,3 +2,28 @@
>
>   #include "rockchip-u-boot.dtsi"
>   #include "rk3xxx-u-boot.dtsi"
> +
> +&gpio0 {
> +	gpio-ranges = <&pinctrl 0 0 32>;
> +};
> +
> +&gpio1 {
> +	gpio-ranges = <&pinctrl 0 32 32>;
> +};
> +
> +&gpio2 {
> +	gpio-ranges = <&pinctrl 0 64 32>;
> +};
> +
> +&gpio3 {
> +	gpio-ranges = <&pinctrl 0 96 32>;
> +};
> +
> +&gpio4 {
> +	gpio-ranges = <&pinctrl 0 128 32>;
> +};
> +
> +&gpio6 {
> +	status = "disabled";
> +};
> +
> --
> 2.20.1
>

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v2 3/6] arm: dts: rockchip: rk3188-u-boot: add gpio-ranges
  2023-03-19 15:05 ` [PATCH v2 3/6] arm: dts: rockchip: rk3188-u-boot: " Johan Jonker
@ 2023-03-21  3:08   ` Kever Yang
  0 siblings, 0 replies; 12+ messages in thread
From: Kever Yang @ 2023-03-21  3:08 UTC (permalink / raw)
  To: Johan Jonker; +Cc: sjg, philipp.tomsich, u-boot


On 2023/3/19 23:05, Johan Jonker wrote:
> The gpio node names are made generic, but without
> gpio bank ID. Add gpio-ranges to rk3188-u-boot.dtsi
> for now till a better method is found.
>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>   arch/arm/dts/rk3188-u-boot.dtsi | 13 +++++++++++++
>   1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm/dts/rk3188-u-boot.dtsi b/arch/arm/dts/rk3188-u-boot.dtsi
> index 735776c1..176f9e65 100644
> --- a/arch/arm/dts/rk3188-u-boot.dtsi
> +++ b/arch/arm/dts/rk3188-u-boot.dtsi
> @@ -12,6 +12,19 @@
>
>   &gpio0 {
>   	compatible = "rockchip,gpio-bank";
> +	gpio-ranges = <&pinctrl 0 0 32>;
> +};
> +
> +&gpio1 {
> +	gpio-ranges = <&pinctrl 0 32 32>;
> +};
> +
> +&gpio2 {
> +	gpio-ranges = <&pinctrl 0 64 32>;
> +};
> +
> +&gpio3 {
> +	gpio-ranges = <&pinctrl 0 96 32>;
>   };
>
>   &pmu {
> --
> 2.20.1
>

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v2 4/6] arm: dts: rockchip: sync rk3066/rk3188 DT files from linux-next v6.2-rc4
  2023-03-19 15:05 ` [PATCH v2 4/6] arm: dts: rockchip: sync rk3066/rk3188 DT files from linux-next v6.2-rc4 Johan Jonker
@ 2023-03-21  3:09   ` Kever Yang
  0 siblings, 0 replies; 12+ messages in thread
From: Kever Yang @ 2023-03-21  3:09 UTC (permalink / raw)
  To: Johan Jonker; +Cc: sjg, philipp.tomsich, u-boot


On 2023/3/19 23:05, Johan Jonker wrote:
> Sync rk3066/rk3188 DT files from Linux.
> This is the state as of linux-next v6.2-rc4.
> New nfc node for MK808 rk3066a.
> CRU nodes now have a clock property.
> To prefend dtoc errors a fixed clock must also be
> included for tpl/spl in the rk3xxx-u-boot.dtsi file.
>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>   arch/arm/dts/rk3066a-mk808.dts    | 27 ++++++++++++++++++++++++++-
>   arch/arm/dts/rk3066a.dtsi         |  3 ++-
>   arch/arm/dts/rk3188-radxarock.dts | 24 +++++++++++++-----------
>   arch/arm/dts/rk3188.dtsi          | 27 ++++++++++++++++-----------
>   arch/arm/dts/rk3xxx-u-boot.dtsi   |  4 ++++
>   arch/arm/dts/rk3xxx.dtsi          |  9 +++++++--
>   6 files changed, 68 insertions(+), 26 deletions(-)
>
> diff --git a/arch/arm/dts/rk3066a-mk808.dts b/arch/arm/dts/rk3066a-mk808.dts
> index 667d57a4..06790f05 100644
> --- a/arch/arm/dts/rk3066a-mk808.dts
> +++ b/arch/arm/dts/rk3066a-mk808.dts
> @@ -32,7 +32,7 @@
>   		keyup-threshold-microvolt = <2500000>;
>   		poll-interval = <100>;
>
> -		recovery {
> +		button-recovery {
>   			label = "recovery";
>   			linux,code = <KEY_VENDOR>;
>   			press-threshold-microvolt = <0>;
> @@ -157,7 +157,32 @@
>   	pinctrl-0 = <&sd1_clk &sd1_cmd &sd1_bus4>;
>   	pinctrl-names = "default";
>   	vmmc-supply = <&vcc_wifi>;
> +	#address-cells = <1>;
> +	#size-cells = <0>;
>   	status = "okay";
> +
> +	brcmf: wifi@1 {
> +		compatible = "brcm,bcm4329-fmac";
> +		reg = <1>;
> +	};
> +};
> +
> +&nfc {
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +	status = "okay";
> +
> +	nand@0 {
> +		reg = <0>;
> +		label = "rk-nand";
> +		nand-bus-width = <8>;
> +		nand-ecc-mode = "hw";
> +		nand-ecc-step-size = <1024>;
> +		nand-ecc-strength = <40>;
> +		nand-is-boot-medium;
> +		rockchip,boot-blks = <8>;
> +		rockchip,boot-ecc-strength = <24>;
> +	};
>   };
>
>   &pinctrl {
> diff --git a/arch/arm/dts/rk3066a.dtsi b/arch/arm/dts/rk3066a.dtsi
> index c25b9695..de9915d9 100644
> --- a/arch/arm/dts/rk3066a.dtsi
> +++ b/arch/arm/dts/rk3066a.dtsi
> @@ -202,8 +202,9 @@
>   	cru: clock-controller@20000000 {
>   		compatible = "rockchip,rk3066a-cru";
>   		reg = <0x20000000 0x1000>;
> +		clocks = <&xin24m>;
> +		clock-names = "xin24m";
>   		rockchip,grf = <&grf>;
> -
>   		#clock-cells = <1>;
>   		#reset-cells = <1>;
>   		assigned-clocks = <&cru PLL_CPLL>, <&cru PLL_GPLL>,
> diff --git a/arch/arm/dts/rk3188-radxarock.dts b/arch/arm/dts/rk3188-radxarock.dts
> index e7138a4a..118deacd 100644
> --- a/arch/arm/dts/rk3188-radxarock.dts
> +++ b/arch/arm/dts/rk3188-radxarock.dts
> @@ -6,7 +6,6 @@
>   /dts-v1/;
>   #include <dt-bindings/input/input.h>
>   #include "rk3188.dtsi"
> -#include "rk3188-radxarock-u-boot.dtsi"
>
>   / {
>   	model = "Radxa Rock";
> @@ -25,7 +24,7 @@
>   		compatible = "gpio-keys";
>   		autorepeat;
>
> -		power {
> +		key-power {
>   			gpios = <&gpio0 RK_PA4 GPIO_ACTIVE_LOW>;
>   			linux,code = <KEY_POWER>;
>   			label = "GPIO Key Power";
> @@ -72,7 +71,7 @@
>   		#sound-dai-cells = <0>;
>   	};
>
> -	ir_recv: gpio-ir-receiver {
> +	ir_recv: ir-receiver {
>   		compatible = "gpio-ir-receiver";
>   		gpios = <&gpio0 RK_PB2 GPIO_ACTIVE_LOW>;
>   		pinctrl-names = "default";
> @@ -127,18 +126,21 @@
>   };
>
>   &emac {
> -	status = "okay";
> -
> +	phy = <&phy0>;
> +	phy-supply = <&vcc_rmii>;
>   	pinctrl-names = "default";
>   	pinctrl-0 = <&emac_xfer>, <&emac_mdio>, <&phy_int>;
> +	status = "okay";
>
> -	phy = <&phy0>;
> -	phy-supply = <&vcc_rmii>;
> +	mdio {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
>
> -	phy0: ethernet-phy@0 {
> -		reg = <0>;
> -		interrupt-parent = <&gpio3>;
> -		interrupts = <RK_PD2 IRQ_TYPE_LEVEL_LOW>;
> +		phy0: ethernet-phy@0 {
> +			reg = <0>;
> +			interrupt-parent = <&gpio3>;
> +			interrupts = <RK_PD2 IRQ_TYPE_LEVEL_LOW>;
> +		};
>   	};
>   };
>
> diff --git a/arch/arm/dts/rk3188.dtsi b/arch/arm/dts/rk3188.dtsi
> index 9a80f83a..44b54af0 100644
> --- a/arch/arm/dts/rk3188.dtsi
> +++ b/arch/arm/dts/rk3188.dtsi
> @@ -54,7 +54,7 @@
>   		};
>   	};
>
> -	cpu0_opp_table: opp_table0 {
> +	cpu0_opp_table: opp-table-0 {
>   		compatible = "operating-points-v2";
>   		opp-shared;
>
> @@ -195,8 +195,9 @@
>   	cru: clock-controller@20000000 {
>   		compatible = "rockchip,rk3188-cru";
>   		reg = <0x20000000 0x1000>;
> +		clocks = <&xin24m>;
> +		clock-names = "xin24m";
>   		rockchip,grf = <&grf>;
> -
>   		#clock-cells = <1>;
>   		#reset-cells = <1>;
>   	};
> @@ -223,7 +224,7 @@
>   		#size-cells = <1>;
>   		ranges;
>
> -		gpio0: gpio0@2000a000 {
> +		gpio0: gpio@2000a000 {
>   			compatible = "rockchip,rk3188-gpio-bank0";
>   			reg = <0x2000a000 0x100>;
>   			interrupts = <GIC_SPI 54 IRQ_TYPE_LEVEL_HIGH>;
> @@ -236,7 +237,7 @@
>   			#interrupt-cells = <2>;
>   		};
>
> -		gpio1: gpio1@2003c000 {
> +		gpio1: gpio@2003c000 {
>   			compatible = "rockchip,gpio-bank";
>   			reg = <0x2003c000 0x100>;
>   			interrupts = <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>;
> @@ -249,7 +250,7 @@
>   			#interrupt-cells = <2>;
>   		};
>
> -		gpio2: gpio2@2003e000 {
> +		gpio2: gpio@2003e000 {
>   			compatible = "rockchip,gpio-bank";
>   			reg = <0x2003e000 0x100>;
>   			interrupts = <GIC_SPI 56 IRQ_TYPE_LEVEL_HIGH>;
> @@ -262,7 +263,7 @@
>   			#interrupt-cells = <2>;
>   		};
>
> -		gpio3: gpio3@20080000 {
> +		gpio3: gpio@20080000 {
>   			compatible = "rockchip,gpio-bank";
>   			reg = <0x20080000 0x100>;
>   			interrupts = <GIC_SPI 57 IRQ_TYPE_LEVEL_HIGH>;
> @@ -275,15 +276,15 @@
>   			#interrupt-cells = <2>;
>   		};
>
> -		pcfg_pull_up: pcfg_pull_up {
> +		pcfg_pull_up: pcfg-pull-up {
>   			bias-pull-up;
>   		};
>
> -		pcfg_pull_down: pcfg_pull_down {
> +		pcfg_pull_down: pcfg-pull-down {
>   			bias-pull-down;
>   		};
>
> -		pcfg_pull_none: pcfg_pull_none {
> +		pcfg_pull_none: pcfg-pull-none {
>   			bias-disable;
>   		};
>
> @@ -378,7 +379,7 @@
>   				rockchip,pins = <2 RK_PD3 1 &pcfg_pull_none>;
>   			};
>
> -			lcdc1_rgb24: ldcd1-rgb24 {
> +			lcdc1_rgb24: lcdc1-rgb24 {
>   				rockchip,pins = <2 RK_PA0 1 &pcfg_pull_none>,
>   						<2 RK_PA1 1 &pcfg_pull_none>,
>   						<2 RK_PA2 1 &pcfg_pull_none>,
> @@ -606,7 +607,6 @@
>
>   &global_timer {
>   	interrupts = <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_EDGE_RISING)>;
> -	status = "disabled";
>   };
>
>   &local_timer {
> @@ -641,6 +641,11 @@
>   &grf {
>   	compatible = "rockchip,rk3188-grf", "syscon", "simple-mfd";
>
> +	io_domains: io-domains {
> +		compatible = "rockchip,rk3188-io-voltage-domain";
> +		status = "disabled";
> +	};
> +
>   	usbphy: usbphy {
>   		compatible = "rockchip,rk3188-usb-phy";
>   		#address-cells = <1>;
> diff --git a/arch/arm/dts/rk3xxx-u-boot.dtsi b/arch/arm/dts/rk3xxx-u-boot.dtsi
> index e67432fb..c77d1fae 100644
> --- a/arch/arm/dts/rk3xxx-u-boot.dtsi
> +++ b/arch/arm/dts/rk3xxx-u-boot.dtsi
> @@ -33,3 +33,7 @@
>   &uart2 {
>   	clock-frequency = <24000000>;
>   };
> +
> +&xin24m {
> +	u-boot,dm-pre-reloc;
> +};
> diff --git a/arch/arm/dts/rk3xxx.dtsi b/arch/arm/dts/rk3xxx.dtsi
> index 616a828e..cb4e42ed 100644
> --- a/arch/arm/dts/rk3xxx.dtsi
> +++ b/arch/arm/dts/rk3xxx.dtsi
> @@ -76,6 +76,13 @@
>   		reg = <0x1013c200 0x20>;
>   		interrupts = <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_EDGE_RISING)>;
>   		clocks = <&cru CORE_PERI>;
> +		status = "disabled";
> +		/* The clock source and the sched_clock provided by the arm_global_timer
> +		 * on Rockchip rk3066a/rk3188 are quite unstable because their rates
> +		 * depend on the CPU frequency.
> +		 * Keep the arm_global_timer disabled in order to have the
> +		 * DW_APB_TIMER (rk3066a) or ROCKCHIP_TIMER (rk3188) selected by default.
> +		 */
>   	};
>
>   	local_timer: local-timer@1013c600 {
> @@ -186,8 +193,6 @@
>   		compatible = "snps,arc-emac";
>   		reg = <0x10204000 0x3c>;
>   		interrupts = <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>;
> -		#address-cells = <1>;
> -		#size-cells = <0>;
>
>   		rockchip,grf = <&grf>;
>
> --
> 2.20.1
>

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v2 5/6] rockchip: configs: mk808: change CONFIG_TPL_TEXT_BASE
  2023-03-19 15:06 ` [PATCH v2 5/6] rockchip: configs: mk808: change CONFIG_TPL_TEXT_BASE Johan Jonker
@ 2023-03-21  3:09   ` Kever Yang
  0 siblings, 0 replies; 12+ messages in thread
From: Kever Yang @ 2023-03-21  3:09 UTC (permalink / raw)
  To: Johan Jonker; +Cc: sjg, philipp.tomsich, u-boot


On 2023/3/19 23:06, Johan Jonker wrote:
> Currently the Rockchip rk3066a u-boot-tpl.bin file needs
> to add the characters "RK30", while the other SoCs replace
> the first 4 bytes. Bring this in line with the rest by
> lowering CONFIG_TPL_TEXT_BASE and update rockchip.rst
> instructions.
>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>
> Changed V2:
>    use lower case hex
> ---
>   configs/mk808_defconfig         | 2 +-
>   doc/board/rockchip/rockchip.rst | 7 +++----
>   2 files changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/configs/mk808_defconfig b/configs/mk808_defconfig
> index c080706d..5a264eb9 100644
> --- a/configs/mk808_defconfig
> +++ b/configs/mk808_defconfig
> @@ -18,7 +18,7 @@ CONFIG_SPL_TEXT_BASE=0x60000000
>   CONFIG_DM_RESET=y
>   CONFIG_ROCKCHIP_RK3066=y
>   # CONFIG_ROCKCHIP_STIMER is not set
> -CONFIG_TPL_TEXT_BASE=0x10080C04
> +CONFIG_TPL_TEXT_BASE=0x10080c00
>   CONFIG_TPL_STACK=0x1008FFFF
>   CONFIG_TARGET_MK808=y
>   CONFIG_SPL_STACK_R_ADDR=0x70000000
> diff --git a/doc/board/rockchip/rockchip.rst b/doc/board/rockchip/rockchip.rst
> index b5563b8f..7d903946 100644
> --- a/doc/board/rockchip/rockchip.rst
> +++ b/doc/board/rockchip/rockchip.rst
> @@ -380,9 +380,8 @@ Program with commands in a bash script ./flash.sh:
>
>           #!/bin/sh
>
> -        printf "RK30" > tplspl.bin
> -        dd if=u-boot-tpl.bin >> tplspl.bin
> -        truncate -s %2048 tplspl.bin
> +        printf "RK30" | dd conv=notrunc bs=4 count=1 of=u-boot-tpl.bin
> +        truncate -s %2048 u-boot-tpl.bin
>           truncate -s %2048 u-boot-spl.bin
>           ../tools/boot_merger --verbose config-flash.ini
>           ../tools/upgrade_tool ul ./RK30xxLoader_uboot.bin
> @@ -406,7 +405,7 @@ config-flash.ini:
>           NUM=2
>           LOADER1=FlashData
>           LOADER2=FlashBoot
> -        FlashData=tplspl.bin
> +        FlashData=u-boot-tpl.bin
>           FlashBoot=u-boot-spl.bin
>           [OUTPUT]
>           PATH=RK30xxLoader_uboot.bin
> --
> 2.20.1
>

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v2 6/6] rockchip: configs: mk808: enable usb support
  2023-03-19 15:06 ` [PATCH v2 6/6] rockchip: configs: mk808: enable usb support Johan Jonker
@ 2023-03-21  3:09   ` Kever Yang
  0 siblings, 0 replies; 12+ messages in thread
From: Kever Yang @ 2023-03-21  3:09 UTC (permalink / raw)
  To: Johan Jonker; +Cc: sjg, philipp.tomsich, u-boot


On 2023/3/19 23:06, Johan Jonker wrote:
> Enable usb support in the mk808_defconfig.
>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>   configs/mk808_defconfig | 10 ++++++++++
>   1 file changed, 10 insertions(+)
>
> diff --git a/configs/mk808_defconfig b/configs/mk808_defconfig
> index 5a264eb9..b7dcd163 100644
> --- a/configs/mk808_defconfig
> +++ b/configs/mk808_defconfig
> @@ -53,6 +53,9 @@ CONFIG_SYS_PBSIZE=276
>   # CONFIG_BOOTM_VXWORKS is not set
>   CONFIG_CMD_GPT=y
>   CONFIG_CMD_MMC=y
> +CONFIG_CMD_USB=y
> +CONFIG_CMD_ROCKUSB=y
> +CONFIG_CMD_USB_MASS_STORAGE=y
>   # CONFIG_CMD_SETEXPR is not set
>   CONFIG_CMD_CACHE=y
>   CONFIG_CMD_TIME=y
> @@ -78,6 +81,7 @@ CONFIG_TPL_SYSCON=y
>   CONFIG_CLK=y
>   CONFIG_SPL_CLK=y
>   CONFIG_TPL_CLK=y
> +CONFIG_FASTBOOT_BUF_ADDR=0x80000000
>   CONFIG_ROCKCHIP_GPIO=y
>   # CONFIG_SPL_DM_I2C is not set
>   CONFIG_LED=y
> @@ -106,6 +110,12 @@ CONFIG_TIMER=y
>   CONFIG_SPL_TIMER=y
>   CONFIG_TPL_TIMER=y
>   CONFIG_DESIGNWARE_APB_TIMER=y
> +CONFIG_USB=y
> +CONFIG_USB_DWC2=y
> +CONFIG_ROCKCHIP_USB2_PHY=y
> +CONFIG_USB_GADGET=y
> +CONFIG_USB_GADGET_DWC2_OTG=y
> +CONFIG_USB_FUNCTION_ROCKUSB=y
>   CONFIG_SPL_TINY_MEMSET=y
>   CONFIG_ERRNO_STR=y
>   # CONFIG_TPL_OF_LIBFDT is not set
> --
> 2.20.1
>

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2023-03-21  3:10 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-19 15:02 [PATCH v2 1/6] rockchip: gpio: rk_gpio: use ROCKCHIP_GPIOS_PER_BANK as divider Johan Jonker
2023-03-19 15:05 ` [PATCH v2 2/6] arm: dts: rockchip: rk3066a-u-boot: add gpio-ranges Johan Jonker
2023-03-21  3:08   ` Kever Yang
2023-03-19 15:05 ` [PATCH v2 3/6] arm: dts: rockchip: rk3188-u-boot: " Johan Jonker
2023-03-21  3:08   ` Kever Yang
2023-03-19 15:05 ` [PATCH v2 4/6] arm: dts: rockchip: sync rk3066/rk3188 DT files from linux-next v6.2-rc4 Johan Jonker
2023-03-21  3:09   ` Kever Yang
2023-03-19 15:06 ` [PATCH v2 5/6] rockchip: configs: mk808: change CONFIG_TPL_TEXT_BASE Johan Jonker
2023-03-21  3:09   ` Kever Yang
2023-03-19 15:06 ` [PATCH v2 6/6] rockchip: configs: mk808: enable usb support Johan Jonker
2023-03-21  3:09   ` Kever Yang
2023-03-21  3:08 ` [PATCH v2 1/6] rockchip: gpio: rk_gpio: use ROCKCHIP_GPIOS_PER_BANK as divider Kever Yang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox