From: "Benoît Thébaudeau" <benoit.thebaudeau@advansee.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mtest: Disable dcache during test
Date: Sat, 11 Aug 2012 22:25:52 +0200 (CEST) [thread overview]
Message-ID: <262663635.2305092.1344716752297.JavaMail.root@advansee.com> (raw)
In-Reply-To: <201208111615.17567.vapier@gentoo.org>
On Saturday 11 August 2012 22:15:16 Mike Frysinger wrote:
> On Saturday 11 August 2012 16:05:36 Beno?t Th?baudeau wrote:
> > On 08/11/2012 21:47, Andrew Dyer wrote:
> > > I agree with Mike, use the current dcache settings. U-boot has
> > > always
> > > assumed the user knew what they were doing.
> > > If you want to print a small message with the dcache setting that
> > > makes sense to me, but no big warning.
> >
> > Then, something like the following at runtime in the first lines
> > printed my
> > mtest?
> >
> > dcache state: on
>
> i'd be fine with that. something like below (if you want to test &
> post,
> that'd be good).
> -mike
>
> diff --git a/common/cmd_mem.c b/common/cmd_mem.c
> index 18f0a3f..5628f6a 100644
> --- a/common/cmd_mem.c
> +++ b/common/cmd_mem.c
> @@ -651,8 +651,10 @@ int do_mem_mtest (cmd_tbl_t *cmdtp, int flag,
> int argc, char * const argv[])
> else
> iteration_limit = 0;
>
> + printf("Testing %08x ... %08x (dcache: %s):\n", (uint)start,
> (uint)end,
> + dcache_status() ? "on" : "off");
> +
> #if defined(CONFIG_SYS_ALT_MEMTEST)
> - printf ("Testing %08x ... %08x:\n", (uint)start, (uint)end);
> debug("%s:%d: start 0x%p end 0x%p\n",
> __FUNCTION__, __LINE__, start, end);
OK, I'll do that next week.
Best regards,
Beno?t
next prev parent reply other threads:[~2012-08-11 20:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CANYL96C2=fYHoTAp0SQird-Yz1W2JPq22U=3q4ZFKgwomXxODA@mail.gmail.com>
2012-08-11 20:05 ` [U-Boot] [PATCH] mtest: Disable dcache during test Benoît Thébaudeau
2012-08-11 20:15 ` Mike Frysinger
2012-08-11 20:25 ` Benoît Thébaudeau [this message]
2012-08-13 10:59 ` [U-Boot] [PATCH] mtest: Print dcache state Benoît Thébaudeau
2012-10-03 22:05 ` [U-Boot] " Tom Rini
2012-10-04 11:03 ` Albert ARIBAUD
2012-10-04 11:13 ` Benoît Thébaudeau
2012-10-04 14:15 ` Tom Rini
2012-08-14 6:27 ` [U-Boot] [PATCH] mtest: Disable dcache during test Albert ARIBAUD
2012-08-10 19:16 Benoît Thébaudeau
2012-08-11 3:18 ` Mike Frysinger
2012-08-11 14:17 ` Benoît Thébaudeau
2012-08-11 17:50 ` Mike Frysinger
2012-08-11 18:49 ` Benoît Thébaudeau
2012-09-02 16:30 ` Wolfgang Denk
2012-09-03 14:25 ` Benoît Thébaudeau
2012-09-03 16:50 ` Albert ARIBAUD
2012-09-03 21:14 ` Benoît Thébaudeau
2012-09-03 23:30 ` Graeme Russ
2012-09-04 6:41 ` Wolfgang Denk
2012-09-04 6:43 ` Graeme Russ
2012-09-04 7:23 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=262663635.2305092.1344716752297.JavaMail.root@advansee.com \
--to=benoit.thebaudeau@advansee.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox