From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9CED5C433EF for ; Thu, 24 Mar 2022 01:49:42 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id ED68D84031; Thu, 24 Mar 2022 02:49:39 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="hAis55vh"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1815284050; Thu, 24 Mar 2022 02:49:37 +0100 (CET) Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6EAE384046 for ; Thu, 24 Mar 2022 02:49:33 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: phobos.denx.de; spf=none smtp.helo=mail-wr1-x434.google.com Received: by mail-wr1-x434.google.com with SMTP id h4so4550872wrc.13 for ; Wed, 23 Mar 2022 18:49:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=K98KUmcfMGjI0gUG2pgGDAiyqUietgpKtR4+JTo+aEU=; b=hAis55vh0B6NUWYTjQ/OvLE1oyrpfySqSIYIwu7Jg/6wLq+FddUImgw4uzi/MuUrnm 9pQ2y0auqdmfeQTYZTYcf2Cp39UcXwvgfMKoVRZyNhD+gIdLifiZbPXyXy9HDjRnYwID 7ubWDbcNxamXAdJ2MsGMTsfBLQfIY1PLWVdII= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=K98KUmcfMGjI0gUG2pgGDAiyqUietgpKtR4+JTo+aEU=; b=a/zASLp8EGjWIEEB6ntUPPT0yHNzyWVBRVb71A9M8HsukC58pmm5KgsAHEFI4b9EHx 0trNIo0zqFHuPE8CvNn1llR/eOl5ZwIuIRxngKkpfC6FzEBRupmpRfOu++rhZGbjnQOt +U2Gh/T5Fi1W6fuZ1w/5znX3eZ6RZsmVLeTjcCTpwFjsvEEcuGkZ2RZMILh7agDdGsnT eh64UOdVPW2nCbrleDrq+baHiB8rpu3ZluQCYVtlftXAIVZCH56eNlRt9ekEsmpK9WmD 4KfQKgBrqaO1fTNnHYuVhd6Lq7AEqA1Nmiv+XLDRv6Epwr1QD1qVkvp366JJOKvJQBm2 4MGg== X-Gm-Message-State: AOAM531SmF50rbvpd38jYUdItGStBhafXK2CxY+vnqp/CVGc63HVDrGC mxnRxa5REBsXKm0G1NeYfE5q/A== X-Google-Smtp-Source: ABdhPJzv44J1NUzN6uycPaipTZq+KYGhUTU2kSbefgKgOxNmIy6EYCaU0QCHYwxt6Ub+6h4EUWxMNQ== X-Received: by 2002:a5d:40ca:0:b0:203:e037:cd0e with SMTP id b10-20020a5d40ca000000b00203e037cd0emr2462756wrq.534.1648086572910; Wed, 23 Mar 2022 18:49:32 -0700 (PDT) Received: from pwmachine.localnet ([92.186.13.154]) by smtp.gmail.com with ESMTPSA id 10-20020adf808a000000b001edd413a952sm1239441wrl.95.2022.03.23.18.49.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Mar 2022 18:49:32 -0700 (PDT) From: Francis Laniel To: Simon Glass Cc: U-Boot Mailing List , Marek Behun , Michael Nazzareno Trimarchi , Wolfgang Denk , Harald Seiler Subject: Re: [RFC PATCH v1 16/21] test: hush: Fix variable expansion tests for hush 2021. Date: Thu, 24 Mar 2022 02:49:30 +0100 Message-ID: <2629755.mvXUDI8C0e@pwmachine> In-Reply-To: References: <20211231161327.24918-1-francis.laniel@amarulasolutions.com> <12953040.uLZWGnKmhe@pwmachine> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hi. (Sorry for the very late reply) Le lundi 7 f=E9vrier 2022, 21:22:20 CET Simon Glass a =E9crit : > Hi Francis, >=20 > On Sun, 6 Feb 2022 at 11:23, Francis Laniel >=20 > wrote: > > Le mercredi 12 janvier 2022, 21:03:37 CET Simon Glass a =E9crit : > > > Hi Francis, > > >=20 > > > On Fri, 31 Dec 2021 at 09:14, Francis Laniel > > >=20 > > > wrote: > > > > This commit modifies the expected result for hush 2021. > > > > Indeed, there were bugs in actual U-Boot hush which were fixed in > > > > upstream > > > > Busybox. > > > > As hush 2021 is based on upstream Busybox, these bugs no longer exi= st. > > > >=20 > > > > Signed-off-by: Francis Laniel > > > > --- > > > >=20 > > > > test/hush/dollar.c | 51 > > > > ++++++++++++++++++++++++++++++++++++++++++++++ > > > > 1 file changed, 51 insertions(+) > > >=20 > > > Reviewed-by: Simon Glass > > >=20 > > > Can you avoid the preprocessor macros? > > >=20 > > > Also, for testing we really want to be able to run both sets of tests > > > in sandbox, so the parser needs to be run-time selectable. > >=20 > > To be sure, you would like to have a global variable named, for example, > > parser which value could be: > > * parser =3D "old", for old hush parser > > * parser =3D "2021", for "new" hush parser > > Is my understanding correct? >=20 > Yes although an int would be better than a string, perhaps controlled > by a flag in global_data and a 'cli' subcommand to change the > setting. If I understand correctly, that would mean to compile both the old and new= =20 parser? Hence, I think I will need to rename some functions in the new parser to av= oid=20 problems at this level. > Regards, > Simon