From: Stephen Williams <gfi8d1h02@sneakemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] Re: A Shared flash.c
Date: Fri, 05 Mar 2004 09:54:22 -0800 [thread overview]
Message-ID: <26365-62604@sneakemail.com> (raw)
In-Reply-To: <4048BB13.6090103@icarus.com>
Stephen Williams wrote:
>
> The JSE board (PPC405GPr) I'm working on has an 8-bit flash
> that is attached to the local bus, and I find that the flash.c
> from board/walnut405 is almost identical. (I just needed to add
> a case for a different chip vendor.) Would it make sense to
> move more of its contents to common/flash.c? For example,
> the flash_printinfo function seems like a candidate.
>
> Would patches to that effect be accepted?
Well gee, it seems like flash_print_info in particular should
go into the cmd_flash.c file, *inside* the (CONFIG_COMMANDS & CFG_CMD_FLASH)
section. The flinfo command is the only place it is used. There
are a few other functions like that, but print_flash_info is the
most glaring example.
--
Steve Williams "The woods are lovely, dark and deep.
steve at XXXXXXXXXX But I have promises to keep,
http://www.XXXXXXXXXX and lines to code before I sleep,
http://www.picturel.com And lines to code before I sleep."
next parent reply other threads:[~2004-03-05 17:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4048BB13.6090103@icarus.com>
2004-03-05 17:54 ` Stephen Williams [this message]
2004-03-05 21:42 ` [U-Boot-Users] Re: A Shared flash.c Wolfgang Denk
2004-03-05 23:06 ` Stephen Williams
2004-03-05 23:19 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26365-62604@sneakemail.com \
--to=gfi8d1h02@sneakemail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox