From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Williams Date: Fri, 05 Mar 2004 09:54:22 -0800 Subject: [U-Boot-Users] Re: A Shared flash.c In-Reply-To: <4048BB13.6090103@icarus.com> References: <4048BB13.6090103@icarus.com> Message-ID: <26365-62604@sneakemail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Stephen Williams wrote: > > The JSE board (PPC405GPr) I'm working on has an 8-bit flash > that is attached to the local bus, and I find that the flash.c > from board/walnut405 is almost identical. (I just needed to add > a case for a different chip vendor.) Would it make sense to > move more of its contents to common/flash.c? For example, > the flash_printinfo function seems like a candidate. > > Would patches to that effect be accepted? Well gee, it seems like flash_print_info in particular should go into the cmd_flash.c file, *inside* the (CONFIG_COMMANDS & CFG_CMD_FLASH) section. The flinfo command is the only place it is used. There are a few other functions like that, but print_flash_info is the most glaring example. -- Steve Williams "The woods are lovely, dark and deep. steve at XXXXXXXXXX But I have promises to keep, http://www.XXXXXXXXXX and lines to code before I sleep, http://www.picturel.com And lines to code before I sleep."