From: Marc Dietrich <marvin24@gmx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] tegra: enable lp0 on paz00
Date: Sun, 16 Sep 2012 18:16:54 +0200 [thread overview]
Message-ID: <2665033.d59fTI81xY@ax5200p> (raw)
In-Reply-To: <5FBF8E85CA34454794F0F7ECBA79798F379F39979E@HQMAIL04.nvidia.com>
Tom,
On Monday 10 September 2012 12:32:00 Tom Warren wrote:
> > -----Original Message-----
> > From: Stephen Warren [mailto:swarren at wwwdotorg.org]
> > Sent: Monday, September 10, 2012 12:08 PM
> > To: Marc Dietrich
> > Cc: u-boot at lists.denx.de; Tom Warren
> > Subject: Re: [PATCH 2/2] tegra: enable lp0 on paz00
> >
> > On 09/10/2012 12:51 PM, Marc Dietrich wrote:
> > > This enables LP0 to support suspend / resume on PAZ00.
> >
> > Ooh. Did you test this out with the AC100 kernel, and have it work?
> > That'd be pretty cool...
> >
> > > diff --git a/board/compal/paz00/Makefile b/board/compal/paz00/Makefile
> > >
> > > -COBJS := $(BOARD).o
> > > -COBJS += ../../nvidia/common/board.o
> > > +COBJS-y := $(BOARD).o
> > > +COBJS-y += ../../nvidia/common/board.o
> > > +COBJS-$(CONFIG_TEGRA_CLOCK_SCALING) += ../../nvidia/common/emc.o
> >
> > Hmmm. That's odd. I'd expect that to be part of the core Tegra code,
> > rather
> > than something boards have to pull in manually.
I checked this again. The Makefile in nvidia/common is never executed on non
nvidia boards (it is included from the topdir Makefile
($vendor/common/Makefile).
Therefore the explicit "COBJS += ../../nvidia/common/board.o" in the paz00
Makefile is needed. So either we have to add ../../nvidia/common/foo.o to all
non nvidia boards or we "source" the whole Makefile somehow else.
Marc
> Stephen's right - this is already done in ../cpu/tegra20-common/Makefile
> when CONFIG_TEGRA_CLOCK_SCALING is defined. So no need to change the PAZ00
> Makefile.
> > > diff --git a/include/configs/paz00.h b/include/configs/paz00.h
> > >
> > > +/* LP0 suspend / resume */
> > > +#define CONFIG_TEGRA20_LP0
> >
> > That's been renamed CONFIG_TEGRA_LP0 in u-boot-tegra/next.
>
> As part of the pre-work for Tegra30 changes, I've changed generic Tegra
> defines, labels, etc. to be more non-specific, unless it does really refer
> to a Tegra20 feature, file, etc. As Stephen says, see u-boot-tegra/next's
> top commit.
>
> Tom
next prev parent reply other threads:[~2012-09-16 16:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-10 18:51 [U-Boot] [PATCH 1/2] tegra: i2c: Enable I2C on PAZ00 Marc Dietrich
2012-09-10 18:51 ` [U-Boot] [PATCH 2/2] tegra: enable lp0 on paz00 Marc Dietrich
2012-09-10 19:07 ` Stephen Warren
2012-09-10 19:32 ` Tom Warren
2012-09-16 16:16 ` Marc Dietrich [this message]
2012-09-17 16:09 ` Tom Warren
2012-09-10 19:53 ` Marc Dietrich
2012-09-10 19:04 ` [U-Boot] [PATCH 1/2] tegra: i2c: Enable I2C on PAZ00 Stephen Warren
2012-09-10 19:57 ` Marc Dietrich
2012-09-10 20:55 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2665033.d59fTI81xY@ax5200p \
--to=marvin24@gmx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox