From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EB91C433FE for ; Mon, 4 Oct 2021 12:05:48 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C3839613DB for ; Mon, 4 Oct 2021 12:05:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C3839613DB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4AE0F81E1C; Mon, 4 Oct 2021 14:05:44 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1633349144; bh=W/rBswqWJQAUW9q8SMP2f0WYgwColnYVqcDKI1f7Fzs=; h=To:cc:From:Subject:In-reply-to:References:Date:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=zgpwQvwU4fiEZMoVfmSovmlDDd0VWVQIEOufsQlt0c/sTCgN+BunsnNgxmN9+md0r Hu/EAEVvwOAdZcPQG55l6qNx29SbkJeGVjl6wikViEaHRjJkvOGeEIiA3nVJmqfMOJ +70eh6pD4A9hiXph1icAyzCtn1DmzsxWtoCHjIarjZafT9S7+FU/fMqYmdMc63ZZjx U08d84+DofPqID3w4cgO96YHhlytgVQD+y9WCk1aMpqkVF1i3sI2BwSQl7v7iju36x hmJAfPYkBJLFTMxi7ldDN6jw/uhXz/EV3n3N3CdbynDcOtG6wnjsPyqtuD7b5shTRq PGHlUdcUX9cTw== Received: from janitor.denx.de (unknown [62.91.23.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: noc@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 6693381197 for ; Mon, 4 Oct 2021 14:05:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1633349142; bh=W/rBswqWJQAUW9q8SMP2f0WYgwColnYVqcDKI1f7Fzs=; h=To:cc:From:Subject:In-reply-to:References:Date:From; b=zLUEFMHOax9H+oMcU3UjUYMRpFRT5/mzJBFLyQIjV2GGEsboNDmuwYWh3RGq2b0B6 2QC4gUKEQNAM521w/gErOvpiJlnI24PvxWr8auYmAKskJEtFZpCBz7p4IC8qU50mCF 9UqtfwnV72Jg91J6/jidL2/4OmRRr+oWbPHMXPnkopC/nWLr5nvaFWIo6JVvcyf4xg xnHZDglVOwHTxP/RkZaYt54fFeIWh2cFNgVTxxndeSNj3Lp/AbSTJxm3PoamOFTYrq FGqmCmqBEN4FRrzP+bfr67B0OkzHtR/VttHKwua9en2y9H3r3VaPMyc3CVG5qz9Qfh 6nRJ9WyTz/ELA== Received: by janitor.denx.de (Postfix, from userid 108) id 1D4ACA011E; Mon, 4 Oct 2021 14:05:42 +0200 (CEST) Received: from gemini.denx.de (gemini.denx.de [10.4.0.2]) by janitor.denx.de (Postfix) with ESMTPS id 2203DA00A4; Mon, 4 Oct 2021 14:05:34 +0200 (CEST) Received: from gemini.denx.de (localhost [IPv6:::1]) by gemini.denx.de (Postfix) with ESMTP id A7E251E0F1B; Mon, 4 Oct 2021 14:05:33 +0200 (CEST) To: Simon Glass cc: U-Boot Mailing List , Tom Rini From: Wolfgang Denk Subject: Re: [PATCH v5 2/5] doc: Move environment documentation to rST MIME-Version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8bit In-reply-to: <20211002003848.1803446-3-sjg@chromium.org> References: <20211002003848.1803446-1-sjg@chromium.org> <20211002003848.1803446-3-sjg@chromium.org> Comments: In-reply-to Simon Glass message dated "Fri, 01 Oct 2021 18:38:44 -0600." Date: Mon, 04 Oct 2021 14:05:33 +0200 Message-ID: <2672853.1633349133@gemini.denx.de> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Dear Simon, In message <20211002003848.1803446-3-sjg@chromium.org> you wrote: > > +baudrate > + see CONFIG_BAUDRATE > + > +bootdelay > + see CONFIG_BOOTDELAY > + > +bootcmd > + see CONFIG_BOOTCOMMAND I know you only copied this, but the text is actually not helpful, as it does not even mention where to look for documentation for these CONFIG_* options > +autoload > + if set to "no" (any string beginning with 'n'), > + "bootp" will just load perform a lookup of the > + configuration from the BOOTP server, but not try to > + load any image using TFTP We should add "dhcp" here, too. > +autostart > + if set to "yes", an image loaded using the "bootp", > + "rarpboot", "tftpboot" or "diskboot" commands will > + be automatically started (by internally calling > + "bootm") > + > + If set to "no", a standalone image passed to the > + "bootm" command will be copied to the load address > + (and eventually uncompressed), but NOT be started. > + This can be used to load and uncompress arbitrary > + data. There is a consistency problem here. In "bootm" (cmd/bootm.c), the "yes" part applies - any other value or the variable not being defined omitting the call of do_bootm(). This also applies to nandboot, btw. In "bootelf" (cmd/elf.c), the "no" part applies - any other value or the variable not being defined will cause do_bootelf_exec() to be called. This should be both documented and fixed. > +ipaddr > + IP address; needed for tftpboot command ...and for ping etc. > +vlan > + When set to a value < 4095 the traffic over > + Ethernet is encapsulated/received over 802.1q > + VLAN tagged frames. Really? I can't see where "vlan" is actually used in the code. [I looked for it because I could not remember if the values is interpreted as decimal or hex number...] Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de Systems programmers are the high priests of a low cult. -- R.S. Barton