From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FBB0C433EF for ; Mon, 4 Oct 2021 12:12:48 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8EB1A6113A for ; Mon, 4 Oct 2021 12:12:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8EB1A6113A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C3E22820E3; Mon, 4 Oct 2021 14:12:44 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1633349565; bh=3NSEYQv9mJoXZOaiSGQzYpM82ygGBqYXw14B+1eUHTA=; h=To:cc:From:Subject:In-reply-to:References:Date:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=IUUTfV4cixkSibwvCGOBPHHws2WHF0pmvwyXrI4VbnBSoU9LUqaAtJY18yOyAFTCK 9gR6qO+D/924uvi6QiqHOwf+QAsgKe3LHtfYIe+1r2+m4W/qIf/TMadjz7AlnT17PF Sr/qfFOKfrNGPiM9QwSbfWvdhJopJrj+d5CEc3NpviG3IyDE/CvOmPGTqlO0obcb8s 5WROCPFHYuXwsHhDowhr3a1tdukspmF5S4EFWzFhgMEkmKct3dbMxomrj6PgcNarHS wrdjkFUP7ZrN5/E+tj96i48jcUNnz2TluAjcF9V+IHni7YLaRUK3QoDo5kZQLKSHDq 4+F39y5N9PT2g== Received: from janitor.denx.de (unknown [62.91.23.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: noc@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id E388281196 for ; Mon, 4 Oct 2021 14:12:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1633349561; bh=3NSEYQv9mJoXZOaiSGQzYpM82ygGBqYXw14B+1eUHTA=; h=To:cc:From:Subject:In-reply-to:References:Date:From; b=nMxCgcBwYoVwA8oGZAwDWwsVk+AAp9UvDbScAgZ88v7JZuoOAqWaj1051SCuBns2Y x2UAeh6I+/he8cKGyWTjb/cxBi5w1DzvwWr5Rgiv9sMc6X6i0hwO673+reeDlS0wHP T4Hh8cGcPa9Bw8JZ3mI3n/7HVOFBDLYtFb27gF4UWhsUZuJoj0ON2nagTg+Q0hrZtL GO8ryo4+4pMTD1eOfPXT6djIAYPs5uVx4zvbBzTap8nH/AfNuehj/2mabYVGGChmED 7VaVHUGHe0YQjWRnbqSdcyVrGtJGFA/M4Ouzm2nhp3DJICDg2V0dH7E0EQPNNe1KLm oNIoBppBoGmlw== Received: by janitor.denx.de (Postfix, from userid 108) id 96D6FA0120; Mon, 4 Oct 2021 14:12:41 +0200 (CEST) Received: from gemini.denx.de (gemini.denx.de [10.4.0.2]) by janitor.denx.de (Postfix) with ESMTPS id AFB1CA011C; Mon, 4 Oct 2021 14:12:32 +0200 (CEST) Received: from gemini.denx.de (localhost [IPv6:::1]) by gemini.denx.de (Postfix) with ESMTP id 690CD1E0F1B; Mon, 4 Oct 2021 14:12:32 +0200 (CEST) To: Simon Glass cc: U-Boot Mailing List , Tom Rini , Joe Hershberger From: Wolfgang Denk Subject: Re: [PATCH v5 4/5] env: Allow environment files to use the C preprocessor MIME-Version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8bit In-reply-to: <20211001183842.v5.4.Ie78bfbfca0d01d9cba501e127f446ec48e1f7afe@changeid> References: <20211002003848.1803446-1-sjg@chromium.org> <20211001183842.v5.4.Ie78bfbfca0d01d9cba501e127f446ec48e1f7afe@changeid> Comments: In-reply-to Simon Glass message dated "Fri, 01 Oct 2021 18:38:46 -0600." Date: Mon, 04 Oct 2021 14:12:32 +0200 Message-ID: <2673000.1633349552@gemini.denx.de> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Dear Simon Glass, In message <20211001183842.v5.4.Ie78bfbfca0d01d9cba501e127f446ec48e1f7afe@changeid> you wrote: > In many cases environment variables need access to the U-Boot CONFIG > variables to select different options. Enable this so that the environment > scripts can be as useful as the ones currently in the board config files. > > Also support += to allow variables to be appended to. This is needed when > using the preprocessor. > > Signed-off-by: Simon Glass > --- > > (no changes since v4) > > Changes in v4: > - Add documentation in rST format instead of README > - Move use of += to this patch > - Explain that environment variables may not end in + Sorry, I disagree here. There was intentionally only very little restrictions on what a environment variable name should look like - the only exceptions were the '=' and the NUL characters. Adding artificial restrictions now just to enable your custom notation for appending seems not acceptable to me. You might want to chose a different notation or implement a proper parser instead. Thanks. Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de Never call a man a fool. Borrow from him.