public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Andre Przywara <andre.przywara@arm.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] sunxi: A64: (re-)add sun8i emac DT nodes
Date: Tue, 23 May 2017 10:32:06 +0100	[thread overview]
Message-ID: <267bd80b-68db-893e-4cca-ff30eba246bb@arm.com> (raw)
In-Reply-To: <20170522204911.GQ23727@bill-the-cat>

Hi Tom,

On 22/05/17 21:49, Tom Rini wrote:
> On Mon, May 22, 2017 at 01:59:33AM +0100, Andre Przywara wrote:
>> As the kernel DT does not have an Ethernet driver and bindings, lets
>> (re-)add the DT bindings for U-Boot's sun8i EMAC Ethernet driver, which
>> got lost when syncing the kernel DT to U-Boot.
>> This slightly updates the DT nodes to adapt to the new DT (clock and
>> reset nodes), but keeps the rest the same to let it work with the
>> existing U-Boot driver.
>>
>> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
>> ---
>>  arch/arm/dts/sun50i-a64-pine64-plus.dts | 14 +++++++++++++-
>>  arch/arm/dts/sun50i-a64-pine64.dts      |  1 +
>>  arch/arm/dts/sun50i-a64.dtsi            | 33 +++++++++++++++++++++++++++++++++
> 
> NAK, please start making use of -u-boot.dtsi files for these so they
> won't keep getting lost.

Ah, thanks for the heads up, wasn't aware of that.
I changed this patch, it looks quite neat now since this non-standard
binding is now in a separate file and the original .dts files match
exactly the Linux versions. Also it is expected that we will need to
change these nodes anyway to match the upcoming Linux Ethernet bindings.

One thing I noticed is that the binman/ node got lost with this
approach, is that because the -u-boot.dtsi scheme can only deal with one
addon file and stops looking on the first hit (skipping sunxi-u-boot.dtsi)?

Cheers,
Andre.

  reply	other threads:[~2017-05-23  9:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-22  0:59 [U-Boot] [PATCH 0/2] sunxi: update Pine64 device tree Andre Przywara
2017-05-22  0:59 ` [U-Boot] [PATCH 1/2] arm64: A64/Pine64: update device tree from Linux Andre Przywara
2017-05-22  6:52   ` Maxime Ripard
2017-05-22  0:59 ` [U-Boot] [PATCH 2/2] sunxi: A64: (re-)add sun8i emac DT nodes Andre Przywara
2017-05-22  6:52   ` Maxime Ripard
2017-05-22 20:49   ` Tom Rini
2017-05-23  9:32     ` Andre Przywara [this message]
2017-05-23 11:16       ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=267bd80b-68db-893e-4cca-ff30eba246bb@arm.com \
    --to=andre.przywara@arm.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox