From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 96677C88CB2 for ; Mon, 12 Jun 2023 18:13:51 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7143185E73; Mon, 12 Jun 2023 20:13:49 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="cVaUOU3t"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 941C885E00; Mon, 12 Jun 2023 20:13:46 +0200 (CEST) Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 41A4D85F29 for ; Mon, 12 Jun 2023 20:13:44 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jernej.skrabec@gmail.com Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-4f642a24555so5612656e87.3 for ; Mon, 12 Jun 2023 11:13:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686593623; x=1689185623; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yU/LBfeJMgyjV8NGX9/v4LhJmVdD42iTIOS8P8na1j4=; b=cVaUOU3twqJcnPq23//TWRNriotiHMkNEZgL3xVpaCbCQ7ZkeJ8GGnfKIfQT2ma+H/ UL6DWF+oVeQjitBHMDnm05030o1kAVADa/1wcQIKDZmOA8nIaB0ayfqgvuJitrNhLZrn Yk3DRYB7+2vq890kqTkh5TqHcyxhmpRPXhpERRrfiJDNtLo0/KlYLaCq3kNxhPukXKfn sDtv+ZOISEJm/e6jqioaMAq6kotlRY5IF1ygkXlabfPyU/nZcE2Xaikb0J3cpvtsRT6e lHIEsC7WYBYNkOeuW08Ir1JnZy4iEQZbZ+sAd/z3SOBG3OV1yeVy3twIHGeVu9kWaOGw O1OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686593623; x=1689185623; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yU/LBfeJMgyjV8NGX9/v4LhJmVdD42iTIOS8P8na1j4=; b=N9ep+PDXKHvqJe2wkFhLAExgCjJtig+WCR/aGb4/nN9lwfCrvY6swPporQQyA7Zaj8 hhHLPb3Xqr80egAkmL1OBfkHBFeB9F13G2GqK1/IBCeRO5SQooN/zOAe7Gntz1A8TG1X wbR6UR+4Iy7RsEwwD4lbKgOPCHpNzPtw9DssbXwYvE+yPliodz0pHhgbiSEvwspnXhw4 DtZE9km5xZFBf1sukPUCSfFomM3R5smtVrEQzr5NebDoWh1wq1ZPVPQQQ+FW3NN9iksx 9nqhOGlHOSDzFDksnukDPjyIvrdoaZNUCJQNYoxeY7ZExEVTCaxPYuHEZVds3q+pCN+s oQ7A== X-Gm-Message-State: AC+VfDyyPU9ojb2YL3X7GvxdO2WtJKBSPnjnTsqDtvTG+k9QTKyaziXT LfpjcK362tgi/8ZGtzTnhQg= X-Google-Smtp-Source: ACHHUZ7HduvmTKpekEbOqgYGaVZMyrmqjmJZvB5z30bcdtnnBg8FQEFoT2FhVdeLYkWAwBNibseBnw== X-Received: by 2002:a19:f204:0:b0:4f6:266c:22fa with SMTP id q4-20020a19f204000000b004f6266c22famr3828257lfh.49.1686593623186; Mon, 12 Jun 2023 11:13:43 -0700 (PDT) Received: from jernej-laptop.localnet (82-149-1-233.dynamic.telemach.net. [82.149.1.233]) by smtp.gmail.com with ESMTPSA id d16-20020a056402001000b0051849ba515esm881682edu.13.2023.06.12.11.13.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jun 2023 11:13:42 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Jagan Teki , Andre Przywara Cc: Marek Vasut , Samuel Holland , Icenowy Zheng , Sam Edwards , =?utf-8?B?6Lev6L6J?= , u-boot@lists.denx.de, linux-sunxi@lists.linux.dev Subject: Re: [PATCH v2 4/7] phy: sun4i-usb: Replace types with explicit quirk flags Date: Mon, 12 Jun 2023 20:13:36 +0200 Message-ID: <2683193.mvXUDI8C0e@jernej-laptop> In-Reply-To: <20230611233241.14235-5-andre.przywara@arm.com> References: <20230611233241.14235-1-andre.przywara@arm.com> <20230611233241.14235-5-andre.przywara@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Dne ponedeljek, 12. junij 2023 ob 01:32:38 CEST je Andre Przywara napisal(a): > So far we were assigning some crude "type" (SoC name, really) to each > Allwinner USB PHY model, then guarding certain quirks based on this. > This does not only look weird, but gets more or more cumbersome to > maintain. > > Remove the bogus type names altogether, instead introduce flags for each > quirk, and explicitly check for them. > This improves readability, and simplifies future extensions. > > Port of Linux patch 8dd256bae653. > > Signed-off-by: Andre Przywara Reviewed-by: Jernej Skrabec Best regards, Jernej