public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Murray.Jensen at csiro.au <Murray.Jensen@csiro.au>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] fix building of tools/env programs
Date: Thu, 23 Mar 2006 11:53:12 +1100	[thread overview]
Message-ID: <26948.1143075192@gerd> (raw)
In-Reply-To: Your message of "Mon, 13 Mar 2006 00:17:39 +0100" <20060312231739.5092C353A66@atlas.denx.de>

On Mon, 13 Mar 2006 00:17:39 +0100, Wolfgang Denk writes:
>In message <4867.1121407843@gerd> you wrote:
>> This patch shows what I had to do to get the programs in the tools/env
>> directory to build (i.e. fw_printenv/fw_setenv). Your mileage may vary.
>
>It would have been nice if you had given a better description of  the
>actual problem.

Sorry, the first problem is that make doesn't descend into the "env"
subdirectory when building (hence the addition of "env" to TOOLSUBDIRS
in "tools/Makefile"). The second problem is that the env subdirectory
is not set up for cross-compiling properly - it uses the hosts gcc
when building the dependencies, as well as different compiler flags.
The third problem was that a user level program should not include
linux kernel header files. Hence the change from <linux/mtd/mtd.h>
to <mtd/mtd-user.h>.

>> * Patch by Murray Jensen <Murray.Jensen@csiro.au>, July 15, 2005:
>>   - fix building of programs in the tools/env directory
>...
>-#include <linux/mtd/mtd.h>
>+#include <mtd/mtd-user.h>
>...
>
>This does not  work  everywhere;  for  example:  I  cannot  find  any
>"mtd/mtd-user.h" anywhere on my FC2 system.

Hmm.. I use OpenEmbedded for cross compiling. This file is installed into
the OpenEmbedded cross compiling includes area as part of the building of
the OE "mtd-utils" package (check out http://www.linux-mtd.infradead.org/).
Cheers!
								Murray...
-- 
Murray Jensen, CSIRO Manufacturing & Infra. Tech.      Phone: +61 3 9662 7763
Locked Bag No. 9, Preston, Vic, 3072, Australia.         Fax: +61 3 9662 7853
Internet: Murray.Jensen at csiro.au

To the extent permitted by law, CSIRO does not represent, warrant and/or
guarantee that the integrity of this communication has been maintained or
that the communication is free of errors, virus, interception or interference.

The information contained in this e-mail may be confidential or privileged.
Any unauthorised use or disclosure is prohibited. If you have received this
e-mail in error, please delete it immediately and notify Murray Jensen on
+61 3 9662 7763. Thank you.

  reply	other threads:[~2006-03-23  0:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-15  6:10 [U-Boot-Users] [PATCH] fix building of tools/env programs Murray.Jensen at csiro.au
2006-03-12 23:17 ` Wolfgang Denk
2006-03-23  0:53   ` Murray.Jensen at csiro.au [this message]
2006-03-23 10:46     ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=26948.1143075192@gerd \
    --to=murray.jensen@csiro.au \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox