From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heinrich Schuchardt Date: Fri, 15 Jan 2021 21:31:19 +0100 Subject: [PATCH 2/2] efi_loader: make the UEFI boot manager configurable In-Reply-To: <20210115184356.GH9782@bill-the-cat> References: <20210115180250.154660-1-xypron.glpk@gmx.de> <20210115180250.154660-3-xypron.glpk@gmx.de> <20210115184356.GH9782@bill-the-cat> Message-ID: <269776d1-0ff9-6460-bf45-68e626f2ff13@gmx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 1/15/21 7:43 PM, Tom Rini wrote: > On Fri, Jan 15, 2021 at 07:02:50PM +0100, Heinrich Schuchardt wrote: > >> Some boards are very tight on the binary size. Booting via UEFI is possible >> without using the boot manager. > > While I don't think we need to re-word this part, for the record my > concern is global, not specific platforms. To re-iterate something we > talked about on IRC, I think it's important to be able to select and > have a default UEFI implementation that covers as many common use cases > as possible, while also being as small as possible. > >> >> Provide a configuration option to make the boot manager available. >> >> Signed-off-by: Heinrich Schuchardt > [snip] >> +config CMD_BOOTEFI_BOOTMGR >> + bool "UEFI Boot Manager" >> + default y >> + help >> + Select this option if you want to select the UEFI binary to be booted >> + via UEFI variables Boot####, BootOrder, and BootNext. This enables the >> + 'bootefi bootmgr' command. > > I'm not sure this should be default y. My concern is that the default > set of options is growing so that every possible case has support in the > binary but the hardware and practical use means we don't need all of > that. This should perhaps be "default y if DISTRO_DEFAULTS" at least. If you want to default something to no, I think that EFI_UNICODE_CAPITALIZATION is a better candidate. On wandboard_defconfig: 683976 - 680228 = 3748 bytes saved. Best regards Heinrich >