From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 521F4C4321E for ; Mon, 5 Dec 2022 14:24:34 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E9AC185337; Mon, 5 Dec 2022 15:24:31 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=collabora.com header.i=@collabora.com header.b="Fb88IYaS"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 147F985337; Mon, 5 Dec 2022 15:24:30 +0100 (CET) Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id AD40C80EB6 for ; Mon, 5 Dec 2022 15:24:26 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=detlev.casanova@collabora.com Received: from falcon9.localnet (mtl.collabora.ca [66.171.169.34]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: detlev) by madras.collabora.co.uk (Postfix) with ESMTPSA id 6A9C966015ED; Mon, 5 Dec 2022 14:24:25 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1670250266; bh=OkmoPHSr+kDkocPseoL9tdsjepfZxHw/Dkxg5MjUtmo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Fb88IYaSfqZENQRaYR+17YGuLInItIajpS0yNN88E98T7F3awk6JpCd5S7lDY5sA1 KhbHUiK8Kr5HciCFyJY1WMLDvmqc8ptOpr/ohcJgFiuK919bMXVXSGjBsebA+lW3be OeKAXdp0frxrLwta1P5fUwhxrS5Yx/RC1nbwZ0gBhzdU0iCMPJ0tICLgfRgok8OPuG pzdn5XoXgAe9fVHoNZylMXOxfu+J1RVvCD2/YfVvLQ7vuV0nq6jzc9R1luNxn6/UIQ p83BtxP10k+ETm+L2pzu+oeTyo1g1fP33lE1X+v/C3Zde/bzXrFC2Zlu6pyHyC5mDr JFxaaJpXgGkJQ== From: Detlev Casanova To: Tom Rini , Fabio Estevam Cc: Troy Kisky , u-boot@lists.denx.de, Stefano Babic , "NXP i . MX U-Boot Team" Subject: Re: [PATCH] dts: Re-add aliases for imx6qdl-sabrelite devices Date: Mon, 05 Dec 2022 09:24:19 -0500 Message-ID: <2697908.mvXUDI8C0e@falcon9> In-Reply-To: References: <20221027152252.46552-1-detlev.casanova@collabora.com> <20221202233638.GM3787616@bill-the-cat> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Saturday, December 3, 2022 7:23:10 A.M. EST Fabio Estevam wrote: > On Fri, Dec 2, 2022 at 8:36 PM Tom Rini wrote: > > No, upstream has different aliases and doesn't want these. That's the > > point of the above thread, right? > > Upstream is correct in not accepting new alias for this board, as this > could break > existing setups. > > In U-Boot, we had alias for this board originally. After the sync with > Linux they are gone. > > To fix U-Boot, the less invasive change is to add the alias into > arch/arm/dts/imx6qdl-sabrelite-u-boot.dtsi. > > This way we can: > > 1. Keep the dtsi in sync with Linux > > 2. Do not break users in U-Boot > > This is the same approach I did for wandboard in the following commit: > > commit f827f84d3f5607d0b33e927f6127a888e7bd664f > Author: Fabio Estevam > Date: Fri Nov 4 08:12:54 2022 -0300 > > wandboard: Pass mmc aliases > > Originally, the mmc aliases node was present in imx6qdl-wandboard.dtsi. > > After the sync with Linux in commit d0399a46e7cd ("imx6dl/imx6qdl: > synchronise device trees with linux"), the aliases node is gone as > the upstream version does not have it. > > This causes a regression in which the SD card cannot be found anymore: > > Since commit the aliases node has been removed > U-Boot 2022.10-00999-gcca41ed3d63f-dirty (Nov 03 2022 - 22:07:38 -0300) > > CPU: Freescale i.MX6QP rev1.0 at 792 MHz > Reset cause: POR > DRAM: 2 GiB > Core: 62 devices, 17 uclasses, devicetree: separate > PMIC: PFUZE100 ID=0x10 > MMC: FSL_SDHC: 0, FSL_SDHC: 1, FSL_SDHC: 2 > Loading Environment from MMC... MMC: no card present > *** Warning - No block device, using default environment > > Fix it by passing the alias node in the u-boot.dtsi file to > restore the original behaviour where the SD card (esdhc3) was > mapped to mmc0. > > Fixes: d0399a46e7cd ("imx6dl/imx6qdl: synchronise device trees with > linux") Signed-off-by: Fabio Estevam Ha good idea to use a u-boot specific dtsi. I'll send a new patch with that then. Thanks ! Detlev.