Re: [PATCH 2/3] test_fs: Rename mount dir to scratch

[Richard Weinberger <richard@sigma-star.at>]

Mattijs,

Am Dienstag, 6. August 2024, 17:32:58 CEST schrieb Mattijs Korpershoek:
> Hi Richard,
> 
> Thank you for the patch.
> 
> On ven., août 02, 2024 at 11:33, Richard Weinberger <richard@nod.at> wrote:
> 
> > Since no mounting happens anymore, rename the "mnt"
> > directory to "scratch" and the related variables.
> >
> > Signed-off-by: Richard Weinberger <richard@nod.at>
> > ---
> >  test/py/tests/test_fs/conftest.py | 66 +++++++++++++++----------------
> >  1 file changed, 33 insertions(+), 33 deletions(-)
> >
> > diff --git a/test/py/tests/test_fs/conftest.py b/test/py/tests/test_fs/conftest.py
> > index 59342a6e3d..af2adaf164 100644
> > --- a/test/py/tests/test_fs/conftest.py
> > +++ b/test/py/tests/test_fs/conftest.py
> > @@ -178,13 +178,13 @@ def fs_obj_basic(request, u_boot_config):
> >      fs_ubtype = fstype_to_ubname(fs_type)
> >      check_ubconfig(u_boot_config, fs_ubtype)
> >  
> > -    mount_dir = u_boot_config.persistent_data_dir + '/mnt'
> > +    scratch_dir = u_boot_config.persistent_data_dir + '/scratch'
> >  
> > -    small_file = mount_dir + '/' + SMALL_FILE
> > -    big_file = mount_dir + '/' + BIG_FILE
> > +    small_file = scratch_dir + '/' + SMALL_FILE
> > +    big_file = scratch_dir + '/' + BIG_FILE
> >  
> >      try:
> > -        check_call('mkdir -p %s' % mount_dir, shell=True)
> > +        check_call('mkdir -p %s' % scratch_dir, shell=True)
> >      except CalledProcessError as err:
> >          pytest.skip('Preparing mount folder failed for filesystem: ' + fs_type + '. {}'.format(err))
> 
> Should we update the error message here as well?

Sure, thanks for pointing out!
I'll send a v2.

Thanks,
//richard

-- 
​​​​​sigma star gmbh | Eduard-Bodem-Gasse 6, 6020 Innsbruck, AUT
UID/VAT Nr: ATU 66964118 | FN: 374287y