From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
To: u-boot@lists.denx.de
Subject: [PATCH] optee: Replace uninitialized return variable by proper one.
Date: Mon, 27 Jan 2020 08:05:03 +0100 [thread overview]
Message-ID: <2734808.JsCWAeK1EH@phil> (raw)
In-Reply-To: <20200126222054.388621-1-christoph.muellner@theobroma-systems.com>
Am Sonntag, 26. Januar 2020, 23:20:54 CET schrieb Christoph Müllner:
> As hinted by GCC 9, there is a return statement that returns
> an uninitialized variable in optee_copy_firmware_node().
> This patch addresses this.
>
> Signed-off-by: Christoph Müllner <christoph.muellner@theobroma-systems.com>
Thanks for catching this mistake of mine
Reviewed-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
>
> ---
>
> lib/optee/optee.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/optee/optee.c b/lib/optee/optee.c
> index 9b49eb8ee7..d4355c6d03 100644
> --- a/lib/optee/optee.c
> +++ b/lib/optee/optee.c
> @@ -92,7 +92,7 @@ static int optee_copy_firmware_node(const void *old_blob, void *fdt_blob)
>
> offs = fdt_add_subnode(fdt_blob, offs, "optee");
> if (offs < 0)
> - return ret;
> + return offs;
>
> /* copy the compatible property */
> prop = fdt_getprop(old_blob, old_offs, "compatible", &len);
>
next prev parent reply other threads:[~2020-01-27 7:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-26 22:20 [PATCH] optee: Replace uninitialized return variable by proper one Christoph Müllner
2020-01-27 7:05 ` Heiko Stuebner [this message]
2020-01-31 1:41 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2734808.JsCWAeK1EH@phil \
--to=heiko.stuebner@theobroma-systems.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox