From mboxrd@z Thu Jan  1 00:00:00 1970
From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
Date: Mon, 27 Jan 2020 08:05:03 +0100
Subject: [PATCH] optee: Replace uninitialized return variable by proper
 one.
In-Reply-To: <20200126222054.388621-1-christoph.muellner@theobroma-systems.com>
References: <20200126222054.388621-1-christoph.muellner@theobroma-systems.com>
Message-ID: <2734808.JsCWAeK1EH@phil>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
To: u-boot@lists.denx.de

Am Sonntag, 26. Januar 2020, 23:20:54 CET schrieb Christoph Müllner:
> As hinted by GCC 9, there is a return statement that returns
> an uninitialized variable in optee_copy_firmware_node().
> This patch addresses this.
> 
> Signed-off-by: Christoph Müllner <christoph.muellner@theobroma-systems.com>

Thanks for catching this mistake of mine
Reviewed-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>


> 
> ---
> 
>  lib/optee/optee.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/optee/optee.c b/lib/optee/optee.c
> index 9b49eb8ee7..d4355c6d03 100644
> --- a/lib/optee/optee.c
> +++ b/lib/optee/optee.c
> @@ -92,7 +92,7 @@ static int optee_copy_firmware_node(const void *old_blob, void *fdt_blob)
>  
>  	offs = fdt_add_subnode(fdt_blob, offs, "optee");
>  	if (offs < 0)
> -		return ret;
> +		return offs;
>  
>  	/* copy the compatible property */
>  	prop = fdt_getprop(old_blob, old_offs, "compatible", &len);
>