From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1201C433EF for ; Tue, 5 Oct 2021 14:56:07 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 32E2A61371 for ; Tue, 5 Oct 2021 14:56:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 32E2A61371 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 58E8C81E14; Tue, 5 Oct 2021 16:56:04 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1633445764; bh=+KlFza0ByWSotMOXaVrCZDqsKbrA4nhxO9ne2mM1BsU=; h=To:cc:From:Subject:In-reply-to:References:Date:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=BOCxwpSFrkDhQ8r7VpKVKwW8eXqBMclR32QJ5xmAJUrim7rVPouUEugizr3MQCegQ clb3TrhR4XhxuXWA8ZZGKL19l6xgAc9lyjigC2wGbl7cPghPSZ1+1GsTmRnHhev4I7 xH9fMKjxB3u7QC/XgFfxKRDZfPYLXe4At93gjZPYxvtrlx12pPxrLUavqbsI7KKF9P ygsrP3FwpHTQcJIQETZyd5tNOyI7yDk+vv6YqOgD8hOLoie8fYtcQfy65J/Thskdi+ 5vLl4AkQblRHoA0i5i/GGj6QvVpMWj+KY/stZERSdwN+BHJLzw3oS7dbuoqg2m2ex6 bgmcNl7a/7Ofg== Received: from janitor.denx.de (unknown [62.91.23.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: noc@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id DD00981197 for ; Tue, 5 Oct 2021 16:56:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1633445761; bh=+KlFza0ByWSotMOXaVrCZDqsKbrA4nhxO9ne2mM1BsU=; h=To:cc:From:Subject:In-reply-to:References:Date:From; b=TWZBv7xlctqUCY5TWz/KQlGELCurC6qH/LESE83kAPxcZa6cDfheDxnd9mfjHJkXz yTlZDkSejeRzf3pXk4WiflaI4f5j+WaGze5Q6bSnGilZ5wBed4kwRtOgAdJ93D+85c XIIIV4W+Xqisa24veZ3jTn1YpnbUOxgBF+3/uricvs1Y2E7or7UJKobrmW4XBnN6TM KumwyKcpqApuf++IzzZ/9TdzdALNKASHThhwSnr2ZbjTxQ8CPAYUjbYXxZJ2sVFWDt SQwK0mup4oLSz9r77vURT2P7W/u1Wnp3vSbK4Nl+luRKtFlNUpazQv+JwRvljztziz VOCaQSIzuEFxA== Received: by janitor.denx.de (Postfix, from userid 108) id 5A7D7A0099; Tue, 5 Oct 2021 16:56:01 +0200 (CEST) Received: from gemini.denx.de (gemini.denx.de [10.4.0.2]) by janitor.denx.de (Postfix) with ESMTPS id 67F04A024D; Tue, 5 Oct 2021 16:55:55 +0200 (CEST) Received: from gemini.denx.de (localhost [IPv6:::1]) by gemini.denx.de (Postfix) with ESMTP id 574721E0F1B; Tue, 5 Oct 2021 16:55:55 +0200 (CEST) To: Simon Glass cc: U-Boot Mailing List , Tom Rini , Joe Hershberger From: Wolfgang Denk Subject: Re: [PATCH v5 3/5] env: Allow U-Boot scripts to be placed in a .env file MIME-Version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8bit In-reply-to: References: <20211002003848.1803446-1-sjg@chromium.org> <20211001183842.v5.3.If789ba3e2667c46c03eda3386ca84a863baeda55@changeid> <2672911.1633349282@gemini.denx.de> Comments: In-reply-to Simon Glass message dated "Tue, 05 Oct 2021 08:42:03 -0600." Date: Tue, 05 Oct 2021 16:55:55 +0200 Message-ID: <2738693.1633445755@gemini.denx.de> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Dear Simon, In message you wrote: > > > > Add a feature that brings in a .env file associated with the board > > > config, if present. To use it, create a file in a board//env > > > directory called .env (or common.env if you want the same > > > environment for all boards). > > > > This should be no exclusive "or" here. If a common.env exists, it > > should be used for all boards, and if additionally one ore more > > .env files exist, these should ALSO be applied to the > > respective boards. > > Is it not enough to use #include in the main file? We have a similar > feature with the u-boot.dtsi files and in that case we only choose the > most specific. 1) This requires that the .env files are run through CPP, which is only added in a later patch. 2) Even if I add an "#include board//env/common.env" in my .env files, your logic would trigger on the existence of the common.env file and ignore the .env files. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de Work 8 hours, sleep 8 hours; but not the same 8 hours.