Re: [PATCH v5 3/5] env: Allow U-Boot scripts to be placed in a .env file

Simon Glass
2021-10-05T14:42:26Z

Hi Wolfgang,

On Mon, 4 Oct 2021 at 06:08, Wolfgang Denk <wd@denx.de> wrote:
>
> Dear Simon,
>
> In message <20211001183842.v5.3.If789ba3e2667c46c03eda3386ca84a863baeda55@changeid> you wrote:
> >
> > Add a feature that brings in a .env file associated with the board
> > config, if present. To use it, create a file in a board/<vendor>/env
> > directory called <board>.env (or common.env if you want the same
> > environment for all boards).
>
> This should be no exclusive "or" here. If a common.env exists, it
> should be used for all boards, and if additionally one ore more
> <board>.env files exist, these should ALSO be applied to the
> respective boards.

Is it not enough to use #include in the main file? We have a similar
feature with the u-boot.dtsi files and in that case we only choose the
most specific.

Regards,
Simon