public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Johan Jonker <jbx6244@gmail.com>
To: dario.binacchi@amarulasolutions.com,
	michael@amarulasolutions.com, sjg@chromium.org
Cc: philipp.tomsich@vrull.eu, kever.yang@rock-chips.com,
	u-boot@lists.denx.de, yifeng.zhao@rock-chips.com
Subject: [PATCH v1] mtd: nand: raw: rockchip_nfc: fix oobfree offset and description
Date: Mon, 13 Feb 2023 15:18:55 +0100	[thread overview]
Message-ID: <27ead98a-e235-0240-f0d7-4d333d130598@gmail.com> (raw)
In-Reply-To: <241e9e7b-58d6-dfa5-fcb5-5660e6402021@gmail.com>

The MTD framework reserves 1 or 2 bytes for the bad block marker
depending on the bus size. The rockchip_nfc driver currently only
supports a 8 bit bus, but reserves standard 2 bytes for the BBM.
The first free OOB byte is therefore OOB2 at offset 2.
Page address(PA) bytes are moved to the last 4 positions before
ECC. Update the description for U-boot.

Signed-off-by: Johan Jonker <jbx6244@gmail.com>
---

Note:
  Merge after serie:
    [PATCH v2 00/10] Fixes for Rockchip NFC driver part 1
---
 drivers/mtd/nand/raw/rockchip_nfc.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/mtd/nand/raw/rockchip_nfc.c b/drivers/mtd/nand/raw/rockchip_nfc.c
index 9e3a2533..bcab219b 100644
--- a/drivers/mtd/nand/raw/rockchip_nfc.c
+++ b/drivers/mtd/nand/raw/rockchip_nfc.c
@@ -487,10 +487,10 @@ static int rk_nfc_write_page_raw(struct mtd_info *mtd,
 		 *
 		 *    BBM  OOB1 OOB2 OOB3 |......|  PA0  PA1  PA2  PA3
 		 *
-		 * The rk_nfc_ooblayout_free() function already has reserved
-		 * these 4 bytes with:
+		 * The oobfree structure already has reserved these 4 bytes
+		 * together with 2 bytes for BBM by reducing it's length:
 		 *
-		 * oob_region->offset = NFC_SYS_DATA_SIZE + 2;
+		 * oobfree[0].length = rknand->metadata_size - NFC_SYS_DATA_SIZE - 2;
 		 */
 		if (!i)
 			memcpy(rk_nfc_oob_ptr(chip, i),
@@ -867,7 +867,7 @@ static int rk_nfc_ecc_init(struct rk_nfc *nfc, struct nand_chip *chip)
 		ecc->layout->eccpos[i] = rknand->metadata_size + i;

 	ecc->layout->oobfree[0].length = rknand->metadata_size - NFC_SYS_DATA_SIZE - 2;
-	ecc->layout->oobfree[0].offset = NFC_SYS_DATA_SIZE + 2;
+	ecc->layout->oobfree[0].offset = 2;

 	return 0;
 }
--
2.20.1


      parent reply	other threads:[~2023-02-13 14:19 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-07 14:49 [PATCH v2 00/10] Fixes for Rockchip NFC driver part 1 Johan Jonker
2023-02-07 14:51 ` [PATCH v2 01/10] include: fdtdec: decouple fdt_addr_t and phys_addr_t size Johan Jonker
2023-02-16  7:41   ` Kever Yang
2023-02-07 14:52 ` [PATCH v2 02/10] include: dm: ofnode: fix headers Johan Jonker
2023-02-16  7:41   ` Kever Yang
2023-02-07 14:52 ` [PATCH v2 03/10] core: remap: convert regmap_init_mem_plat() input to phys_addr_t Johan Jonker
2023-02-16  7:41   ` Kever Yang
2023-02-07 14:53 ` [PATCH v2 04/10] rockchip: adc: rockchip-saradc: convert dev_read_addr output " Johan Jonker
2023-02-16  7:42   ` Kever Yang
2023-02-07 14:53 ` [PATCH v2 05/10] rockchip: timer: dw-apb-timer: " Johan Jonker
2023-02-16  7:42   ` Kever Yang
2023-02-07 14:54 ` [PATCH v2 06/10] rockchip: mtd: raw: rockchip_nfc " Johan Jonker
2023-02-16  7:34   ` Michael Nazzareno Trimarchi
2023-02-16  7:43   ` Kever Yang
2023-02-07 14:54 ` [PATCH v2 07/10] mtd: nand: raw: rockchip_nfc: remove the compatible string "rockchip,rk3308-nfc" Johan Jonker
2023-02-16  7:29   ` Michael Nazzareno Trimarchi
2023-02-16  7:42   ` Kever Yang
2023-02-07 14:54 ` [PATCH v2 08/10] mtd: nand: raw: rockchip_nfc: add layout structure Johan Jonker
2023-02-16  7:26   ` Michael Nazzareno Trimarchi
2023-02-16  7:43   ` Kever Yang
2023-02-07 14:55 ` [PATCH v2 09/10] mtd: nand: raw: rockchip_nfc: add flash_node to chip stucture Johan Jonker
2023-02-16  7:24   ` Michael Nazzareno Trimarchi
2023-02-16  7:43   ` Kever Yang
2023-02-07 14:56 ` [PATCH v2 10/10] mtd: nand: add support for the Sandisk SDTNQGAMA chip Johan Jonker
2023-02-16  7:43   ` Kever Yang
2023-02-13 14:18 ` Johan Jonker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=27ead98a-e235-0240-f0d7-4d333d130598@gmail.com \
    --to=jbx6244@gmail.com \
    --cc=dario.binacchi@amarulasolutions.com \
    --cc=kever.yang@rock-chips.com \
    --cc=michael@amarulasolutions.com \
    --cc=philipp.tomsich@vrull.eu \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    --cc=yifeng.zhao@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox