public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marc Dietrich <marvin24@gmx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] tegra: enable LCD on PAZ00
Date: Mon, 26 Nov 2012 22:00:40 +0100	[thread overview]
Message-ID: <2834734.m3KoVBJ9e8@ax5200p> (raw)
In-Reply-To: <50B3BC63.2050900@wwwdotorg.org>

On Monday 26 November 2012 12:00:51 Stephen Warren wrote:
> On 11/25/2012 02:26 PM, Marc Dietrich wrote:
> > This adds LCD panel descriptions to the device tree of PAZ00 and
> > enables LCD support in the configuration.
> > 
> > diff --git a/include/configs/paz00.h b/include/configs/paz00.h
> > 
> > +#define CONFIG_BOARD_LATE_INIT
> 
> What's that for? I don't think any of the other Tegra boards have it.

No, all board defining CONFIG_LCD have this (seaboard, avionics). You may ask 
Simon why it is required. Without it, backlight will not come up on PAZ00 at 
least.

> >  /* SD/MMC */
> >  #define CONFIG_MMC
> > 
> > @@ -71,6 +72,20 @@
> > 
> >  #define CONFIG_CMD_NET
> >  #define CONFIG_CMD_DHCP
> > 
> > +#undef TEGRA_DEVICE_SETTINGS
> > +#define TEGRA_DEVICE_SETTINGS	\
> > +	"stdin=serial\0"	\
> > +	"stdout=serial,lcd\0"	\
> > +	"stderr=serial,lcd\0"
> 
> Why not extend tegra-common-post.h's automatic calculation of
> TEGRA_DEVICE_SETTINGS to support the lcd case too? Allen Martin's recent
> change "tegra: move TEGRA_DEVICE_SETTINGS to tegra-common-post.h" should
> make it easy to do that.

Yes, I have such a patch in my gitorious tree for some time now. Allen's patch 
is not in any u-boot-tegra branch yet. I can fix it up when it has landed.

Marc

  reply	other threads:[~2012-11-26 21:00 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-25 21:26 [U-Boot] [PATCH 1/2] tegra: display: add board pinmux Marc Dietrich
2012-11-25 21:26 ` [U-Boot] [PATCH 2/2] tegra: enable LCD on PAZ00 Marc Dietrich
2012-11-26 19:00   ` Stephen Warren
2012-11-26 21:00     ` Marc Dietrich [this message]
2012-11-27  0:07       ` Tom Warren
2012-11-27 17:42         ` Stephen Warren
2012-11-27 19:53           ` Stephen Warren
2012-11-27 21:59             ` Marek Vasut
2012-11-26 16:55 ` [U-Boot] [PATCH 1/2] tegra: display: add board pinmux Tom Warren
2012-11-26 20:51   ` Marc Dietrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2834734.m3KoVBJ9e8@ax5200p \
    --to=marvin24@gmx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox