From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BCE10C4332F for ; Fri, 16 Dec 2022 06:30:04 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 159298530B; Fri, 16 Dec 2022 07:30:01 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1671172201; bh=ig2TYnpu1MgFAyI1NAoeffYVnn8WMSYvlWc+RAZfRFs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=QbJFwhT3WV88lNQqQAKHxO//DXZDlEw2DN6lBDV06IAjWfDXnHOl1bJw/uXQi4ttg qQAYTALeP04KqSfUbpRdXAZ6bj8d2+8PN1bf9lR5wLv6DGM4aolsg9SZSCZCWkEcTU RofiPa9kbBQC8We0M5XfhsAHWD6p3Z63ZaROGHOna9RUGqCnCM2yfOmi+MbDWf8UsM UA7lwqDk8ZNcoq6T1eHXiONUbeDgkGNzxZSB7G+OH9WKWDAJwVs83tT4Hxnp5/EJIE ORTDxFIxkGF/uCEknTWrThhRuDKfjfgQ70r949qZ+aUR3onNgiZEKawKR1TPH4dL4I 89qVBktoj0MRA== Received: by phobos.denx.de (Postfix, from userid 109) id A5C8F8532C; Fri, 16 Dec 2022 07:29:59 +0100 (CET) Received: from mout-u-107.mailbox.org (mout-u-107.mailbox.org [80.241.59.207]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2D8D5852FE for ; Fri, 16 Dec 2022 07:29:57 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sr@denx.de Received: from smtp102.mailbox.org (smtp102.mailbox.org [10.196.197.102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-u-107.mailbox.org (Postfix) with ESMTPS id 4NYK2m5g42z9sSX; Fri, 16 Dec 2022 07:29:52 +0100 (CET) Message-ID: <28c1f199-2a04-48c2-da06-b83c9b2fb2cb@denx.de> Date: Fri, 16 Dec 2022 07:29:47 +0100 MIME-Version: 1.0 Subject: Re: Converting to DM SERIAL for Kirkwood boards Content-Language: en-US To: Tony Dinh , Michael Walle Cc: pali@kernel.org, sjg@chromium.org, u-boot@lists.denx.de References: <20221212090325.94737-1-michael@walle.cc> From: Stefan Roese In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Tony, On 12/16/22 03:42, Tony Dinh wrote: > Hi all, > > On Mon, Dec 12, 2022 at 5:18 PM Tony Dinh wrote: >> >> Hi Michael, >> >> On Mon, Dec 12, 2022 at 1:03 AM Michael Walle wrote: >>> >>>>> On 12/9/22 04:55, Tony Dinh wrote: >>>>>> Hi Simon et al, >>>>>> >>>>>> (Resend to include u-boot mailing list) >>>>>> >>>>>> I'm in the process of converting Kirkwood boards to use DM SERIAL. I >>>>>> could not seem to get it to work, having tried adding >>>>>> CONFIG_DM_SERIAL, and also playing with various related CONFIG >>>>>> options (CONFIG_SPECIFY_CONSOLE_INDEX and CONFIG_CONS_INDEX ). From >>>>>> my reading various board configurations that were already converted to >>>>>> DM_SERIAL, I'm under the impression that just turning on >>>>>> CONFIG_DM_SERIAL would work without any other addition. >>>>>> >>>>>> The board I'm testing is Zyxel NSA310S Kirkwood 6702 (6192) SoC. >>>>>> >>>>>> diff --git a/configs/nsa310s_defconfig b/configs/nsa310s_defconfig >>>>>> index afa0cad041..e81d1495bd 100644 >>>>>> --- a/configs/nsa310s_defconfig >>>>>> +++ b/configs/nsa310s_defconfig >>>>>> @@ -41,7 +41,6 @@ CONFIG_ENV_OVERWRITE=y >>>>>> CONFIG_ENV_IS_IN_NAND=y >>>>>> CONFIG_SYS_RELOC_GD_ENV_ADDR=y >>>>>> CONFIG_NET_RANDOM_ETHADDR=y >>>>>> -CONFIG_NETCONSOLE=y >>>>>> CONFIG_SYS_FAULT_ECHO_LINK_DOWN=y >>>>>> CONFIG_SATA_MV=y >>>>>> CONFIG_SYS_SATA_MAX_DEVICE=1 >>>>>> @@ -53,6 +52,7 @@ CONFIG_MTD_RAW_NAND=y >>>>>> CONFIG_PHY_MARVELL=y >>>>>> CONFIG_MVGBE=y >>>>>> CONFIG_MII=y >>>>>> +CONFIG_DM_SERIAL=y >>>>>> CONFIG_SYS_NS16550=y >>>>>> CONFIG_USB=y >>>>>> CONFIG_USB_EHCI_HCD=y >>>>>> >>>>>> I also added kirkwood-nsa310s-u-boot.dtsi to help in running kwboot. >>>>>> >>>>>> &uart0 { >>>>>> u-boot,dm-pre-reloc; >>>>>> }; >>>>>> >>>>>> I've tried kwboot the new u-boot image, and also flashed this image to >>>>>> NAND, and in both cases, I got a silent serial console. It seems to >>>>>> hang up right off the bat. Hope you can help by giving me some >>>>>> pointers on how to debug this. >>>>> >>>>> Might be that the alias is missing and / or that the uart DT node is >>>>> not enabled. Please give this test-only patch a try: >>>>> >>>>> diff --git a/arch/arm/dts/kirkwood-nsa310s.dts >>>>> b/arch/arm/dts/kirkwood-nsa310s.dts >>>>> index 09ee76c2a2e0..ca7a49af9ba4 100644 >>>>> --- a/arch/arm/dts/kirkwood-nsa310s.dts >>>>> +++ b/arch/arm/dts/kirkwood-nsa310s.dts >>>>> @@ -17,6 +17,10 @@ >>>>> model = "Zyxel NSA310S"; >>>>> compatible = "zyxel,nsa320s", "marvell,kirkwood-88f6702", >>>>> "marvell,kirkwood"; >>>>> >>>>> + aliases { >>>>> + serial0 = &uart0; >>>>> + }; >>>>> + >>>>> memory { >>>>> device_type = "memory"; >>>>> reg = <0x00000000 0x10000000>; >>>>> @@ -317,3 +321,8 @@ >>>>> &pcie0 { >>>>> status = "okay"; >>>>> }; >>>>> + >>>>> +&uart0 { >>>>> + status = "okay"; >>>>> + u-boot,dm-pre-reloc; >>>>> +}; >>>> >>>> Thanks for the patch! but the behavior is still the same (silent >>>> serial console and hung the board). >>>> >>>> Thanks, >>>> Tony >>> >>> Maybe this will help: >>> https://lore.kernel.org/u-boot/20220817193809.1059688-20-michael@walle.cc/ >>> >>> The lsxl is also a kirkwood based board. >>> >> >> Thanks! indeed that was the malloc problem. This NSA310S board is now >> working with DM_SERIAL. >> >> I will test a few more Kirkwood boards and keep everybody posted. > > Closing the loop on this DM_SERIAL conversion for Kirkwood. > > I've tested DM_SERIAL with Michael's malloc patches on a few other > Kirkwood boards. They're all working fine with u-boot-2023.01-rc3. Good to know. I assume that you will post some patches for these Kirkwood board soon? Or even better, making the necessary changes for Kirkwood in general in Kconfig (if possible). Thanks, Stefan > NSA310s > Dreamplug > Sheevaplug > GFHome > Dockstar > iConnect > Pogo E02 > Pogo V4 (tested with u-boot-2022.10, since Pogo V4 itself was broken > in u-boot-2023.01-rc3 for unknown reason). > > All the best, > Tony Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de