From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A1C2EC77B7C for ; Sat, 13 May 2023 08:39:40 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 12A7B84710; Sat, 13 May 2023 10:39:38 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=solid-run.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=solidrn.onmicrosoft.com header.i=@solidrn.onmicrosoft.com header.b="SCJq+MIb"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3008F847BC; Sat, 13 May 2023 10:39:36 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on0608.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe0c::608]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 10B4784710 for ; Sat, 13 May 2023 10:39:34 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=solid-run.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=josua@solid-run.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QrsO5CgiqYZraoFmCi0FCY9yB9FwZwVB+RaSVBULN22rlUefTKQXrW36WnTt0ae9ZG/0vkKxMjWDlFL+E+U54vFVkN6W0Cmg8flV4gk7ugV7xbUQyL/PyFYseIa0m+3eQNlfWIeJV3XmRUIwoervUPl1KVLI2TWL70+QhxNpSgUUErMWScj9V7bBftWRH3DzLJkSk16s2c57I7g37sFANEp1ZEa8apsSK6bEdZJiftV143v4ifsOYbDVbs2PnSpAIrygg8lbzEjAuQ0eH7dzQlJrzEYzajql+iLh3GqTieWRNEiPERBtp8GSJv/pGSe5zowa/75wl2A4TBwhaVjFNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Wxrm5GXxUuSOXXlqXKXrzsS0qZtr3y7bgO86L/NTbkc=; b=MhNhmFtY8qrykxiMN8HhGfr7J0XMLyRvbLItmJVexFrO+70OXnghqCNYccvfgDADLIA5ZNaBDMAcwd7oPKffUKXaozQi6r1DLtIsC4/xrz3yV6m/QGD5qMKMqDNjovGXckEAfyYKwqXmbFWnc+HKakD2xjI++qbOyMaMT4QP/Yv8ZA4jUjMXNXKkuaIVQjoa9BGJj/iArqwJp0BC9sY/v1g5sjIqSNqk1Cl3XHZNIJJhvL6JyJ2l3h4cOxogjNwKIlO4Wng0th9UcZD9MVp1vIYU2adQbI8VqWBUWb8rQVwXj6Eh6V5NQp2Q9TlOM+1ZcxMNp69UaEbHOCQ4OQf1SQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=solid-run.com; dmarc=pass action=none header.from=solid-run.com; dkim=pass header.d=solid-run.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=solidrn.onmicrosoft.com; s=selector1-solidrn-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Wxrm5GXxUuSOXXlqXKXrzsS0qZtr3y7bgO86L/NTbkc=; b=SCJq+MIb48ReWKkpDh19lbNX8pwCDJVGOe1DWgYenuwMT3NuXGCq7Ul1UqxX3n1iOJEC1F4ArcZ7UvFKP4V6AJN/wG47Ywoaey8+ccMYZuEpNK9BwLejGFhGFeqR0nUeuO8ugFDQ4b8HKXzHGH9VQEtp8cvXPdjjA2viG6A7vAc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=solid-run.com; Received: from AS8PR04MB8963.eurprd04.prod.outlook.com (2603:10a6:20b:42e::18) by AS8PR04MB8705.eurprd04.prod.outlook.com (2603:10a6:20b:428::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.27; Sat, 13 May 2023 08:39:32 +0000 Received: from AS8PR04MB8963.eurprd04.prod.outlook.com ([fe80::9e27:8c41:a8d:938e]) by AS8PR04MB8963.eurprd04.prod.outlook.com ([fe80::9e27:8c41:a8d:938e%6]) with mapi id 15.20.6387.028; Sat, 13 May 2023 08:39:32 +0000 Message-ID: <2947525b-d5a4-fea8-fdc8-5ee701bd45f6@solid-run.com> Date: Sat, 13 May 2023 11:39:29 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [[PATCH v2] 4/4] cmd: tlv_eeprom: enable 'dev' subcommand before 'read' To: Simon Glass Cc: u-boot@lists.denx.de, Stefan Roese , Baruch Siach , Heinrich Schuchardt References: <20230505082049.9768-1-josua@solid-run.com> <20230505082049.9768-5-josua@solid-run.com> Content-Language: en-US From: Josua Mayer In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: ZR0P278CA0102.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:23::17) To AS8PR04MB8963.eurprd04.prod.outlook.com (2603:10a6:20b:42e::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8963:EE_|AS8PR04MB8705:EE_ X-MS-Office365-Filtering-Correlation-Id: fbd8ba2c-d2ee-40f6-b32b-08db538d928e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3bq+uLqjgYIb2gTo4PyqoQvbYQUpSwIiKE0MuzWgB4ml+uE4ifZHJ2onVdzhnom/KheT/IA5keJ577to/WEZWwHxXHgQnkVM5oe3BJWurLtxuuLWXXo3xJ20Nr7B73zDfzygCpXjWYfX4msDrlprCa9gyBjSy33Zw2vyplOSDBKgZxfxhoxguWK1PrwreK7XxR7A5RFVXwBkULH7rLElq3Lq49STOeOgmZeyHC9X/BzzOsGqmkr71+ye0Y5Jaz02vJLCM9PtlPw9npPS2X0vNLBOJ/PWOWKa7hXvzULjHRr1qMs5UogAkAGaLWx0FU+9zB/wBctuTxUCAN+80U4Io1M5blWpM94yhc+GQeDL74hcGOXvhI8f7ZFu/PhHZqh+y8Zo0EcizTdprU/YBAz/SOM4fkP07Z3oA/QLB6+SfWWucMXzXAVe4cI573PpMJxlR+LpEwiW1LuX2SKnSWrqoVRWSQhsjl3W0c0fwvrtEmi4xtJiYwMO8eYizH/d2drXAZeaNTHlhs/VFVtaqWCth1bhCziNBBIyrnfCAtcuqyoPp0Ly+22m+hCLmXIFMfp4FbgdQgEKbNYiZL5qv6vDnD4Z8rgy5MyvY1WkfbxP2sjbUJXem50ga96ND1V4duk2CbOmn0Nz+JmOXHtws+Q9wg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR04MB8963.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(376002)(39830400003)(136003)(396003)(366004)(346002)(451199021)(38100700002)(31696002)(83380400001)(2616005)(186003)(26005)(36756003)(6486002)(6666004)(54906003)(478600001)(6512007)(6506007)(316002)(4326008)(6916009)(66946007)(66556008)(66476007)(31686004)(66899021)(86362001)(41300700001)(5660300002)(8936002)(2906002)(8676002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Tmc2NzhjUXEveDRXa2s1OHJBa1NLaG5lTHpGR2EveXJBK01KVWxRZG1jeUlz?= =?utf-8?B?ZGZUQWVRRG9FeGpnZXNKa1dZeEY3elFPN2VrM3hwcUhwZGkyY1dnYkNVWkI5?= =?utf-8?B?cmFNSnZIeUZSZEFDOXlMUGsyNVoxSWpkNGRXOTQrMVR3a3VxejdwWEo5UElx?= =?utf-8?B?cHM3aWJvVDNCMENXVjBkbGJ2MSs3cHloYUQ4ME5rN1ozZ3kyS2liY3FrTmxy?= =?utf-8?B?L2hiQ1VWbG5Kd0JJV1owWU9uNmxjcWtGaTNwbWVTSUJLbnptbHgvWWE1SXNI?= =?utf-8?B?WUlDSldnOVZ3RjY4S2V2WXBUazc0UW9remxXM2s4Zm1WZThYMmpaWTNLbjBQ?= =?utf-8?B?a3Y2OUU3MGhRSzZYdUZLRE9BYTBxZUp5UWJTRzV6OUpnUG1rY1ZKenFGVFhW?= =?utf-8?B?VXVyNnZreGpDR29lelVQdUZLK3ltSHZJQjhLeXZ2RnpGYjhWQ2xrY1dOdDFN?= =?utf-8?B?M0o2cUloOE1hTVdCazlnQjBKVmJUaEhFQlZnTVRldjA5Nnd4OUh0ZFVEd0pQ?= =?utf-8?B?Ui8zZm16eDRCVE5hTVhYSm4vaVV0b0tFU2tVR3VBOTcwYzNNZTllQkkzaktP?= =?utf-8?B?RVZBQmEwSUxKTGtqZXdGcWpXaXYrRmFleUF3OFhvYUduUllZcVdaZExFSk5P?= =?utf-8?B?RUlpVUtGQ0lGNWhLb3lYOW9OVC81ajJ5RkJzQ2JSb2ExRWwxZERHUkpXanpO?= =?utf-8?B?MXUzSzEvczN3SnpmWVZ1b1FZblQzMjRWYmVaamMwR2NlMytJMVRISVArRWpW?= =?utf-8?B?bU1ja0RseDZ2YzltM3o3clNCUTM3K0pzQk02L2xyWkZWVEhrS1JCUzlWZTRL?= =?utf-8?B?d2htMzVOdkxzQnZkUWJJZFNYWm5OQ2swOERnWmQ4NWViV3lObmljUFNHOHpL?= =?utf-8?B?aHhHWVZYckdRcDRYSjJER0dvUEM5NlVhVTBmMi8rZ2R1Zmh6YWtoYVh6amtD?= =?utf-8?B?ZGsvaTV6MnpjQW1rOHVDK2E4ajZsN01tUy9YTFM3VmVEWVh1YjVqRHk1YlRx?= =?utf-8?B?eXVGOG1FWDJQSGM1OE5nbDFDTUxTNVNxSVlCK2t5UzgxRHJwSzdPRUFOQ2tL?= =?utf-8?B?M3FqOUdCNmxkenZ4K2tCQmNhNHoxM3NFeG1TSW9ZRXl4NHJDa3dlSXdZT1Fy?= =?utf-8?B?UU95Ymg3T1U5cFJQa3JIZDZ4NUxvK2M2TDFKZTh1TXJqYkw2Q0ZINXZrOVdw?= =?utf-8?B?UDlLWXpGY1hQUXNSb0R2eEUzdDZFVGNvUUtLWFhSc3lxNlRwZmIwd3JmT2E5?= =?utf-8?B?OEk1dGdoYlVwZ3FhRUhLYncvRTFROW9vT2ZjcmhHTG94QmRXQnI4WFBpU3p5?= =?utf-8?B?NktIY1pYVEprUWNZbDU5ZldNMTh6c2hrYXlWYk9wRVEzdy9ZeEJGQ1U2Mkp4?= =?utf-8?B?Y1Axa0Y4d1lHMlBqWGpCRFZMZTIydWtibUJTQW5hVXdmOUZPcFE0SWtlaTNh?= =?utf-8?B?RE5icHhLTTZlN1lPNDJmV05KNDA4T0JQNkJrTjhxTEhlZzhzVEpiNXZMTjhL?= =?utf-8?B?anJ4VHBjdHhuTHM4S0RtY1NvcS9LcWFuR1d5RWNWeVFicnVWaUM2TnVPUXVS?= =?utf-8?B?ckplTnVUUnRIUitrZ2pBMlk1clllcElpbSs0U1dGVGpEbVFVWllSdXNtNTJl?= =?utf-8?B?OXJ2VFdOZVh3bWNNcWU0NTRxdnRoS1lXQTNvekpIa2llRU1DdFVqbENSWXpa?= =?utf-8?B?RVlkL3Z5eDZGMDcyOXpuTFU4MUtNL1NPYzRHekJTaENtWXM1TXpjV081Ykxr?= =?utf-8?B?aHZPUWdXbElMR1ZIdWlhMDNPSHRMNlRzbUl6bms5TnM2S2sxZmRweTJmNW91?= =?utf-8?B?enIzL09lVHlVZ01TcVVISVRLdkpzb01JOVZNSUFMY1V4TDE4djd3NjV5ajRQ?= =?utf-8?B?Kzl6dGM2dWc0eUs0K0lMeFZ3SWpzUWhVQm93czRZQ0g3ZGpxRzhrUndDTFBJ?= =?utf-8?B?bE9ONEpyaVpVNjloUWtYcDAyKy9ySHNMbWdZSW05aWcrVW9PcS9yUnpiblgr?= =?utf-8?B?ODdyelFndzlBREdyZFBCZ0ZuOUpST3NxU0FwU1dBWGFwcWZ4YVl2WWJWS0tt?= =?utf-8?B?dC9yMkVNbHY3RStzaTV5S0pzVE9hYlVPV1FEUGRqQzJmTEI3ajdkUmsxb1BU?= =?utf-8?Q?bb7hyCi0fA/XLl7WhtA2kmm7n?= X-OriginatorOrg: solid-run.com X-MS-Exchange-CrossTenant-Network-Message-Id: fbd8ba2c-d2ee-40f6-b32b-08db538d928e X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8963.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 May 2023 08:39:31.8776 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a4a8aaf3-fd27-4e27-add2-604707ce5b82 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vwjxCPw83PcMdHBsa2IVF904g7MU/mOnuWyXS9wbGPXfbbjtwuXqnsDyQIR9rF/9V2y/TKyUo3tdkyZActmjsg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8705 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Simon, I have a private rewrite of the tlv functionality as a seperate library outside of the command implementation. Originally I had hoped to finish upstreaming that about a year ago but got sidetracked. Hopefully within the coming weeks I can submit another version as RFC that can address your concerns more easily than the current eeprom_tlv implementation. Sincerely Josua Mayer Am 08.05.23 um 17:42 schrieb Simon Glass: > Hi, > > On Fri, 5 May 2023 at 02:22, Josua Mayer wrote: >> Move the handler for "tlv_eeprom dev X" command to the beginning of >> do_tlv_eeprom, to allow using it before issuing a "read" command for >> currently selected eeprom. >> >> Also remove the check if eeprom exists, since that can only work after >> the first execution of read_eeprom triggered device lookup. >> Instead accept values up to the defined array size (MAX_TLV_DEVICES). >> >> Signed-off-by: Josua Mayer >> Reviewed-by: Stefan Roese >> Cc: Stefan Roese >> Cc: Baruch Siach >> Cc: Heinrich Schuchardt >> --- >> cmd/tlv_eeprom.c | 26 ++++++++++++++++---------- >> 1 file changed, 16 insertions(+), 10 deletions(-) > Can someone take a look at fixing up the driver model code? > > For example: > - it maintains its own array of eproms, when it should use driver > model to find them. > - the has_been_read flag seems to track only one EEPROM, but the code > indicates there might be two (should be in the device's private data) > - current_dev should be a pointer to a device > - ideally all state should be either in the device or the uclass, so > it can be used before relocation, etc. > > Regards, > Simon