From: Wolfgang Denk <wd@denx.de>
To: Marcel Ziswiler <marcel@ziswiler.com>
Cc: u-boot@lists.denx.de, Fabio Estevam <festevam@gmail.com>,
Stefano Babic <sbabic@denx.de>,
Heiko Thiery <heiko.thiery@gmail.com>,
Frieder Schrempf <frieder.schrempf@kontron.de>,
Oleksandr Suvorov <oleksandr.suvorov@toradex.com>,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
Marek Vasut <marex@denx.de>,
Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
Patrick Delaunay <patrick.delaunay@foss.st.com>,
Rick Chen <rick@andestech.com>, Tero Kristo <kristo@kernel.org>
Subject: Re: [PATCH v5 08/10] include/configs: apalis-imx8/verdin-imx8mm: rename kernel image variable
Date: Sat, 09 Oct 2021 18:07:41 +0200 [thread overview]
Message-ID: <2968246.1633795661@gemini.denx.de> (raw)
In-Reply-To: <20211008002815.870313-9-marcel@ziswiler.com>
Dear Marcel Ziswiler,
In message <20211008002815.870313-9-marcel@ziswiler.com> you wrote:
> From: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
>
> Variable "kernel_image" is used in boot.scr script only, that sets its
> own default value to the constant string @@KERNEL_IMAGETYPE@@ in case
> "kernel_image" is not set.
> The default name of the kernel image shipped with BSP 5.x is "Image.gz".
> Setting kernel_image="Image" as a pre-defined u-boot variable
> breaks booting systems with modern versions of boot.scr, whereas
> renaming it fixes booting with modern scripts and does not break working
> of earlier versions of boot.scr.
Same comment as before: please document all changes, i. e. the FDT
related changes.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
Certainly there are things in life that money can't buy, but it's
very funny - Did you ever try buying them without money? - Ogden Nash
next prev parent reply other threads:[~2021-10-09 16:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-08 0:28 [PATCH v5 00/10] board: toradex: verdin-imx8mm: target refresh Marcel Ziswiler
2021-10-08 0:28 ` [PATCH v5 01/10] imx8m: clean-up kconfig indentation Marcel Ziswiler
2021-10-08 0:28 ` [PATCH v5 02/10] verdin-imx8mm: fix ethernet Marcel Ziswiler
2021-10-08 0:28 ` [PATCH v5 03/10] ARM: dts: imx8mm-verdin: prepare for dek blob encapsulation Marcel Ziswiler
2021-10-08 0:28 ` [PATCH v5 04/10] verdin-imx8mm: switch to use binman to pack images Marcel Ziswiler
2021-10-08 0:28 ` [PATCH v5 05/10] verdin-imx8mm: enable sleep_moci output Marcel Ziswiler
2021-10-08 0:28 ` [PATCH v5 06/10] verdin-imx8mm: clean-up include order Marcel Ziswiler
2021-10-08 0:28 ` [PATCH v5 07/10] verdin-imx8mm: drop support for v1.0 hardware Marcel Ziswiler
2021-10-08 0:28 ` [PATCH v5 08/10] include/configs: apalis-imx8/verdin-imx8mm: rename kernel image variable Marcel Ziswiler
2021-10-09 16:07 ` Wolfgang Denk [this message]
2021-10-08 0:28 ` [PATCH v5 09/10] verdin-imx8mm: use preboot for fdtfile evaluation Marcel Ziswiler
2021-10-08 0:28 ` [PATCH v5 10/10] verdin-imx8mm: fix watchdog pinctrl issue Marcel Ziswiler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2968246.1633795661@gemini.denx.de \
--to=wd@denx.de \
--cc=festevam@gmail.com \
--cc=frieder.schrempf@kontron.de \
--cc=heiko.thiery@gmail.com \
--cc=kristo@kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=marcel@ziswiler.com \
--cc=marex@denx.de \
--cc=oleksandr.suvorov@toradex.com \
--cc=oleksandr_andrushchenko@epam.com \
--cc=patrick.delaunay@foss.st.com \
--cc=rick@andestech.com \
--cc=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox