From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?iso-8859-1?Q?Br=FCns=2C_Stefan?= Date: Thu, 7 Sep 2017 18:32:36 +0000 Subject: [U-Boot] [PATCH 1/1] scripts/Makefile.lib: remove overridden target $(obj)/helloworld.so: In-Reply-To: <1fa35956-8911-b3b6-32b9-fa87c4af580a@gmx.de> References: <20170903061746.29129-1-xypron.glpk@gmx.de> <1fa35956-8911-b3b6-32b9-fa87c4af580a@gmx.de> Message-ID: <2994282.mGfOXkTzPg@sbruens-linux> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sonntag, 3. September 2017 17:26:43 CEST Heinrich Schuchardt wrote: > On 09/03/2017 02:19 PM, Alexander Graf wrote: > > On 03.09.17 08:17, Heinrich Schuchardt wrote: > >> The target > >> $(obj)/helloworld.so: > >> exists twice in Makefile.lib. > >> > >> If you add an echo command to each of the two recipes you get > >> warnings like: > >> > >> scripts/Makefile.lib:383: warning: > >> overriding recipe for target 'drivers/power/battery/helloworld.so' > >> scripts/Makefile.lib:379: warning: > >> ignoring old recipe for target 'drivers/power/battery/helloworld.so' > >> > >> This patch removes the obsolete target. > >> > >> Signed-off-by: Heinrich Schuchardt > >> --- > >> Hello Alex, > >> > >> could you, please, review the change as it relates to EFI. > > > > My Makefile foo isn't quite as good as it should be, but doesn't the > > existing code simply add another dependency to the required build chain? > > The target is overridden so why should the dependency be executed? > > https://www.gnu.org/software/make/manual/html_node/Overriding-Makefiles.html > says: > "However, it is invalid for two makefiles to give different recipes for > the same target. I guess this will be valid for a single makefile too." > > If you think the dependency is necessary, I can add it to the remaining > target. Is this what you prefer? Note there is a difference between prerequisite and recipe - specifying a target multiple times without recipe adds the the prerequisite to the existing set, see https://www.gnu.org/software/make/manual/html_node/Multiple-Targets.html#Multiple-Targets --- foo: a foo: b c a: @echo "Creating prereq a" %: @echo "Creating $@" ---- This tries to create the default target foo (first specified target), which has three prerequisites (a, b, c), which are run in parallel. Kind regards, Stefan