From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hayes Wang <hayeswang@realtek.com>
Date: Mon, 15 Jun 2020 06:52:18 +0000
Subject: [PATCH u-boot 4/4] eth/r8152: support RTL8153B/RTL8154B
In-Reply-To: <af57f3e0-2943-36c0-d480-cb7203fae45c@denx.de>
References: <1394712342-15778-377-Taiwan-albertk@realtek.com>
 <1394712342-15778-381-Taiwan-albertk@realtek.com>
 <78409d87-514d-1321-76de-a3b5161086a7@denx.de>
 <581ab1fe517047fb8624bf22ac46151c@realtek.com>
 <f6579280-366a-cbf4-e72b-6ca6f60e21af@denx.de>
 <6a79f2a4d85c42138fb93ffef5222a6e@realtek.com>
 <6c791826-d28b-cc89-b230-6b5d1a252399@denx.de>
 <43e79ab399134d4392770f0f28a29372@realtek.com>
 <1fed268b-b6b4-e435-7ce9-728376a6c381@denx.de>
 <8175c1928607441d85c2884c4ec71cb1@realtek.com>
 <af57f3e0-2943-36c0-d480-cb7203fae45c@denx.de>
Message-ID: <29c989e72ec442d3a1f103ebf03654a2@realtek.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Marek Vasut [mailto:marex at denx.de]
> Sent: Friday, June 12, 2020 7:53 PM
[...]
> Try this:
> 
> 	ocp_data = r8152_efuse_read(tp, 0x7d);
> 	ocp_data = (ocp_data & 0x1fff0) >> 1) | (ocp_data & 0x7);
> 	if (data != 0xffff)
> 		ocp_reg_write(tp, OCP_ADC_IOFFSET, data);

I think you mean

	ocp_data = r8152_efuse_read(tp, 0x7d);
	ocp_data = ((ocp_data & 0x1fff0) >> 1) | (ocp_data & 0x7);
	if (ocp_data != 0xffff)
		ocp_reg_write(tp, OCP_ADC_IOFFSET, ocp_data);

> That should work, no ? Or does it generate compiler warnings ?

It shows no warning.

Best Regards,
Hayes