From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0CFDC07E95 for ; Fri, 2 Jul 2021 20:20:54 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C7D4C6140E for ; Fri, 2 Jul 2021 20:20:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C7D4C6140E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1F1D9829B9; Fri, 2 Jul 2021 22:20:52 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1625257252; bh=WDRK84hoFSV3Yk/P2lhWi6MDud7QkTcKZi+yfrp5E0I=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Djnxu5MTucLRVDxmgCcDs5/cRNDvRjXGpedz3fmZxegbxKsPd0b6eon3mSMjyDHhe pzhRw/s4eImGHzpTtYJZphMPtRoWP8sZUvpBeVgyMmYXqBLGa4QthRjpMRZ8bkG/ZC J63WbPk2NrVfUz1IBPvvx+N1Gi4mTV1khqkFW6npeMzcG5rY2arGaSnNRomIWH8L1E z6jMS1zgTt4K2l/6ATNk0UjIRKE1o0BeapLLTtgpJPo68D2XH67lzx9wCEvrQnmcDw V0HxZjskil9i9+gONiENSQQ/MVhpvx8rurG5F72B7EwZcOCx1F54FWsZ5J6SpGTm6a HUepRX6nMUQwA== Received: from [IPv6:::1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 0B05482979; Fri, 2 Jul 2021 22:20:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1625257250; bh=WDRK84hoFSV3Yk/P2lhWi6MDud7QkTcKZi+yfrp5E0I=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=Fiq5kfFnHCytD+Zy1c1r2RqKoMXybApHAKVxvtnLIX6lTTzO6aQnPAJFxTT/SOnW5 JkbWDMRG6S2ZD1iC3W2lJpjAQRCxoD2L/In3MtmWbWNQmsIvAYn0yGiRobG21iia5f roi2ckBUaEAS66mk45LyXQc4jSnpvpnNBHtwiK7nduxxDnROif+Qp9bFnpXeW1UZ4Z Jz4YumrAVISDL9oaah0JgOZTydIFfX2/YHR3QlqphcAh/oizv/lAuU9+vwb6q7GYnY mt0PKBfnVRe/O8mRztcjWZKWzGZ2RpztDsWfZYpe9n9geF5zyPaV1eYy9xHQD6IR9m qhPbGoNXSLGTw== Subject: Re: [PATCH V2] spi: Update speed/mode on change To: Da Xue Cc: "u-boot@lists.denx.de" , Neil Armstrong , Tom Rini References: <20210610120000.5147-1-marex@denx.de> <20210630164943.GG9516@bill-the-cat> <912308c5-3493-badb-36ba-55e5c265b2c9@denx.de> <41e7bf52-227c-fe87-f249-6d2df8d16aba@denx.de> <6f735811-6f72-b2b9-62de-dbaf3671a30d@denx.de> <75e38df1-af34-f873-ac76-b4e9cfb8c2be@denx.de> From: Marek Vasut Message-ID: <2a57939e-609e-5957-4f5e-40dff89c304c@denx.de> Date: Fri, 2 Jul 2021 22:20:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 7/2/21 10:10 PM, Da Xue wrote: [...] >>>> That should do the trick. Can you check which of the mode bits is set in >>>> meson_spifc_set_mode() and triggers the ENODEV condition ? >>>> >>> >>> SPI_CPHA seems to be the culprit. I tried adding spi-cpha = <0> to no >>> avail. >> >> Can you find out what is setting the SPI_CPHA in the first place on your >> machine ? >> > > The Kconfig was setting it to 3. I manually added the default mode (0) to > my board's config and it worked. Thanks Marek. Sure, good thing this was fixed. Please send a patch for the board, so it can be added to this release.