From: Kishon Vijay Abraham I <kishon@ti.com>
To: Tom Rini <trini@konsulko.com>
Cc: Lokesh Vutla <lokeshvutla@ti.com>, Simon Glass <sjg@chromium.org>,
<marex@denx.de>, <a-govindraju@ti.com>, <u-boot@lists.denx.de>
Subject: Re: [PATCH v3 19/20] env: ti: j721e-evm: Add env variable to power on & reset QSGMII PHY in J7200 EVM
Date: Fri, 9 Jul 2021 20:02:03 +0530 [thread overview]
Message-ID: <2af86da3-e47a-b142-efb4-46fde4c0e443@ti.com> (raw)
In-Reply-To: <20210511143311.GP17669@bill-the-cat>
Hi Tom,
On 11/05/21 8:03 pm, Tom Rini wrote:
> On Tue, May 11, 2021 at 07:28:10PM +0530, Kishon Vijay Abraham I wrote:
>> Hi Tom,
>>
>> On 07/05/21 10:44 pm, Tom Rini wrote:
>>> On Tue, May 04, 2021 at 04:11:54PM +0530, Kishon Vijay Abraham I wrote:
>>>
>>>> MAIN CPSW0 requires the PHY to be powered on and reset for QSGMII
>>>> operation. Add a env variable to configure driving "0" on ENET_EXP_PWRDN
>>>> controlled by GPIO EXPANDER2 (I2C Addr: 0x22), PIN: 17 and driving "1"
>>>> on ENET_EXP_RESETZ controlled by GPIO EXPANDER2 (I2C Addr: 0x22),
>>>> PIN: 18.
>>>>
>>>> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
>>>> Reviewed-by: Suman Anna <s-anna@ti.com>
>>>> ---
>>>> include/configs/j721e_evm.h | 16 +++++++++++++++-
>>>> 1 file changed, 15 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/include/configs/j721e_evm.h b/include/configs/j721e_evm.h
>>>> index b707fc4e89..00d0a18a68 100644
>>>> --- a/include/configs/j721e_evm.h
>>>> +++ b/include/configs/j721e_evm.h
>>>> @@ -139,11 +139,24 @@
>>>> #endif /* CONFIG_TARGET_J721E_A72_EVM */
>>>>
>>>> #ifdef CONFIG_TARGET_J7200_A72_EVM
>>>> +#define EXTRA_ENV_CONFIG_MAIN_CPSW0_QSGMII_PHY \
>>>> + "do_main_cpsw0_qsgmii_phyinit=1\0" \
>>>
>>> When would this be not true?
>>
>> If the user don't want to use QSGMII, this could be set to false. For
>> instance the SERDES in J7200 can be used such that it can be used with
>> two protocols at a time. So it can be either PCIe + QSGMII or PCIe +
>> USB. So for use cases which require PCIe + USB, this could be set to false.
>
> Then we need to create doc/board/ti/j721e_evm.rst with some general
> content and then document the above in there.
There is already a document @ board/ti/j721e/README which has some
general information. Maybe that could be updated and moved to
doc/board/ti/j721e_evm.rst?
Thanks
Kishon
>
>>>> + "init_main_cpsw0_qsgmii_phy=gpio set gpio@22_17;" \
>>>> + "gpio clear gpio@22_16\0" \
>>>> + "main_cpsw0_qsgmii_phyinit=" \
>>>> + "if test ${do_main_cpsw0_qsgmii_phyinit} -eq 1 && test ${dorprocboot} -eq 1 && " \
>>>> + "test ${boot} = mmc; then " \
>>>
>>> And why only on mmc?
>>
>> The current J7200 u-boot code loads firmwares for remote cores only from
>> MMC. So if it's not mmc, it's not going to load ethernet firmware and
>> hence not required to configure the PHY.
>
> OK. Please make sure this is also part of the documentation. Thanks.
>
next prev parent reply other threads:[~2021-07-09 14:32 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 10:41 [PATCH v3 00/20] TI/Cadence: Add Sierra/Torrent SERDES driver Kishon Vijay Abraham I
2021-05-04 10:41 ` [PATCH v3 01/20] dm: core: Add helper to compare node names Kishon Vijay Abraham I
2021-05-04 16:58 ` Simon Glass
2021-05-04 10:41 ` [PATCH v3 02/20] dm: test: Add test case to check node name ignoring unit address Kishon Vijay Abraham I
2021-05-04 10:41 ` [PATCH v3 03/20] drivers: reset: Handle gracefully NULL pointers Kishon Vijay Abraham I
2021-05-04 16:58 ` Simon Glass
2021-05-05 4:25 ` Kishon Vijay Abraham I
2021-05-05 23:37 ` Simon Glass
2021-05-06 13:09 ` Kishon Vijay Abraham I
2021-05-06 15:06 ` Simon Glass
2021-05-04 10:41 ` [PATCH v3 04/20] dt-bindings: phy: Add definitions for additional phy types Kishon Vijay Abraham I
2021-05-04 10:41 ` [PATCH v3 05/20] dt-bindings: phy: Add defines for AM64 SERDES Wrapper Kishon Vijay Abraham I
2021-05-04 10:41 ` [PATCH v3 06/20] dt-bindings: phy: cadence-torrent: Add defines for refclk driver Kishon Vijay Abraham I
2021-05-04 10:41 ` [PATCH v3 07/20] dt-bindings: ti-serdes-mux: Add defines for AM64 SoC Kishon Vijay Abraham I
2021-05-04 10:41 ` [PATCH v3 08/20] phy: cadence: Add driver for Sierra PHY Kishon Vijay Abraham I
2021-05-04 10:41 ` [PATCH v3 09/20] phy: cadence: Add driver for Torrent SERDES Kishon Vijay Abraham I
2021-05-04 10:41 ` [PATCH v3 10/20] phy: ti: j721e-wiz: Add support for WIZ module present in TI J721E SoC Kishon Vijay Abraham I
2021-05-04 10:41 ` [PATCH v3 11/20] usb: cdns3: cdns3-ti: Fix clk_get_by_name() to get the correct name Kishon Vijay Abraham I
2021-05-04 10:41 ` [PATCH v3 12/20] board: ti: j721e: Add support for probing and configuring Torrent serdes on J7200 Kishon Vijay Abraham I
2021-05-04 10:41 ` [PATCH v3 13/20] ARM: dts: k3-j721e: Add the entries required for USB3 support on USB0 Kishon Vijay Abraham I
2021-05-07 17:14 ` Tom Rini
2021-07-09 14:06 ` Kishon Vijay Abraham I
2021-07-09 14:16 ` Tom Rini
2021-05-04 10:41 ` [PATCH v3 14/20] arm: dts: k3-j7200-main: Add DT node for torrent serdes Kishon Vijay Abraham I
2021-05-04 10:41 ` [PATCH v3 15/20] arm: dts: k3-j7200-common-proc-board: Enable SERDES DT Kishon Vijay Abraham I
2021-05-04 10:41 ` [PATCH v3 16/20] arm: dts: k3-j7200-common-proc-board-u-boot: Add u-boot tags for torrent serdes Kishon Vijay Abraham I
2021-05-04 10:41 ` [PATCH v3 17/20] configs: j721e_evm_a72: Enable the drivers required for the USB3 support Kishon Vijay Abraham I
2021-05-04 10:41 ` [PATCH v3 18/20] configs: j7200_evm_a72_defconfig: Add config for torrent serdes and common clock framework Kishon Vijay Abraham I
2021-05-04 10:41 ` [PATCH v3 19/20] env: ti: j721e-evm: Add env variable to power on & reset QSGMII PHY in J7200 EVM Kishon Vijay Abraham I
2021-05-07 17:14 ` Tom Rini
2021-05-11 13:58 ` Kishon Vijay Abraham I
2021-05-11 14:33 ` Tom Rini
2021-07-09 14:32 ` Kishon Vijay Abraham I [this message]
2021-07-09 14:36 ` Tom Rini
2021-05-04 10:41 ` [PATCH v3 20/20] configs: j7200_evm_a72: Enhance bootcmd to configure ethernet PHY Kishon Vijay Abraham I
2021-05-07 17:16 ` [PATCH v3 00/20] TI/Cadence: Add Sierra/Torrent SERDES driver Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2af86da3-e47a-b142-efb4-46fde4c0e443@ti.com \
--to=kishon@ti.com \
--cc=a-govindraju@ti.com \
--cc=lokeshvutla@ti.com \
--cc=marex@denx.de \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox