From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BCC75C05027 for ; Fri, 3 Feb 2023 13:29:47 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4683285F12; Fri, 3 Feb 2023 14:29:45 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.b="4V8I069m"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D7A3B85E55; Fri, 3 Feb 2023 14:29:43 +0100 (CET) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on20607.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e8b::607]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4C89885F12 for ; Fri, 3 Feb 2023 14:29:41 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=michal.simek@amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b3T6NAjpz7RyfoBHwnDDBeMd+dSZc9sJq7nauxjrYZb126jN5L4bJpsV6crDidTfL4aemlu8o4cQ34T0ca3fIE++MAj9H90RV/zz09BPelflYeTYL15Ap0RSKA8KvIXECxobEZJZIzeCmzj/5O+f51Dnbi7FG3hx1uxsJr70O8OPVthV0cnUVilex19eqoJwMlM7oZa56CYKVnZ8kveGiZ4xWSMwg/qIb+APvIp5as3cJ+nPY05qemRTlUeBRhWMqpjNcTeZA4ApOe59/5KVhGH+S7qlcUT9seKDWxkNJd4IuhR35imQjXy/PG5NZvIlI55zGk3/mHbKWKdoWnguHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F7EA3yAWBEYaaQm6Nab+WxRZcz5WEZuPA9LqFimFqp0=; b=XYFBVpKA2gFguNkzhuSN5Apr0lQJYlNt4Q5GDvdC2JFQaEvQswuRzdYMkV6H4dbJDV2Y/v581dWvH0SQbd4Mi1IEPYWEBSVpm+Y8SAIfLIspkadqu5T7NXMwf3F1iLvOvt9GDQVR4inWuABYFLZBWbQlbbpn1iv6Dl8vSmfYtUrRknYJqtsYvVokH8fddPJvPQV1y8oRZkc0qRYXt3TngcvI8y6rWcD97MIj4Pb8iEVDIwEAaTfERJJIJ8HI7t1piv10qcI9hkRH6t/LOYy4CgGu749bHkni7Ia7g/y8mP1LwnvkLxW/TG9FYZmsb55tOWUj3QIK6zhTDjRjsx52bA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.denx.de smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F7EA3yAWBEYaaQm6Nab+WxRZcz5WEZuPA9LqFimFqp0=; b=4V8I069mKAhF67hB5jA6CO1BhbGL1EfQhj/H7rz66BLytR/ulsB2PGKWFNj/vC4xWOU080Mzxha2IyzNEXCZTExYFgjxt7H3wpNKVS62iAf1PqF2+nPF52byhfhnsFoYVuJd9FnW7qPKWD2ZiKE985ANc1A8fwRlA5eRVQgcozE= Received: from CY5PR15CA0007.namprd15.prod.outlook.com (2603:10b6:930:14::13) by SN7PR12MB7105.namprd12.prod.outlook.com (2603:10b6:806:2a0::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.25; Fri, 3 Feb 2023 13:29:37 +0000 Received: from CY4PEPF0000C976.namprd02.prod.outlook.com (2603:10b6:930:14:cafe::c5) by CY5PR15CA0007.outlook.office365.com (2603:10b6:930:14::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.29 via Frontend Transport; Fri, 3 Feb 2023 13:29:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CY4PEPF0000C976.mail.protection.outlook.com (10.167.241.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6064.19 via Frontend Transport; Fri, 3 Feb 2023 13:29:36 +0000 Received: from [10.254.241.50] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Fri, 3 Feb 2023 07:29:30 -0600 Message-ID: <2b24632b-182b-8b42-e592-12caea0ac16d@amd.com> Date: Fri, 3 Feb 2023 14:29:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] arm64: zynqmp: Add missing ZYNQMP_FIRMWARE dependencies Content-Language: en-US To: Ashok Reddy Soma , CC: , , , , , , , Algapally Santosh Sagar References: <20230201095553.11219-1-ashok.reddy.soma@amd.com> From: Michal Simek In-Reply-To: <20230201095553.11219-1-ashok.reddy.soma@amd.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000C976:EE_|SN7PR12MB7105:EE_ X-MS-Office365-Filtering-Correlation-Id: 6cffbaa8-d1fc-410f-438c-08db05eab1fe X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /TJimUki9FbAO21UQI0xKtI2w2HjxtxjnIq24YO9antM3IzaE6bjhBTk472t6orrzejAOUZEmomuq8ezAk/EI8N70X/u8pdFE6SetsfSn86AOYtFTmNnVJXCdSm1SEhEfvqi8D03f1bcpRAvYkKY57TxzhkkkzbUMEcEM+6pUUi3cJLBvHD3yKfe0Vl/uxoJlIT8i9SswTeA0lz6rm3oFtrBhr9rawpacLMVwsdFEz91QRkaD7IhARjKmx6kNrW4w11GEMzB5/gaXZTFo2I/04o1UkhDswIIxUQRmn6QBQqCxW8IGooi5+NprwhYPtTI2Ai9xxAXBkqTtAJrO+eqYIjvV/fsn+Dhg69WglX0Goo74mnqFcs1wmbJosdlua9MIdFWs/cxZrS5/1+a6POvhfS7QZdsyh8ziOzs/mXFo54Lk4V9Id8MYAYV1gRufWVuBS6+x8X4AUW6KY7+u0I41gnhJfuG3gVv6dKctZId3BqVHE+EjL6BD+1gWiN9mGpljSiGmIDMooFVEwb6kYbQ3DSG6IUxXUEKO7CqAidX18HCyQUruy0bj1SPLK7QOyq1w+16VEt+n5Nn06xn+yA+uEKFlvv3+hpVh/ZsN0i/vFXBJzqVOM4nD4alArKK4TjVVqL+tkr8bfnAX7fWhP1hcav68oS6qQPCz99GwPafU/AvybnPhtOJvMsf1E9xBni5TsZOKTVHCU0a3I6WD038oaXN9CYdhWu/g/MfW6uhXA2rVRS03JBW+CbIvKxvC6jAlUfKbvQ6Y1TzGzq85+Rm1A== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230025)(4636009)(346002)(136003)(39860400002)(376002)(396003)(451199018)(40470700004)(46966006)(36840700001)(426003)(336012)(40460700003)(2616005)(54906003)(83380400001)(110136005)(8936002)(8676002)(478600001)(316002)(41300700001)(16576012)(4326008)(70206006)(70586007)(186003)(53546011)(82310400005)(47076005)(31696002)(16526019)(86362001)(356005)(36756003)(26005)(40480700001)(44832011)(2906002)(5660300002)(81166007)(82740400003)(36860700001)(31686004)(36900700001)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2023 13:29:36.8835 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6cffbaa8-d1fc-410f-438c-08db05eab1fe X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000C976.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7105 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 2/1/23 10:55, Ashok Reddy Soma wrote: > From: Algapally Santosh Sagar > > There are missing Kconfig dependencies in the code which is using > firmware interface. > The commit 71efd45a5fc7 ("arm64: zynqmp: Change firmware dependency") > add option to also disable ZYNQMP_FIRMWARE. But not all Kconfig > dependencies were properly described and also sdhci and gem drivers > didn't protect the code properly. > So, add the missing ZYNQMP_FIRMWARE dependencies. > > Signed-off-by: Algapally Santosh Sagar > Signed-off-by: Ashok Reddy Soma > --- > > board/xilinx/zynqmp/Kconfig | 1 + > drivers/clk/Kconfig | 4 ++-- > drivers/fpga/Kconfig | 2 +- > drivers/mmc/zynq_sdhci.c | 4 ++-- > drivers/net/zynq_gem.c | 2 +- > 5 files changed, 7 insertions(+), 6 deletions(-) > > diff --git a/board/xilinx/zynqmp/Kconfig b/board/xilinx/zynqmp/Kconfig > index 7d1f7398c3..ffa2f0215d 100644 > --- a/board/xilinx/zynqmp/Kconfig > +++ b/board/xilinx/zynqmp/Kconfig > @@ -6,6 +6,7 @@ if ARCH_ZYNQMP > > config CMD_ZYNQMP > bool "Enable ZynqMP specific commands" > + depends on ZYNQMP_FIRMWARE > default y > help > Enable ZynqMP specific commands like "zynqmp secure" > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig > index 09aa97ee8c..42280cbf83 100644 > --- a/drivers/clk/Kconfig > +++ b/drivers/clk/Kconfig > @@ -185,7 +185,7 @@ config CLK_VERSACLOCK > config CLK_VERSAL > bool "Enable clock driver support for Versal" > depends on (ARCH_VERSAL || ARCH_VERSAL_NET) > - select ZYNQMP_FIRMWARE > + imply ZYNQMP_FIRMWARE > help > This clock driver adds support for clock realted settings for > Versal platform. > @@ -219,7 +219,7 @@ config CLK_ZYNQ > config CLK_ZYNQMP > bool "Enable clock driver support for ZynqMP" > depends on ARCH_ZYNQMP > - select ZYNQMP_FIRMWARE > + imply ZYNQMP_FIRMWARE > help > This clock driver adds support for clock realted settings for > ZynqMP platform. > diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig > index 4113de230c..f8b0aeb3ee 100644 > --- a/drivers/fpga/Kconfig > +++ b/drivers/fpga/Kconfig > @@ -63,7 +63,7 @@ config FPGA_XILINX > > config FPGA_ZYNQMPPL > bool "Enable Xilinx FPGA driver for ZynqMP" > - depends on FPGA_XILINX > + depends on FPGA_XILINX && ZYNQMP_FIRMWARE > help > Enable FPGA driver for loading bitstream in BIT and BIN format > on Xilinx Zynq UltraScale+ (ZynqMP) device. > diff --git a/drivers/mmc/zynq_sdhci.c b/drivers/mmc/zynq_sdhci.c > index 91e309d275..8b559d8a7a 100644 > --- a/drivers/mmc/zynq_sdhci.c > +++ b/drivers/mmc/zynq_sdhci.c > @@ -988,7 +988,7 @@ static const struct sdhci_ops arasan_ops = { > }; > #endif > > -#if defined(CONFIG_ARCH_ZYNQMP) > +#if defined(CONFIG_ARCH_ZYNQMP) && defined(CONFIG_ZYNQMP_FIRMWARE) > static int sdhci_zynqmp_set_dynamic_config(struct arasan_sdhci_priv *priv, > struct udevice *dev) > { > @@ -1090,7 +1090,7 @@ static int arasan_sdhci_probe(struct udevice *dev) > > host = priv->host; > > -#if defined(CONFIG_ARCH_ZYNQMP) > +#if defined(CONFIG_ARCH_ZYNQMP) && defined(CONFIG_ZYNQMP_FIRMWARE) > if (device_is_compatible(dev, "xlnx,zynqmp-8.9a")) { > ret = zynqmp_pm_is_function_supported(PM_IOCTL, > IOCTL_SET_SD_CONFIG); > diff --git a/drivers/net/zynq_gem.c b/drivers/net/zynq_gem.c > index cc49788012..211b2c6e55 100644 > --- a/drivers/net/zynq_gem.c > +++ b/drivers/net/zynq_gem.c > @@ -738,7 +738,7 @@ static int gem_zynqmp_set_dynamic_config(struct udevice *dev) > u32 pm_info[2]; > int ret; > > - if (IS_ENABLED(CONFIG_ARCH_ZYNQMP)) { > + if (IS_ENABLED(CONFIG_ARCH_ZYNQMP) && IS_ENABLED(CONFIG_ZYNQMP_FIRMWARE)) { > if (!zynqmp_pm_is_function_supported(PM_IOCTL, > IOCTL_SET_GEM_CONFIG)) { > ret = ofnode_read_u32_array(dev_ofnode(dev), Applied. M