From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 51C0EC05027 for ; Fri, 10 Feb 2023 07:25:33 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 496E8858F9; Fri, 10 Feb 2023 08:25:30 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=collabora.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=collabora.com header.i=@collabora.com header.b="T37lJe4N"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A52E8858FB; Fri, 10 Feb 2023 08:25:28 +0100 (CET) Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 344C1858F8 for ; Fri, 10 Feb 2023 08:25:26 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=collabora.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=eugen.hristev@collabora.com Received: from [192.168.0.125] (unknown [82.76.24.202]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: ehristev) by madras.collabora.co.uk (Postfix) with ESMTPSA id 5829F66020DC; Fri, 10 Feb 2023 07:25:25 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1676013925; bh=5IDgdcSMMetGEtN0f5I3t9jb5Hkex29BeKUbUb9b+F4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=T37lJe4NTU9uHoiZ+LpofIxQ0MFSzWW9C8z/F4iiOV+Dhaf2BVO6e/zDbgBdoYOmx xraHU0aI38hlN/7xlsNsT9nwxlX4xm7ZTz316Kdn8SEubxDfROlE5yLOd/DhK1t+On IFVA3CDEpRAlYkLKD74UxQtbcwprMbg/Lrk78Y6WeSWxkHx4Dd5M1T8IHCUbVUEuyZ kPNdU4SvWYvMzxKt89dZ8JreXtEZAFM+lx0tRQWWfu2YvD+MWZx+2MFKSvO7rM3nuH tGGHwIvnjwuybUelajZd8YBIb4bkXjKo6VE7nXKdHEufYelZdTtJmsV4PrgFgEHKkN vYwoay5Ldx3sg== Message-ID: <2b2c05a3-2886-e82b-af8f-6f75c84400b3@collabora.com> Date: Fri, 10 Feb 2023 09:25:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v2 031/169] Correct SPL use of ATMEL_PIO4 Content-Language: en-US To: Tom Rini , Simon Glass Cc: U-Boot Mailing List References: <20230205223836.231657-1-sjg@chromium.org> <20230205223836.231657-32-sjg@chromium.org> From: Eugen Hristev In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 2/9/23 19:36, Tom Rini wrote: > On Sun, Feb 05, 2023 at 03:36:17PM -0700, Simon Glass wrote: > >> This converts 1 usage of this option to the non-SPL form, since there is >> no SPL_ATMEL_PIO4 defined in Kconfig >> >> Signed-off-by: Simon Glass >> --- >> >> (no changes since v1) >> >> drivers/pinctrl/pinctrl-at91-pio4.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/pinctrl/pinctrl-at91-pio4.c b/drivers/pinctrl/pinctrl-at91-pio4.c >> index 50e3dd449ab..84b398619c4 100644 >> --- a/drivers/pinctrl/pinctrl-at91-pio4.c >> +++ b/drivers/pinctrl/pinctrl-at91-pio4.c >> @@ -271,7 +271,7 @@ static int atmel_pinctrl_bind(struct udevice *dev) >> ofnode node = dev_ofnode(dev); >> struct atmel_pinctrl_data *priv = (struct atmel_pinctrl_data *)dev_get_driver_data(dev); >> >> - if (!CONFIG_IS_ENABLED(ATMEL_PIO4)) >> + if (!IS_ENABLED(CONFIG_ATMEL_PIO4)) >> return 0; >> >> /* Obtain a handle to the GPIO driver */ > > This grows SPL in a number of platforms, so adding in Eugen to see if we > really do want to omit this here in SPL on platforms that otherwise set > the symbol. > Hi Simon, Tom, The growth is because the compiler will now include in SPL all the code below the check ? The respective code is not conditionally compiled, so I am trying to see why the growth. The solution would be to guard all the below code in the function (or the whole bind itself) by #ifndef CONFIG_SPL_BUILD ? Eugen