Re: [PATCH v2 2/4] rockchip: sdhci: Fix RK3399 eMMC PHY power cycling

[Alper Nebi Yasak <alpernebiyasak@gmail.com>]

On 21/01/2022 18:20, Simon Glass wrote:
> On Tue, 11 Jan 2022 at 06:40, Alper Nebi Yasak <alpernebiyasak@gmail.com> wrote:
>> diff --git a/drivers/mmc/rockchip_sdhci.c b/drivers/mmc/rockchip_sdhci.c
>> index 278473899c7c..f0d7ba4774d6 100644
>> --- a/drivers/mmc/rockchip_sdhci.c
>> +++ b/drivers/mmc/rockchip_sdhci.c
>> @@ -90,9 +90,10 @@ struct rockchip_sdhc {
>>  };
>>
>>  struct sdhci_data {
>> -       int (*emmc_set_clock)(struct sdhci_host *host, unsigned int clock);
>>         int (*emmc_phy_init)(struct udevice *dev);
>>         int (*get_phy)(struct udevice *dev);
>> +       void (*set_control_reg)(struct sdhci_host *host);
>> +       int (*set_ios_post)(struct sdhci_host *host);
> 
> These should each have a full function comment.

I tried to write some words for these and set_enhanced_strobe() in the
other patches, will send as v4 now.

> I don't see the kevin patches applied yet...what is happening there?

They're still not applied. I don't know what I can do about that besides
trying to send a pull request myself. Not feeling confident about that,
though, should I?


OTOH, I expect this series are testable and should be working with or
without those patches.