From: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] Kbuild: standalone: do not ignore platform-specific OBJCOPYFLAGS
Date: Sun, 28 Oct 2018 21:13:04 +0100 [thread overview]
Message-ID: <2df3721b-02cc-4152-d476-933257fd2124@gmail.com> (raw)
In-Reply-To: <20180923171517.21363-3-daniel.schwierzeck@gmail.com>
Am 23.09.18 um 19:15 schrieb Daniel Schwierzeck:
> Currently the OBJCOPYFLAGS are cleared when assigning "-O srec"
> or "-O binary" for standalone programs. All flags set by arch-specific
> Makefiles are lost. This is bad if an arch demands arch-specific
> flags for the objcopy step.
are there any objections or can I apply this to u-boot-mips/next? Thanks.
>
> Signed-off-by: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
> ---
>
> examples/standalone/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/examples/standalone/Makefile b/examples/standalone/Makefile
> index abe1bf1883..f01816f24f 100644
> --- a/examples/standalone/Makefile
> +++ b/examples/standalone/Makefile
> @@ -62,11 +62,11 @@ quiet_cmd_link_elf = LD $@
> $(ELF): $(obj)/%: $(obj)/%.o $(LIB) FORCE
> $(call if_changed,link_elf)
>
> -$(obj)/%.srec: OBJCOPYFLAGS := -O srec
> +$(obj)/%.srec: OBJCOPYFLAGS += -O srec
> $(obj)/%.srec: $(obj)/% FORCE
> $(call if_changed,objcopy)
>
> -$(obj)/%.bin: OBJCOPYFLAGS := -O binary
> +$(obj)/%.bin: OBJCOPYFLAGS += -O binary
> $(obj)/%.bin: $(obj)/% FORCE
> $(call if_changed,objcopy)
>
>
--
- Daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181028/23e6b6b6/attachment.sig>
next prev parent reply other threads:[~2018-10-28 20:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-23 17:15 [U-Boot] [PATCH 0/3] MIPS: fix building and linking of standalone programs Daniel Schwierzeck
2018-09-23 17:15 ` [U-Boot] [PATCH 1/3] Kbuild: add LDFLAGS_STANDALONE Daniel Schwierzeck
2018-10-28 20:12 ` Daniel Schwierzeck
2018-10-29 13:34 ` Tom Rini
[not found] ` <752D002CFF5D0F4FA35C0100F1D73F3FA3A3B5EC@ATCPCS16.andestech.com>
2018-10-30 1:40 ` Rick Chen
2018-11-02 22:28 ` Daniel Schwierzeck
2018-09-23 17:15 ` [U-Boot] [PATCH 2/3] Kbuild: standalone: do not ignore platform-specific OBJCOPYFLAGS Daniel Schwierzeck
2018-10-28 20:13 ` Daniel Schwierzeck [this message]
2018-10-29 13:34 ` Tom Rini
2018-11-02 22:29 ` Daniel Schwierzeck
2018-09-23 17:15 ` [U-Boot] [PATCH 3/3] MIPS: fix linking of standalone programs Daniel Schwierzeck
2018-11-02 22:30 ` Daniel Schwierzeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2df3721b-02cc-4152-d476-933257fd2124@gmail.com \
--to=daniel.schwierzeck@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox