From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DD09CEB64DA for ; Wed, 12 Jul 2023 23:58:20 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id EE45486AC0; Thu, 13 Jul 2023 01:58:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=variscite.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=variscite.com header.i=@variscite.com header.b="OMLwHvO7"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2F63F86AC0; Thu, 13 Jul 2023 01:58:17 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on060c.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe0e::60c]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E14888623A for ; Thu, 13 Jul 2023 01:58:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=variscite.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=Nate.D@variscite.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UkVGy/XGRxVhUsJTMuXmOIC3RRDbYorcWoRAvzgJxpMLEw+JJpoGMXhYosKFtS9hsrEhRJYyVaSxtmF+L3L4eJab0n5+MuGVjKzN0SzYb0Uh0ay4dHHC3OPaJsCX27JMYmGulkWbXhEl6/LhGSupH8h3qHXlbWsuNn4mmxqJ6H2HQzs24zgIf07tDyPURo1erE23awQ8cpBuMKVZuxOe0FKsWxLIBYJDlVSgaZOi+CNc7aAc1n4t3kSRk/0bY3VYMoXzU9qXe/u4rxjD6hBguIpH2y48Xy7Ms7ix3IS+L8gVC4sac6dJE53uI7DF+OmDGvI4sj7l3qXiih0eLhyUyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2/70OFJnBOs9+fou8JQM+7JjmVzcpmtV03xoeIm6vMQ=; b=cKYh/XdNP+dDX6NdCSMQS8SPC5oIs3yVmfLmQn2Vm2QITu46EB0+/iFYRUHifvsfJnYJR1yH//meAeG6Dma9a/dDVwfvT68ofZRwTi0qjNJYK13yCMKfZn8nC+MxrsStoASRAOlR+krKIQei8krIzWjqRCJ2wV0FBmH8+9/0qm99Evn9LVBS3pIeUnITF2jsfzsIfyehJkiNKg2LLcsSwqb7aDV+qW6Apn7DpUaEdG43b+A8zqlS/hW1HwppyBCCYc2GsTq1ixCL0/PoKh/MqpO9oeyYwbr9/FXMkm9Ml2vtmyOtjL+eeJOaY8KWbOQOpAMLZGfgBelFND73yzJj7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=variscite.com; dmarc=pass action=none header.from=variscite.com; dkim=pass header.d=variscite.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=variscite.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2/70OFJnBOs9+fou8JQM+7JjmVzcpmtV03xoeIm6vMQ=; b=OMLwHvO7QZbZKFvH2gS/Hj5rchBPAHzno9IjQ1IQxSt5V750m/y1lGY9FSXWBRhFiPowaUJnDChtlogOgLJimAaueibNXR+MdXaYrK3QwbfUkI2dS2ThJ11T1wDSCsONyNmV0LC6TJH37sHPJwCIQectYPGEgRvVm28tmrf7/SfMZPF5DLFGRXUsr1bAaIpGQBovxtPC6EcfDsJFd8K+i3+eqQAolgyUzzn8hwoypQZYJXO9x8SyOqkKB5/FzRIZD8HgYtcv8eFZ3ACjm/Wm8ALJyCfOu4bKjIXZuASnsJSXHGQrVbn7y2NKpNsWwPVeq0ufUY9pM7ZwuN+48F3dvQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=variscite.com; Received: from AS2PR08MB8808.eurprd08.prod.outlook.com (2603:10a6:20b:5f4::14) by AS8PR08MB7353.eurprd08.prod.outlook.com (2603:10a6:20b:444::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.20; Wed, 12 Jul 2023 23:58:12 +0000 Received: from AS2PR08MB8808.eurprd08.prod.outlook.com ([fe80::88d8:ddec:561b:c061]) by AS2PR08MB8808.eurprd08.prod.outlook.com ([fe80::88d8:ddec:561b:c061%6]) with mapi id 15.20.6565.028; Wed, 12 Jul 2023 23:58:12 +0000 Message-ID: <2dff1a09-3c4e-e4f0-5825-b5ff4d1ecd10@variscite.com> Date: Wed, 12 Jul 2023 18:58:06 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 2/2] dt-bindings: add device tree bindings for mxl-8611x PHY Content-Language: en-US From: Nate Drude To: Joe Hershberger , Ramon Fried , Michal Simek , Marek Vasut , u-boot@lists.denx.de Cc: Eran Matityahu References: <05c50729-f70d-6cb0-bf8b-95008e6cce50@variscite.com> <7434d330-6c84-5fee-71a3-f207967c8854@variscite.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: CH0PR07CA0009.namprd07.prod.outlook.com (2603:10b6:610:32::14) To AS2PR08MB8808.eurprd08.prod.outlook.com (2603:10a6:20b:5f4::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS2PR08MB8808:EE_|AS8PR08MB7353:EE_ X-MS-Office365-Filtering-Correlation-Id: 5de8908a-da9e-44b5-fd63-08db8333d9a4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pp0kBs7obA5ObwTDfSxbImoNZvEdPzFqXCmTABFD5QExjLq9QY0Qdpfp4T73CZ3t7PU+S0pAbdG+ExE9vljVCrvuev23UJ0nKzdKps9adNX+AOjKs36ieH9TFu+1LkGWeNVOfDgUYg0kiRvtOVRQsZDSqEY7b1KiGKdYSKdR10CNzOMn9IptPXf7IBs/ApiX3tEJsCj4PFO7ITT3Vm3V1IZVjqdW2aS3RGIBktL1AJuQU1P3xLGc4kw7F0B0+F5xAX4iljujaFO3bOafGE5teQHSP8kC6tDvnXSHOeZ7zoanB8/oe6rVO0VkgOvKj175byAUmuNaRHV3dLVjFYHx2YcrzFkCceylggUV5yG5yGcrFYeOIHkhpFcco3zPsiLDNvPMoHjD5VSwCE1panEEV7dJop1oPln/qJCXt1StDjHDyZK+/ScNN/EVhyG279jm8aYaAKBBmojv5Jhv6GsavyFp5ndKBf1ZMc02vQFvIQ9bwBvtUOmSVVsXVqST6F/tvhPhY424TP4A/G718J8lrFeSYfld2/YLRqGgY2C2hdWX8CS0G8f61MBNeJ31mXM0DA/9uE0q6rjP//NC3aULEYT8obo6OCbmFck6dfHbyUdEcErCMTWx8Vr46xGkl28cJoierTVbkfS2fx/ssws1jA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS2PR08MB8808.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(39850400004)(396003)(376002)(366004)(136003)(346002)(451199021)(316002)(110136005)(186003)(31686004)(478600001)(41300700001)(6486002)(66476007)(66556008)(4326008)(6512007)(6666004)(66946007)(8936002)(8676002)(107886003)(5660300002)(53546011)(86362001)(31696002)(26005)(6506007)(83380400001)(36756003)(2616005)(2906002)(38100700002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cWRaYzdxdEtLMlJha2tFb3VQOURTQVhFbTN6SFkzY1NVT0lBQnNHWStUVXV3?= =?utf-8?B?YXhrSkJGaXZWZGxiTVFCWm01THNRN2xyVm5xaU5uVVV2K05pbEdYNGtVbExP?= =?utf-8?B?UFpEOC9iQkViZXp6RnZma0poZXhjRWRIazNqVDJvRldJU2NsMzNIV1ZmM3B4?= =?utf-8?B?WDZrSXZhZUQ5YzZYbm1rSlBJQ09ZeUlWVTJsS1JwR0Z2YzdaL1dyQXVvZ1Fp?= =?utf-8?B?OUVLck5VU2lRa3VnUnR5OFdzN3ZKSVhQOEdpSW5xZGE4bVZzTnJaL2xjRVht?= =?utf-8?B?K29seC82SzlLVUJlV29FajZEVFVITS9iUC95bWI5eEp3VUROUU5uU3crTGQ2?= =?utf-8?B?cW5pTVJDZlJ3OWl1bGk4RmFJb3lrY0RQVklCdlhteEVheDVHbGdlNDcrTE5r?= =?utf-8?B?RVBGS3pNOFJGU2lzL0ZTVWtWWjRiTVZNSGY1Q2dyOHNKajg5UWtrOUgrRUt0?= =?utf-8?B?THhPc0k2S3dsNUlXcDBtYk9oVTZBbnBrNTBZQ2hXYlBSVCtRTHkvUzFEZkRZ?= =?utf-8?B?aWUxMWw1WURZdGJqSmpnOHhRbVUxYUgrM0xJcmxnNWpuQjFuYVBYVnBxcklH?= =?utf-8?B?Wkg0SzNCR0tsUUNyaTVZV0c1cGRtTktQa1haWURKbVRuYmdubUNkS1ZqeWZR?= =?utf-8?B?aFl2eDMxNGRGNkc4ZERnaGlnSmVVUHFwY0xnWElLekpDeFE0ZUtRUkxtOWhZ?= =?utf-8?B?Y0FhQlNtWHllR0xyRXdicHpQSFhFOXhWL2VzalZXM21vOGFoNnVKWTBTN01x?= =?utf-8?B?Z0djcmhCbFA0WFZRVVZlQnRyVjhORnZKNzQ1T01DaTl4UjdIYWVPemVlTHA2?= =?utf-8?B?Snh2OFdKNU1NNndYbmY2b0hFbnBDWkIwZnBVbVRWdXRUeW1SUDdzR2tkQVRn?= =?utf-8?B?d3NoSjlxWkRqbUJDK2tXREVPaUdCWXNaQmNIQ2cvUnlsc25DZGdaandvVnBI?= =?utf-8?B?em10dGNsZkxhdG1Cb0ZOamtEdVkxdjByZ0FiYm8yUXJGdThWTnAwUm1VR3hv?= =?utf-8?B?Sm5ySU5tL2l1Umc2RUFOUnJVR1VBOFRTN1RuU1JhditNaGZ2Qlc4cStDcXpa?= =?utf-8?B?aUZGK2xSbUMxOGhvMkdYRkhqeWFUUUZLN1BPd1lEL1gyWmVQNUZFVnkwYzZv?= =?utf-8?B?eGo1Qm0ySkIxS3dTblh2SVI3eWlFeG1kYTRSRktWYnpSeUtCZVZsM0N3b2hB?= =?utf-8?B?cjJ2K2RNckcvaXBhbk1rR0xUNXl2UW9RNUt0aFhTZktRZ1JHYVl3RXJiWWlh?= =?utf-8?B?dTc2azJDYkZxUDkrdXFkWFBTRXNDNHgyN1pCeDR5SzgrQVVkSGw0bmo3c045?= =?utf-8?B?RStPL000UHNOdFdkeDhvc3Jyc2lOeU5XbHF5eVNGTUNqTTQ3TDJJQ3padUdm?= =?utf-8?B?UFJkUGpFWmFBenUyVTJuVFRuN21ncGtrd0dCc3h6VENlSWl5VGVib2RLUXBO?= =?utf-8?B?OTcvQ1dlb3hNVndtNi9ORlVMM3VETzkvVDc0WWFKNlB5SEdxbEFiUW50eitF?= =?utf-8?B?T09KU25qWWUxajFwbnNHb1RpNmhzU3lPKzRVT1RtSk1VNHdzc0QyT2tZWFZU?= =?utf-8?B?TWhuQjg4WFZEbmtEZDhLaUR6M2QvejJVUDBoSmlyT053eFZBWkYwTEhYRVNT?= =?utf-8?B?OXBMM2g3VkZPQzZ0d2lpTkdCdHl0eldERjIrdXJBV29RaTI3UkxXaG82MzFk?= =?utf-8?B?aEhSS1d1b2RreEF6azNEVk9ZVEg2UG13dEZZeEVPVERnYlVmbGhyUE5hY21C?= =?utf-8?B?T2N2MjI0eGNjWStkL1NhNXZqSHFtTHUyc2QvNGRhOFpQaDZYRUZFeTROWnRp?= =?utf-8?B?QThuNzdZTnRYelNYRmxSVm5id3UrN0VLS3c3VGRGL3B6YlZ4TmFSajBueW9l?= =?utf-8?B?RGhueUt1cXNYZTd2aWdjL3I0NDE4OUROTm1Rcy9NTE1WeUoydUFOS2RrYVBT?= =?utf-8?B?SXplZXBnODZLdHM2M2loYy95VTJZZW5STkVhS2hUdTQ5QlE4aXB0LzBpNThu?= =?utf-8?B?djZuRjY5Zk1sN1FrZXF5SHp1aGRON1p1VGRwc2N1b1crRzFNRjRNUDFLVG1N?= =?utf-8?B?aERKcVFjRE52bmtGSWloMjhyRXdLVEwzUDhmSUg0RTFOSkxkYzFibFRhZkhT?= =?utf-8?Q?VefWYNgNzBcfyoeDH3w2EVevC?= X-OriginatorOrg: variscite.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5de8908a-da9e-44b5-fd63-08db8333d9a4 X-MS-Exchange-CrossTenant-AuthSource: AS2PR08MB8808.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2023 23:58:12.4278 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 399ae6ac-38f4-4ef0-94a8-440b0ad581de X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pvI7NUy3qkZpKZftJWFWtmlQo2qN7oTIjZpurZJpRcS/utDZ2qD8RjTRMMroWClYTtPFvL9P2l+Z0uCM/cYj9A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7353 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 7/12/23 3:50 PM, Nate Drude wrote: > The MXL8611X driver has custom bindings for configuring the LEDs > and RGMII internal delays. This patch adds the documentation and > defines necessary to configure it from the device tree. > > Signed-off-by: Nate Drude > --- >  .../net/phy/mxl-8611x.txt                     | 37 +++++++++++++++++++ >  include/dt-bindings/net/mxl-8611x.h           | 27 ++++++++++++++ >  2 files changed, 64 insertions(+) >  create mode 100644 doc/device-tree-bindings/net/phy/mxl-8611x.txt >  create mode 100644 include/dt-bindings/net/mxl-8611x.h > > diff --git a/doc/device-tree-bindings/net/phy/mxl-8611x.txt > b/doc/device-tree-bindings/net/phy/mxl-8611x.txt > new file mode 100644 > index 00000000000..462fdf61666 > --- /dev/null > +++ b/doc/device-tree-bindings/net/phy/mxl-8611x.txt > @@ -0,0 +1,37 @@ > +* MaxLinear MXL8611x PHY Device Tree binding > + > +Required properties: > +- reg: PHY address > + > +Optional properties: > +- mxl-8611x,ledN_cfg: Register configuration for COM_EXT_LED0_CFG, > +    COM_EXT_LED1_CFG, and COM_EXT_LED2_CFG > +- mxl-8611x,rx-internal-delay-ps: RGMII RX Clock Delay used only when > PHY operates > +    in RGMII mode with internal delay (phy-mode is 'rgmii-id' or > +    'rgmii-rxid') in pico-seconds. > +- mxl-8611x,tx-internal-delay-ps-100m: RGMII TX Clock Delay used only > when PHY operates > +    in 10/100M RGMII mode with internal delay (phy-mode is 'rgmii-id' or > +    'rgmii-txid') in pico-seconds. > +- mxl-8611x,tx-internal-delay-ps-1g: RGMII TX Clock Delay used only > when PHY operates > +    in 1G RGMII mode with internal delay (phy-mode is 'rgmii-id' or > +    'rgmii-txid') in pico-seconds. > + > +Example: > + > +    ethernet-phy@0 { > +        reg = <0>; > + > +        mxl-8611x,led0_cfg = <( > +            MXL8611X_LEDX_CFG_LINK_UP_RX_ACT_ON | > +            MXL8611X_LEDX_CFG_LINK_UP_TX_ACT_ON | > +            MXL8611X_LEDX_CFG_TRAFFIC_ACT_BLINK_IND > +        )>; > +        mxl-8611x,led1_cfg = <( > +            MXL8611X_LEDX_CFG_LINK_UP_10MB_ON | > +            MXL8611X_LEDX_CFG_LINK_UP_100MB_ON | > +            MXL8611X_LEDX_CFG_LINK_UP_1GB_ON > +        )>; > +        mxl-8611x,rx-internal-delay-ps = <0>; > +        mxl-8611x,tx-internal-delay-ps-100m = <2250>; > +        mxl-8611x,tx-internal-delay-ps-1g = <150>; > +    }; > diff --git a/include/dt-bindings/net/mxl-8611x.h > b/include/dt-bindings/net/mxl-8611x.h > new file mode 100644 > index 00000000000..cb0ec0f8bd0 > --- /dev/null > +++ b/include/dt-bindings/net/mxl-8611x.h > @@ -0,0 +1,27 @@ > +/* SPDX-License-Identifier: (GPL-2.0+ OR MIT) */ > +/* > + * Device Tree constants for MaxLinear MXL8611x PHYs > + * > + * Copyright 2023 Variscite Ltd. > + * Copyright 2023 MaxLinear Inc. > + */ > + > +#ifndef _DT_BINDINGS_MXL_8611X_H > +#define _DT_BINDINGS_MXL_8611X_H > + > +#define MXL8611X_LEDX_CFG_TRAFFIC_ACT_BLINK_IND        (1 << 13) > +#define MXL8611X_LEDX_CFG_LINK_UP_FULL_DUPLEX_ON    (1 << 12) > +#define MXL8611X_LEDX_CFG_LINK_UP_HALF_DUPLEX_ON    (1 << 11) > +#define MXL8611X_LEDX_CFG_LINK_UP_TX_ACT_ON        (1 << 10) > +#define MXL8611X_LEDX_CFG_LINK_UP_RX_ACT_ON        (1 << 9) > +#define MXL8611X_LEDX_CFG_LINK_UP_TX_ON            (1 << 8) > +#define MXL8611X_LEDX_CFG_LINK_UP_RX_ON            (1 << 7) > +#define MXL8611X_LEDX_CFG_LINK_UP_1GB_ON        (1 << 6) > +#define MXL8611X_LEDX_CFG_LINK_UP_100MB_ON        (1 << 5) > +#define MXL8611X_LEDX_CFG_LINK_UP_10MB_ON        (1 << 4) > +#define MXL8611X_LEDX_CFG_LINK_UP_COLLISION        (1 << 3) > +#define MXL8611X_LEDX_CFG_LINK_UP_1GB_BLINK        (1 << 2) > +#define MXL8611X_LEDX_CFG_LINK_UP_100MB_BLINK        (1 << 1) > +#define MXL8611X_LEDX_CFG_LINK_UP_10MB_BLINK        (1 << 0) > + > +#endif I mistakenly sent the mxl-8611x patch series In-Reply-To my previous adin patch. Is this okay, or should I resend the mxl-8611x patches? Thanks, Nate