From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD5F8C7EE29 for ; Sat, 10 Jun 2023 11:55:35 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id F402984688; Sat, 10 Jun 2023 13:55:32 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=mailbox.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; secure) header.d=mailbox.org header.i=@mailbox.org header.b="Y8uUdJ82"; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b="WqIhBRuF"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9DAB3846E1; Sat, 10 Jun 2023 13:55:30 +0200 (CEST) Received: from mout-p-103.mailbox.org (mout-p-103.mailbox.org [IPv6:2001:67c:2050:0:465::103]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id EE37484678 for ; Sat, 10 Jun 2023 13:55:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=mailbox.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=marek.vasut@mailbox.org Received: from smtp102.mailbox.org (smtp102.mailbox.org [10.196.197.102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4QdbxC5zgsz9sTr; Sat, 10 Jun 2023 13:55:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1686398127; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Qc6HJ7T5xRvlSE2jS46EDa9T6jBBokLhE8ru6chKWTg=; b=Y8uUdJ82Ps3ivf6WP9zlnDz1OL5NZVQlju0E9Y7OPZD0ywzFQwDrWn+J3Bej+BRzsMwZ7L KQrLTyvsDOP6z7PwhVsmcYgYbyPD8R4w52FgXaypNSHkKbI+l20cXfO+2xAjdPHlwYVtR0 H2+YFADtZSha3gjtdHpOxTb2XDUAdt6N4myx1FcHWY3b5wcvDgbyl/UINDbVl782taKNRi RduzSaWT4Q56XK5rzuBhZcsDxfytZIy7pBjowD7EATpxBEoQaJ+hufERRxOJsPpyM/QryT y8zGRnXCAkW1gT00gHlPgYDSlhVkFyd+F4OZAxCtvs8hUaFaajlB7YrybzFiVA== Message-ID: <2ead8887-0e2f-57be-61bb-e3e031b7b6d9@mailbox.org> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1686398126; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Qc6HJ7T5xRvlSE2jS46EDa9T6jBBokLhE8ru6chKWTg=; b=WqIhBRuFQtjZYxqcFHAS802Poz/W2ZNy7I9IIZvFfekd9sVDd+v0jspMmFJF49WvSHzW6c 1GvGx69hFIkgIfnh+r/fq9mSdnooDt+WJJRxgswODNz8ueBSwGdzB956lqE+fBmJrWMPDW IKm9hb2FGzVEqKVcEVKGxt7iyN1mrh5ay9HMTgwZvPevlh2KxmXEXGq8Zc9cQpr5s1BtTl p73ACjy/WQaOgRUsv3NPejNOLCH5RZ1I7eDdvPQGHQ2GyZ9TDTO0BLEZi1+qOdTEiu2Moy NDLLfs+MoDtKNUX0x4wzs5tW+H7oVvelYPyC3Cbi56Xo78hWTuBa3FSHiqrFCg== Date: Sat, 10 Jun 2023 13:55:24 +0200 MIME-Version: 1.0 Subject: Re: [PATCH 1/2] renesas: rcar3: Expose the board id in sysinfo To: Detlev Casanova , u-boot@lists.denx.de Cc: Marek Vasut , Hai Pham , Tam Nguyen References: <20230609160016.128417-1-detlev.casanova@collabora.com> <20230609160016.128417-2-detlev.casanova@collabora.com> Content-Language: en-US From: Marek Vasut In-Reply-To: <20230609160016.128417-2-detlev.casanova@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-MBO-RS-ID: 779ab0bef41d6fa28ed X-MBO-RS-META: b9qy5i5snzd7xm4qfwufjba1d787rpoy X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 6/9/23 18:00, Detlev Casanova wrote: > This is a preparation commit for selecting the correct device tree name > to be loaded depending on the board id. I am not opposed to this patch itself (with a few tweaks, see below), but please see 2/2, I suspect this method of selecting the DT is not gonna work. > Signed-off-by: Detlev Casanova > --- > drivers/sysinfo/rcar3.c | 31 ++++++++++++++++++------------- > drivers/sysinfo/rcar3.h | 21 +++++++++++++++++++++ > 2 files changed, 39 insertions(+), 13 deletions(-) > create mode 100644 drivers/sysinfo/rcar3.h > > diff --git a/drivers/sysinfo/rcar3.c b/drivers/sysinfo/rcar3.c > index 7b127986da7..4252f8d452c 100644 > --- a/drivers/sysinfo/rcar3.c > +++ b/drivers/sysinfo/rcar3.c > @@ -7,24 +7,12 @@ > #include > #include > #include > -#include > +#include "rcar3.h" > > #define BOARD_CODE_MASK 0xF8 > #define BOARD_REV_MASK 0x07 > #define BOARD_CODE_SHIFT 0x03 > > -#define BOARD_SALVATOR_X 0x0 > -#define BOARD_KRIEK 0x1 > -#define BOARD_STARTER_KIT 0x2 > -#define BOARD_EAGLE 0x3 > -#define BOARD_SALVATOR_XS 0x4 > -#define BOARD_CONDOR 0x6 > -#define BOARD_DRAAK 0x7 > -#define BOARD_EBISU 0x8 > -#define BOARD_STARTER_KIT_PRE 0xB > -#define BOARD_EBISU_4D 0xD > -#define BOARD_CONDOR_I 0x10 > - > /** > * struct sysinfo_rcar_priv - sysinfo private data > * @boardname: board model and revision > @@ -32,6 +20,7 @@ > */ > struct sysinfo_rcar_priv { > char boardmodel[64]; > + u8 board_id; > u8 val; > }; > > @@ -42,6 +31,19 @@ static int sysinfo_rcar_detect(struct udevice *dev) > return priv->val == 0xff; > } > > +static int sysinfo_rcar_get_int(struct udevice *dev, int id, int *val) > +{ > + struct sysinfo_rcar_priv *priv = dev_get_priv(dev); > + > + switch (id) { > + case SYSINFO_ID_BOARD_MODEL: > + *val = priv->board_id; > + return 0; > + default: > + return -EINVAL; > + }; > +} > + > static int sysinfo_rcar_get_str(struct udevice *dev, int id, size_t size, char *val) > { > struct sysinfo_rcar_priv *priv = dev_get_priv(dev); > @@ -59,6 +61,7 @@ static int sysinfo_rcar_get_str(struct udevice *dev, int id, size_t size, char * > static const struct sysinfo_ops sysinfo_rcar_ops = { > .detect = sysinfo_rcar_detect, > .get_str = sysinfo_rcar_get_str, > + .get_int = sysinfo_rcar_get_int, > }; > > static void sysinfo_rcar_parse(struct sysinfo_rcar_priv *priv) > @@ -68,6 +71,8 @@ static void sysinfo_rcar_parse(struct sysinfo_rcar_priv *priv) > bool salvator_xs = false; > bool ebisu_4d = false; > bool condor_i = false; > + > + priv->board_id = board_id; > char rev_major = '?'; > char rev_minor = '?'; > > diff --git a/drivers/sysinfo/rcar3.h b/drivers/sysinfo/rcar3.h > new file mode 100644 > index 00000000000..21ae918d9bb > --- /dev/null > +++ b/drivers/sysinfo/rcar3.h > @@ -0,0 +1,21 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * Copyright (C) 2023 Detlev Casanova > + */ > + > +#include This should not be here, the header is using nothing from sysinfo.h Also, this rcar3.h header should be in arch/arm/mach-rmobile/include/mach/ and potentially just part of sys_proto.h . > +#define BOARD_SALVATOR_X 0x0 > +#define BOARD_KRIEK 0x1 > +#define BOARD_STARTER_KIT 0x2 > +#define BOARD_EAGLE 0x3 > +#define BOARD_SALVATOR_XS 0x4 > +#define BOARD_CONDOR 0x6 > +#define BOARD_DRAAK 0x7 > +#define BOARD_EBISU 0x8 > +#define BOARD_STARTER_KIT_PRE 0xB > +#define BOARD_EBISU_4D 0xD > +#define BOARD_CONDOR_I 0x10 > + > + > + Does ./scripts/checkpatch.pl complain about those three extra trailing newlines ?