From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ADC18C433F5 for ; Fri, 7 Oct 2022 12:37:46 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id AB2A584E7C; Fri, 7 Oct 2022 14:37:44 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="c+zB16aw"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6FEB084E7B; Fri, 7 Oct 2022 14:37:42 +0200 (CEST) Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C8E5484E7A for ; Fri, 7 Oct 2022 14:37:38 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jh80.chung@gmail.com Received: by mail-pj1-x1036.google.com with SMTP id l1-20020a17090a72c100b0020a6949a66aso4659862pjk.1 for ; Fri, 07 Oct 2022 05:37:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+TCZWo2TuDa/6MybhFdSCs/+V4XQWKxeDn/CsHQrays=; b=c+zB16awO5vw2d/9LAFljDnO61YToYQdyXVHLNPZn7m1RRY5/kd2oSmEwmhwIODsj2 L3JBk4Fm0BmQ/QZAljzh7L8UM137+2F3vVmfrcKhw3cg2GB/T/RPaeHtcKPco39deehn 4QSztruIiYMVZUP+jioNFfD2Z9ZZDyLMSZX0f7EzGuHTEe+qw28BQbWUfIc0qTseiJgJ TzQPbG7jGjqoPyduFTJnZkUiqG2WCJ5tNrIbm5kC0OyXaFqCBo7TJGhjOVfBjVGFYr9n xxlYHesKqAGphKJJyNZwEP8+Bss10eIxc5oPG7Vqz60miB4sXlObGOoij0GhmObZ2nQq S1TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+TCZWo2TuDa/6MybhFdSCs/+V4XQWKxeDn/CsHQrays=; b=l7OLF5MGY1HvmspvqpUcIFjTiU6ih+FgGqO6SBX8ujHrtYSYgAR1UATMnarK+1+yiq IWMnJrY6hEoVkdCe8kTqF3R550SJnESE+kSBDaqtA1Y8cEafVGSgWoXn/B6GbbFnEl23 95zAm0OtcUqg4GvWi/U7MJvJtY3Z7qKq0vhA7dfe/ys2wV541ZcwWd7g5jPyOeiW/unv OXfuF3kNYb/dA4FSIM6eHizYKwYsSVWyuV8j1bPsMPsGT3bD2EJw69VXIbQDMqm1ALBi sn0kVWyVD5ZLrl+l5I3ioKisikQyv9AEs0yBM8n/+9c/UaDJW4ccwT4yBqPkwoO/nVsZ OfUA== X-Gm-Message-State: ACrzQf1ECXrnhJzD7ZTqrpZjz8sqNea1G3o/gM1RTMbGhrfTmSw9jsuZ gc86eWYbSQ2vzBUc1OukKIU= X-Google-Smtp-Source: AMsMyM7sxtNB48KAv8zH6F7FvsXMMECf5ZJzgTUkTW2RBT9ZuLRLSn3bKr6cHkQ9egOmVpQ/IJirOw== X-Received: by 2002:a17:902:9a8b:b0:17a:455:d967 with SMTP id w11-20020a1709029a8b00b0017a0455d967mr4820276plp.52.1665146257135; Fri, 07 Oct 2022 05:37:37 -0700 (PDT) Received: from [192.168.0.19] ([183.99.112.216]) by smtp.gmail.com with ESMTPSA id e21-20020aa79815000000b00561b94ee263sm1486202pfl.109.2022.10.07.05.37.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Oct 2022 05:37:36 -0700 (PDT) Message-ID: <2eb41e26-6429-6ec2-8ed8-08d65a25e1ba@gmail.com> Date: Fri, 7 Oct 2022 21:37:33 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH] mmc: fsl_esdhc: fix problem when using clk driver Content-Language: en-US To: Marek Vasut , u-boot@lists.denx.de Cc: Ye Li , Fabio Estevam , Jaehoon Chung , Marcel Ziswiler , Max Krummenacher , Peng Fan , Stefano Babic References: <20220923222933.640838-1-marex@denx.de> From: Jaehoon Chung In-Reply-To: <20220923222933.640838-1-marex@denx.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 9/24/22 07:29, Marek Vasut wrote: > From: Ye Li > > Move init_clk_usdhc to non-clk driver case, since assigned-clocks properties > will initialize the clocks by clk driver. > > Signed-off-by: Ye Li > Signed-off-by: Marek Vasut Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > NOTE: Was MLK-21848-5 fsl_esdhc: fix problem when using clk driver > NOTE: Fixes SD SDR104 mode instability on MX8MP > --- > Cc: Fabio Estevam > Cc: Jaehoon Chung > Cc: Marcel Ziswiler > Cc: Max Krummenacher > Cc: Peng Fan > Cc: Stefano Babic > --- > drivers/mmc/fsl_esdhc_imx.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/fsl_esdhc_imx.c b/drivers/mmc/fsl_esdhc_imx.c > index 9befb190bdf..92b152fc979 100644 > --- a/drivers/mmc/fsl_esdhc_imx.c > +++ b/drivers/mmc/fsl_esdhc_imx.c > @@ -1519,8 +1519,6 @@ static int fsl_esdhc_probe(struct udevice *dev) > * work as expected. > */ > > - init_clk_usdhc(dev_seq(dev)); > - > #if CONFIG_IS_ENABLED(CLK) > /* Assigned clock already set clock */ > ret = clk_get_by_name(dev, "per", &priv->per_clk); > @@ -1536,6 +1534,8 @@ static int fsl_esdhc_probe(struct udevice *dev) > > priv->sdhc_clk = clk_get_rate(&priv->per_clk); > #else > + init_clk_usdhc(dev_seq(dev)); > + > priv->sdhc_clk = mxc_get_clock(MXC_ESDHC_CLK + dev_seq(dev)); > if (priv->sdhc_clk <= 0) { > dev_err(dev, "Unable to get clk for %s\n", dev->name);