public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, PATCHv3, 1/4] dm: MIGRATION: Add migration plan for DM_MMC
Date: Thu, 20 Dec 2018 22:20:14 +0100	[thread overview]
Message-ID: <2f7276fe-179a-e387-d9fa-03f956882ca7@gmail.com> (raw)
In-Reply-To: <CAPnjgZ3-bc9CbVC7ORy_OKu05Ta0Faf1H6tON3rrQXFNcTczag@mail.gmail.com>

Am 20.12.2018 um 22:17 schrieb Simon Glass:
> Hi Simon,
> 
> On Thu, 13 Dec 2018 at 22:15, Simon Goldschmidt
> <simon.k.r.goldschmidt@gmail.com> wrote:
>>
>>
>>
>> Am Fr., 14. Dez. 2018, 04:10 hat Simon Glass <sjg@chromium.org> geschrieben:
>>>
>>> Hi Simon,
>>>
>>> On Thu, 13 Dec 2018 at 02:45, Simon Goldschmidt
>>> <simon.k.r.goldschmidt@gmail.com> wrote:
>>>>
>>>> Hi Tom,
>>>>
>>>> On Tue, Dec 4, 2018 at 5:51 AM Tom Rini <trini@konsulko.com> wrote:
>>>>>
>>>>> On Thu, Nov 29, 2018 at 06:21:11PM -0500, Tom Rini wrote:
>>>>>
>>>>>> Given that at this point the MMC subsystem itself has been migrated
>>>>>> along with a number of subsystem drivers, formalize a deadline for
>>>>>> migration.
>>>>>>
>>>>>> Reviewed-by: Simon Glass <sjg@chromium.org>
>>>>>> Cc: Jaehoon Chung <jh80.chung@samsung.com>
>>>>>> Signed-off-by: Tom Rini <trini@konsulko.com>
>>>>>> Reviewed-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
>>>>>> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
>>>>>
>>>>> Applied to u-boot/master, thanks!
>>>>
>>>> I have finally found the time to test current mainline on all our
>>>> board configs and now I still get the warning "This board does not use
>>>> CONFIG_DM_MMC". Supposedly this is because I have CONFIG_BLK disabled
>>>> (because of size limitations: this U-Boot image runs from FPGA and
>>>> just configures the eMMC without loading files from it).
>>>>
>>>> Would it make sense to change the test like this:
>>>>
>>>> diff --git a/Makefile b/Makefile
>>>> index 0d11ff9797..41bde15b74 100644
>>>> --- a/Makefile
>>>> +++ b/Makefile
>>>> @@ -920,7 +920,7 @@ ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y)
>>>>          @echo "before sending patches to the mailing list."
>>>>          @echo "===================================================="
>>>>   endif
>>>> -ifeq ($(CONFIG_MMC),y)
>>>> +ifeq ($(CONFIG_MMC)$(CONFIG_BLK),yy)
>>>>   ifneq ($(CONFIG_DM_MMC)$(CONFIG_OF_CONTROL)$(CONFIG_BLK),yyy)
>>>>          @echo "===================== WARNING ======================"
>>>>          @echo "This board does not use CONFIG_DM_MMC. Please update"
>>>>
>>>> Is it intentional that CONFIG_BLK needs to be enabled?
>>>
>>> Yes it is, unless you don't actually use block devices. What is the
>>> goal of initing eMMC without using it?
>>
>>
>> We're only initializing pSLC mode in that configuration. The boot flow is via tftp. I know this might be a rare use case but I'm more or less forced to disable block devices because I only have ~200KiB for U-Boot when running from FPGA.
> 
> Maybe disabling HAVE_BLOCK_DEVICE would provide a means to avoid the warning?

Hmm, it might well be that I haven't disabled everything I can in that 
config. I'll check that next year ;-)

Regards,
Simon

      reply	other threads:[~2018-12-20 21:20 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-29 23:21 [U-Boot] [PATCHv3 1/4] dm: MIGRATION: Add migration plan for DM_MMC Tom Rini
2018-11-29 23:21 ` [U-Boot] [PATCHv3 2/4] dm: MIGRATION: Add migration plan for DM_USB Tom Rini
2018-12-04  4:49   ` [U-Boot] [U-Boot, PATCHv3, " Tom Rini
2018-12-05  7:14     ` Stefan Roese
2018-12-05 12:23       ` Tom Rini
2018-12-07  0:05         ` Chris Packham
2018-12-07  1:19           ` Tom Rini
2018-11-29 23:21 ` [U-Boot] [PATCHv3 3/4] dm: MIGRATION: Add migration plan for CONFIG_SATA Tom Rini
2018-12-04  4:49   ` [U-Boot] [U-Boot, PATCHv3, " Tom Rini
2018-11-29 23:21 ` [U-Boot] [PATCHv3 4/4] dm: MIGRATION: Update migration plan for BLK Tom Rini
2018-12-04  4:49   ` [U-Boot] [U-Boot, PATCHv3, " Tom Rini
2018-11-30  8:10 ` [U-Boot] [PATCHv3 1/4] dm: MIGRATION: Add migration plan for DM_MMC Simon Goldschmidt
2018-11-30  8:50   ` Philipp Tomsich
2018-12-04  4:49 ` [U-Boot] [U-Boot, PATCHv3, " Tom Rini
2018-12-13  9:45   ` Simon Goldschmidt
2018-12-14  3:10     ` Simon Glass
2018-12-14  5:14       ` Simon Goldschmidt
2018-12-20 21:17         ` Simon Glass
2018-12-20 21:20           ` Simon Goldschmidt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2f7276fe-179a-e387-d9fa-03f956882ca7@gmail.com \
    --to=simon.k.r.goldschmidt@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox