From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7BA1C46467 for ; Wed, 4 Jan 2023 11:18:30 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B983085174; Wed, 4 Jan 2023 12:18:28 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="oCdjKEyC"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id EF2FA851DF; Wed, 4 Jan 2023 12:18:26 +0100 (CET) Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3CE4A84231 for ; Wed, 4 Jan 2023 12:18:24 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=frattaroli.nicolas@gmail.com Received: by mail-wr1-x42a.google.com with SMTP id bs20so30493922wrb.3 for ; Wed, 04 Jan 2023 03:18:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=r4jG9i+Rp1oaP95dYbOYagTP+QdceQyKoYYJTETQqNc=; b=oCdjKEyCahKhfZTrJ5Ce4Ei1LXnNlLcMuu93o4ah1m1lA0TOylGFHcH0GWS70qFcwD e1hQ0xoBKK6HuWlq0GV7MvWLO+wkayLjMVSdljGiG/NE6wCMoxMaagHt5ZrHrqDQIP/T esvbt4KEt0bvqm0A6Oac20n1vYTC52pm5v5zn2st1xE/PqqxRoO4Z413tdFHQwBHGuv0 WPoGIKkhyjNSJ0KC5Tyyy/GtLUDY/Fc1gM4ykpCT3DpJEqsSSkAy9rbxp1AmFMU5rD+h 6raxGdusygGFPH1HytA0CJm/17/HUHvI8lNgaaqFV0sFFzKZ/ZAPb15INSIvkWni3+d1 zBPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=r4jG9i+Rp1oaP95dYbOYagTP+QdceQyKoYYJTETQqNc=; b=l9W6juE0JOeiPsq06tbXFjXf1js0n3iz0/2/8BjfN3RpcSh+ZYI3MwbCllv8Kn+Zqw oT1loyh5WDnFfoBRlgT5K59tiNrmiPSlL5CctCGSN/W/gkcge4YvuKQMlYcJNMgXnv9m fu6dm6AuG7Sde7/K/LtAU0RJ1n/WRXVHfglDaC/LB/lKCALkOBRdgA/CgGcwatZqkNlZ 5LSwHpfzcvNi5dTXDf7+51zUCOegq90v5IDJiY8jiV98jgYVw3aw3Ts1Ylk7/39ptuyp KKr8LgtQKH4ZolSItP9E8GJmMzBqqX5IFTlJ7kBaXICnZ1iMA1FdMJBuVo7O7sBd6Rkd SIGA== X-Gm-Message-State: AFqh2ko2aW5LCB2peGjyDcEPeL8Tr1loYuYFUwAZjzNvYpleHlZNpjp+ Vi57GZlXacNN15zlDacya/M= X-Google-Smtp-Source: AMrXdXur38oIAaEjUFUm0FRpy1ZYhKYnLJ+rLKAu+hbz9Bisi0tUuf3u9vvzGyh610ZOIIgkdodx+A== X-Received: by 2002:adf:cd8c:0:b0:271:dd0c:866b with SMTP id q12-20020adfcd8c000000b00271dd0c866bmr25238610wrj.1.1672831103700; Wed, 04 Jan 2023 03:18:23 -0800 (PST) Received: from archbook.localnet (84-72-105-84.dclient.hispeed.ch. [84.72.105.84]) by smtp.gmail.com with ESMTPSA id t15-20020a5d534f000000b002365254ea42sm33791613wrv.1.2023.01.04.03.18.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Jan 2023 03:18:23 -0800 (PST) From: Nicolas Frattaroli To: Simon Glass , Philipp Tomsich , Kever Yang Cc: u-boot@lists.denx.de Subject: Re: [PATCH] rockchip: rk3328: Set VOP QoS to high priority Date: Wed, 04 Jan 2023 12:18:22 +0100 Message-ID: <3048031.aZSOJHIV7L@archbook> In-Reply-To: <31442545.XjgUJs76Fk@archbook> References: <20220723112836.88814-1-frattaroli.nicolas@gmail.com> <31442545.XjgUJs76Fk@archbook> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Freitag, 21. Oktober 2022 14:30:39 CET Nicolas Frattaroli wrote: > On Samstag, 23. Juli 2022 13:28:36 CEST Nicolas Frattaroli wrote: > > The default priority for the quality of service for the video > > output results in unsightly glitches on the output whenever there > > is memory pressure on the system, which happens a lot. > > > > This sets the VOP QoS to high priority, which fixes this issue. > > > > Signed-off-by: Nicolas Frattaroli > > --- > > arch/arm/mach-rockchip/rk3328/rk3328.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/arch/arm/mach-rockchip/rk3328/rk3328.c b/arch/arm/mach-rockchip/rk3328/rk3328.c > > index de17b88682..2373586b14 100644 > > --- a/arch/arm/mach-rockchip/rk3328/rk3328.c > > +++ b/arch/arm/mach-rockchip/rk3328/rk3328.c > > @@ -19,6 +19,8 @@ DECLARE_GLOBAL_DATA_PTR; > > #define GRF_BASE 0xFF100000 > > #define UART2_BASE 0xFF130000 > > #define FW_DDR_CON_REG 0xFF7C0040 > > +#define QOS_VOP_OFFSET 0xFF760080 > > +#define QOS_VOP_PRIORITY 0x8 > > > > const char * const boot_devices[BROM_LAST_BOOTSOURCE + 1] = { > > [BROM_BOOTSOURCE_EMMC] = "/mmc@ff520000", > > @@ -54,6 +56,9 @@ int arch_cpu_init(void) > > > > /* Disable the ddr secure region setting to make it non-secure */ > > rk_setreg(FW_DDR_CON_REG, 0x200); > > +#else > > + printf("Setting VOP QoS\n"); > > + rk_setreg(QOS_VOP_OFFSET + QOS_VOP_PRIORITY, 0x2); > > #endif > > return 0; > > } > > > > Hello, > > could I get a review on this? > > Thank you for your time, > Nicolas Frattaroli It has been almost 6 months since patch submission now.