From: Ehsan Mohandesi <emohandesi@linux.microsoft.com>
To: Sergei Antonov <saproj@gmail.com>
Cc: u-boot@lists.denx.de, sjg@chromium.org, mario.six@gdsys.cc,
joe.hershberger@ni.com, rfried.dev@gmail.com, xypron.glpk@gmx.de,
ilias.apalodimas@linaro.org, masahisa.kojima@linaro.org,
pali@kernel.org, tobias@waldekranz.com, john@metanate.com,
v.v.mitrofanov@yadro.com
Subject: Re: [PATCH v4 1/3] net: ipv6: Add support for default gateway discovery.
Date: Fri, 5 May 2023 09:13:13 -0500 [thread overview]
Message-ID: <306f4064-77cc-0f4d-84fc-3c421da11669@linux.microsoft.com> (raw)
In-Reply-To: <CABikg9wwxV=qVd25iEjwJv2N4Qh_RVYH8+__gyhGNBbLsrEyLw@mail.gmail.com>
On 5/4/2023 9:52 AM, Sergei Antonov wrote:
> On Sat, 22 Apr 2023 at 03:08,<emohandesi@linux.microsoft.com> wrote:
>
>> + if (prefix->on_link && ntohl(prefix->valid_lifetime)) {
>> + net_prefix_length = prefix->prefix_len;
>> + net_gateway6 = ip6->saddr;
>> + return 0;
> Is it OK that prefix->prefix_len is used, but prefix->prefix is not?
> Just curious.
prefix->prefix is used just before this if statement to make sure it is
not a link-local address as shown below.
if((ntohs(prefix->prefix.s6_addr16[0]) & IPV6_LINK_LOCAL_MASK) ==
IPV6_LINK_LOCAL_PREFIX) break; if(prefix->on_link &&
ntohl(prefix->valid_lifetime)) { net_prefix_length = prefix->prefix_len;
net_gateway6 = ip6->saddr; return0; }
next prev parent reply other threads:[~2023-05-05 14:13 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-02 16:58 [PATCH] net: ipv6: Add support for default gateway discovery emohandesi
2023-03-16 8:47 ` Vyacheslav V. Mitrofanov
2023-03-23 16:44 ` Ehsan Mohandesi
2023-03-23 16:59 ` Vyacheslav V. Mitrofanov
2023-04-01 19:02 ` Ramon Fried
2023-04-10 19:34 ` [PATCH v2 0/4] Add IPv6 Network Discovery emohandesi
2023-04-10 19:34 ` [PATCH v2 1/4] Revert "net: ipv6: Add support for default gateway discovery." emohandesi
2023-04-11 7:01 ` Vyacheslav V. Mitrofanov
2023-04-11 14:51 ` Ehsan Mohandesi
2023-04-10 19:34 ` [PATCH v2 2/4] net: ipv6: Add support for default gateway discovery emohandesi
2023-04-10 19:34 ` [PATCH v2 3/4] test/py: IPv6 network discovery test emohandesi
2023-04-10 19:34 ` [PATCH v2 4/4] test: eth: IPv6 network discovery unit test emohandesi
2023-04-12 16:10 ` [PATCH v3 0/3] Add IPv6 Network Discovery emohandesi
2023-04-12 16:10 ` [PATCH v3 1/3] net: ipv6: Add support for default gateway discovery emohandesi
2023-04-20 13:44 ` Vyacheslav V. Mitrofanov
2023-04-12 16:10 ` [PATCH v3 2/3] test/py: IPv6 network discovery test emohandesi
2023-04-19 1:46 ` Simon Glass
2023-04-12 16:10 ` [PATCH v3 3/3] test: eth: IPv6 network discovery unit test emohandesi
2023-04-19 1:46 ` Simon Glass
2023-04-22 0:08 ` [PATCH v4 0/3] Add IPv6 Network Discovery emohandesi
2023-04-22 0:08 ` [PATCH v4 1/3] net: ipv6: Add support for default gateway discovery emohandesi
2023-04-24 7:58 ` Vyacheslav V. Mitrofanov
2023-04-24 8:03 ` Vyacheslav V. Mitrofanov
2023-05-04 14:30 ` Sergei Antonov
2023-05-04 14:52 ` Sergei Antonov
2023-05-05 14:13 ` Ehsan Mohandesi [this message]
2023-05-06 14:53 ` Tom Rini
2023-05-10 10:05 ` Sergei Antonov
2023-05-10 11:16 ` Vyacheslav V. Mitrofanov
2023-04-22 0:08 ` [PATCH v4 2/3] test/py: IPv6 network discovery test emohandesi
2023-04-24 7:59 ` Vyacheslav V. Mitrofanov
2023-05-06 14:53 ` Tom Rini
2023-04-22 0:08 ` [PATCH v4 3/3] test: eth: IPv6 network discovery unit test emohandesi
2023-04-24 8:01 ` Vyacheslav V. Mitrofanov
2023-05-06 14:53 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=306f4064-77cc-0f4d-84fc-3c421da11669@linux.microsoft.com \
--to=emohandesi@linux.microsoft.com \
--cc=ilias.apalodimas@linaro.org \
--cc=joe.hershberger@ni.com \
--cc=john@metanate.com \
--cc=mario.six@gdsys.cc \
--cc=masahisa.kojima@linaro.org \
--cc=pali@kernel.org \
--cc=rfried.dev@gmail.com \
--cc=saproj@gmail.com \
--cc=sjg@chromium.org \
--cc=tobias@waldekranz.com \
--cc=u-boot@lists.denx.de \
--cc=v.v.mitrofanov@yadro.com \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox