From: Quentin Schulz <quentin.schulz@cherry.de>
To: Patrice Chotard <patrice.chotard@foss.st.com>, u-boot@lists.denx.de
Cc: Patrick DELAUNAY <patrick.delaunay@foss.st.com>,
U-Boot STM32 <uboot-stm32@st-md-mailman.stormreply.com>,
Kory Maincent <kory.maincent@bootlin.com>,
Marek Vasut <marek.vasut+renesas@mailbox.org>,
Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH 02/23] board: st: Update LED management for stm32mp1
Date: Thu, 4 Dec 2025 16:38:04 +0100 [thread overview]
Message-ID: <309e316f-1be0-49bb-be93-609d8b29ccaa@cherry.de> (raw)
In-Reply-To: <20251114162417.4054006-3-patrice.chotard@foss.st.com>
Hi Patrice,
On 11/14/25 5:23 PM, Patrice Chotard wrote:
> Remove get_led() and setup_led() which became obsolete since
> led_boot_on() introduction. led_boot_on() is automatically called
> from board_r.c
>
Yes, but called later than board_init(). If this compromise is fine then
it's ok.
> Regarding "u-boot,error-led" property can't be used anymore since commit
> Since commit 516a13e8db32 ("led: update LED boot/activity to new property implementation")
>
> Instead get the LED labeled "red:status".
Would this work with stm32mp157a-dhcor-avenger96 (led4),
stm32mp157c-odyssey (red but not "status" as function?) and
stm32mp15xx-dhcom (error but possibly broken since commit
332facce6f5669fc1bb8d150c08cee2ebdae6d2b which removed the led with that
label)? Seems like Odissey has LED=y and LED_GPIO=y so it probably
worked before this patch? The other two, their defconfigs don't seem to
enable LED support (new or legacy) so I guess it never was used anyway?
I'm also wondering how you get this string... I don't see any label or
LED_FUNCTION_STATUS function for the LED devices on ST boards. I'm
probably missing on something?
Cheers,
Quentin
next prev parent reply other threads:[~2025-12-04 15:38 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-14 16:23 [PATCH 00/23] stm32: Update led management for STMicroelectronics boards Patrice Chotard
2025-11-14 16:23 ` [PATCH 01/23] board: st: Drop old LED code from stm32f429-disco Patrice Chotard
2025-12-04 13:12 ` Quentin Schulz
2025-12-04 14:58 ` Quentin Schulz
2025-11-14 16:23 ` [PATCH 02/23] board: st: Update LED management for stm32mp1 Patrice Chotard
2025-12-04 15:38 ` Quentin Schulz [this message]
2025-12-05 9:24 ` Patrice CHOTARD
2025-12-05 10:43 ` Quentin Schulz
2025-12-05 11:04 ` Patrice CHOTARD
2025-11-14 16:23 ` [PATCH 03/23] board: st: Update LED management for stm32mp2 Patrice Chotard
2025-12-04 15:43 ` Quentin Schulz
2025-11-14 16:23 ` [PATCH 04/23] configs: stm32: Enable LED config flags for stm32f429-disco Patrice Chotard
2025-12-04 15:46 ` Quentin Schulz
2025-11-14 16:23 ` [PATCH 05/23] " Patrice Chotard
2025-12-04 15:50 ` Quentin Schulz
2025-11-14 16:23 ` [PATCH 06/23] configs: stm32: Enable LED config flags for stm32f746-disco Patrice Chotard
2025-12-04 16:00 ` Quentin Schulz
2025-11-14 16:23 ` [PATCH 07/23] configs: stm32: Enable LED config flags for stm32f769-disco Patrice Chotard
2025-12-04 16:03 ` Quentin Schulz
2025-11-14 16:23 ` [PATCH 08/23] configs: stm32: Enable LED config flags for stm32h743-disco Patrice Chotard
2025-12-04 16:03 ` Quentin Schulz
2025-11-14 16:23 ` [PATCH 09/23] configs: stm32: Enable LED config flags for stm32h743-eval Patrice Chotard
2025-12-04 16:04 ` Quentin Schulz
2025-11-14 16:23 ` [PATCH 10/23] configs: stm32: Enable LED config flags for stm32h747-disco Patrice Chotard
2025-12-04 16:04 ` Quentin Schulz
2025-11-14 16:23 ` [PATCH 11/23] configs: stm32mp13: Enable LED_BOOT for stm32mp13_defconfig Patrice Chotard
2025-12-04 16:08 ` Quentin Schulz
2025-11-14 16:23 ` [PATCH 12/23] configs: stm32mp15: Enable LED_BOOT for stm32mp15_defconfig Patrice Chotard
2025-12-04 16:11 ` Quentin Schulz
2025-11-14 16:23 ` [PATCH 13/23] configs: stm32mp15: Enable LED_BOOT for stm32mp15_basic_defconfig Patrice Chotard
2025-12-04 16:14 ` Quentin Schulz
2025-11-14 16:23 ` [PATCH 14/23] configs: stm32mp15: Enable LED_BOOT for stm32mp15_trusted_defconfig Patrice Chotard
2025-12-04 16:19 ` Quentin Schulz
2025-11-14 16:23 ` [PATCH 15/23] configs: stm32mp2: Enable LED_BOOT for stm32mp25_defconfig Patrice Chotard
2025-12-04 16:20 ` Quentin Schulz
2025-11-14 16:23 ` [PATCH 16/23] configs: stm32mp2: Enable LED_BOOT for stm32mp23_defconfig Patrice Chotard
2025-12-04 16:21 ` Quentin Schulz
2025-11-14 16:23 ` [PATCH 17/23] ARM: dts: stm32: Drop "u-boot-led" and "error-led" from stm32mp135f-dk-u-boot Patrice Chotard
2025-12-04 16:25 ` Quentin Schulz
2025-12-05 9:45 ` Patrice CHOTARD
2025-12-05 10:47 ` Quentin Schulz
2025-11-14 16:23 ` [PATCH 18/23] ARM: dts: stm32: Drop "u-boot-led" and "error-led" from stm32mp157a-dk1-scmi-u-boot Patrice Chotard
2025-12-04 16:27 ` Quentin Schulz
2025-11-14 16:23 ` [PATCH 19/23] ARM: dts: stm32: Drop "u-boot-led" and "error-led" from stm32mp157a-dk1-u-boot Patrice Chotard
2025-12-04 16:27 ` Quentin Schulz
2025-11-14 16:23 ` [PATCH 20/23] ARM: dts: stm32: Drop "u-boot-led" and "error-led" from stm32mp157c-ed1-scmi-u-boot Patrice Chotard
2025-12-04 16:31 ` Quentin Schulz
2025-11-14 16:23 ` [PATCH 21/23] ARM: dts: stm32: Drop "u-boot-led" and "error-led" from stm32mp157c-ed1-u-boot Patrice Chotard
2025-12-04 16:34 ` Quentin Schulz
2025-11-14 16:23 ` [PATCH 22/23] ARM: dts: stm32: Drop "u-boot-led" from stm32mp235f-dk-u-boot Patrice Chotard
2025-12-04 16:40 ` Quentin Schulz
2025-11-14 16:23 ` [PATCH 23/23] ARM: dts: stm32: Drop "u-boot-led" from stm32mp257f-ev1-u-boot Patrice Chotard
2025-12-04 16:41 ` Quentin Schulz
2025-12-05 12:52 ` [PATCH 00/23] stm32: Update led management for STMicroelectronics boards Patrice CHOTARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=309e316f-1be0-49bb-be93-609d8b29ccaa@cherry.de \
--to=quentin.schulz@cherry.de \
--cc=kory.maincent@bootlin.com \
--cc=marek.vasut+renesas@mailbox.org \
--cc=patrice.chotard@foss.st.com \
--cc=patrick.delaunay@foss.st.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=uboot-stm32@st-md-mailman.stormreply.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).