From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1DA91C4332F for ; Fri, 21 Oct 2022 12:51:49 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 89C3184FE1; Fri, 21 Oct 2022 14:51:46 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="JamRxtdE"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0CE2A84FF7; Fri, 21 Oct 2022 14:51:45 +0200 (CEST) Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 40CEC84FDD for ; Fri, 21 Oct 2022 14:51:42 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=frattaroli.nicolas@gmail.com Received: by mail-wr1-x433.google.com with SMTP id bk15so4622923wrb.13 for ; Fri, 21 Oct 2022 05:51:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FWlXoiIQMLPDBEvxgQgk5LU+ywb1lzXe+z9X4q0Iewo=; b=JamRxtdEKkppsP4u34AiDoYy6LtH+fzPdCgGPIZi8ZPRNvpmreILgX44JPVVqwl0Ei zdDRQC+wahUlyewvuX/qGnc2x4BOm2MltY205Zw8sHQgCaUf1AdK36BVhHFMVKPVkl9x DmU/gpNDMlWFd7NOu1TdRkUXn72OxkfBp6eABH7QM0r/wO9NMgnVlOzQjgue3rdDI7df txFpB7wWwe7KKz+jnACEM/VdeMoI9x4UBa8XYJFI7f6p1PDDutc74p2/EGq9/Mnua2+u lDZh5vPLRQX77/x2D8GrmOFK1IXzkZeY8Tvq9r/57IZx89YX2G7OrKwvx8y0CDgZ0Fsa AkFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FWlXoiIQMLPDBEvxgQgk5LU+ywb1lzXe+z9X4q0Iewo=; b=k2pAoI6TYkoc2Bx856PQzyAPA++IXzYQ+PbTnQvzesQuGoOgmRzjbH12hujr+PG68u FkcAFh3jlrNMUf6YGVbLrwLF2EkfyIsaDTPqfjRVUWz5OdoaGZWlGJ/IfT4SDRxE7ZVf e5nZlckUdo5gvQ/6l23ZBSmD9jw/YPd6cYG51h+37YtHWiRPugPKnqsHo3FAMBe3w/LM itsJaUl2xZAvqxP8c/WcLoTpWSYNS++XHjnGGFIofbPqqs/8r7VHPml4xoe2Ib29dlf1 kJlua5ardKVUOXTAsU6YJXbpqQ6l2dFu7QmUDvznnj8V9M/LeAbPFmuMLI1rRJ7zjNxK ypXA== X-Gm-Message-State: ACrzQf114/HLprDrx/Duwo/KKjzbW2UJ/aiev81fnQ9hl5mvl01ma/wf pBXyLx3bmj2Lbe0tFflczKs2cjatIRw= X-Google-Smtp-Source: AMsMyM5IqrfKCWc/LYNf3HaeG3x9iZ42w6FPPQdRljqqonmD/Mcnh4+cZNlMExN6ot24zGlgc6uFxQ== X-Received: by 2002:adf:fb84:0:b0:21a:10f2:1661 with SMTP id a4-20020adffb84000000b0021a10f21661mr12038855wrr.2.1666356701809; Fri, 21 Oct 2022 05:51:41 -0700 (PDT) Received: from archbook.localnet (84-72-105-84.dclient.hispeed.ch. [84.72.105.84]) by smtp.gmail.com with ESMTPSA id v10-20020a05600c444a00b003c6f27d275dsm2888973wmn.33.2022.10.21.05.51.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Oct 2022 05:51:41 -0700 (PDT) From: Nicolas Frattaroli To: Simon Glass , Philipp Tomsich , Kever Yang Cc: u-boot@lists.denx.de Subject: Re: [PATCH] rockchip: rk3328: Set VOP QoS to high priority Date: Fri, 21 Oct 2022 14:30:39 +0200 Message-ID: <31442545.XjgUJs76Fk@archbook> In-Reply-To: <20220723112836.88814-1-frattaroli.nicolas@gmail.com> References: <20220723112836.88814-1-frattaroli.nicolas@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Samstag, 23. Juli 2022 13:28:36 CEST Nicolas Frattaroli wrote: > The default priority for the quality of service for the video > output results in unsightly glitches on the output whenever there > is memory pressure on the system, which happens a lot. > > This sets the VOP QoS to high priority, which fixes this issue. > > Signed-off-by: Nicolas Frattaroli > --- > arch/arm/mach-rockchip/rk3328/rk3328.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm/mach-rockchip/rk3328/rk3328.c b/arch/arm/mach-rockchip/rk3328/rk3328.c > index de17b88682..2373586b14 100644 > --- a/arch/arm/mach-rockchip/rk3328/rk3328.c > +++ b/arch/arm/mach-rockchip/rk3328/rk3328.c > @@ -19,6 +19,8 @@ DECLARE_GLOBAL_DATA_PTR; > #define GRF_BASE 0xFF100000 > #define UART2_BASE 0xFF130000 > #define FW_DDR_CON_REG 0xFF7C0040 > +#define QOS_VOP_OFFSET 0xFF760080 > +#define QOS_VOP_PRIORITY 0x8 > > const char * const boot_devices[BROM_LAST_BOOTSOURCE + 1] = { > [BROM_BOOTSOURCE_EMMC] = "/mmc@ff520000", > @@ -54,6 +56,9 @@ int arch_cpu_init(void) > > /* Disable the ddr secure region setting to make it non-secure */ > rk_setreg(FW_DDR_CON_REG, 0x200); > +#else > + printf("Setting VOP QoS\n"); > + rk_setreg(QOS_VOP_OFFSET + QOS_VOP_PRIORITY, 0x2); > #endif > return 0; > } > Hello, could I get a review on this? Thank you for your time, Nicolas Frattaroli