public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko@sntech.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 14/18] rockchip: pinctrl: rk322x: Move the iomux definitions into pinctrl-driver
Date: Mon, 25 Dec 2017 19:59:12 +0100	[thread overview]
Message-ID: <3192718.KjcsxaA0hZ@phil> (raw)
In-Reply-To: <1510219498-79331-1-git-send-email-david.wu@rock-chips.com>

Hi David,

Am Donnerstag, 9. November 2017, 17:24:58 CET schrieb David Wu:
> diff --git a/arch/arm/mach-rockchip/rk322x-board-spl.c b/arch/arm/mach-rockchip/rk322x-board-spl.c
> index 35f4f97..f7c6045 100644
> --- a/arch/arm/mach-rockchip/rk322x-board-spl.c
> +++ b/arch/arm/mach-rockchip/rk322x-board-spl.c
> @@ -30,7 +30,25 @@ DECLARE_GLOBAL_DATA_PTR;
>  
>  void board_debug_uart_init(void)
>  {
> -static struct rk322x_grf * const grf = (void *)GRF_BASE;
> +       static struct rk322x_grf * const grf = (void *)GRF_BASE;
> +       enum {
> +               GPIO1B2_SHIFT           = 4,
> +               GPIO1B2_MASK            = 3 << GPIO1B2_SHIFT,
> +               GPIO1B2_UART1_SIN,
> +               GPIO1B2_UART21_SIN,
> +
> +               GPIO1B1_SHIFT           = 2,
> +               GPIO1B1_MASK            = 3 << GPIO1B1_SHIFT,
> +               GPIO1B1_UART1_SOUT,
> +               GPIO1B1_UART21_SOUT,

You seem to drop the GPIO1B1_GPIO = 0, line, so the enum counting
wil get jumbled, because GPIO1B1_UART1_SOUT for example will get to
be 4 instead of the 1 it needs to be.

This may be true for the other patches for the other socs as well,
so you may want to double check?


Heiko

  parent reply	other threads:[~2017-12-25 18:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-09  9:24 [U-Boot] [PATCH v2 14/18] rockchip: pinctrl: rk322x: Move the iomux definitions into pinctrl-driver David Wu
2017-11-20 15:05 ` [U-Boot] [U-Boot, v2, " Philipp Tomsich
2017-11-25 23:51 ` Philipp Tomsich
2017-12-25 18:59 ` Heiko Stuebner [this message]
2017-12-26  6:24   ` [U-Boot] [PATCH v2 " David.Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3192718.KjcsxaA0hZ@phil \
    --to=heiko@sntech.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox