From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5EEA4C7EE2A for ; Mon, 22 May 2023 19:25:59 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D966381FA8; Mon, 22 May 2023 21:25:56 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="D2zFcnzj"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0469D82A2C; Mon, 22 May 2023 21:25:56 +0200 (CEST) Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id AF83C81DCF for ; Mon, 22 May 2023 21:25:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=cfsworks@gmail.com Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-64d3578c25bso4162464b3a.3 for ; Mon, 22 May 2023 12:25:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684783552; x=1687375552; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7yC62regRf6pA4/y6Gwkbtpy3yb3ekbLBS7gvifhV/I=; b=D2zFcnzjNp9eN9uaXcaUzcgParFKVn7kdoY+vty0seeKgLkziBXc2OkSXAx5uCSWdI vVAUXXBXVRYlX9RqVPfcXMyaKBXLjI2QpsiSg5sTeqryXTMis8nssB0qNQymRVvtdbEh pPrwNiEcWo420Pe0C0wF5goZfpzpy/MjP6rskKK/lyk47yItHn+CDgaHaktuHSfEOQtX +8ALuU0RbgVfjkpV4bYDlqnEWORBqPcZ2aBhYpTwZP+4AO9VI/4t3QaVsLT2kZNCdt4O cl8bWuazH/YmbRcrYf+1WvRfj8wxM2fpBlZ0DnNqlS7MtL9LKUUJyYhV2Qn12zLyh8He bg4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684783552; x=1687375552; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7yC62regRf6pA4/y6Gwkbtpy3yb3ekbLBS7gvifhV/I=; b=dNQSc0vjhGb031ufooy7rmGYHskydRsdnZhTvA+VtnoEaoVWq0EHC2WNjiuNWCKM4J qWi4CUJH4BnIb53Pt4lN+xoZ1wj8HCPiaG3d3dhMHdF/CYRv37apT3xt6aRgSZoRqgFc XNWXGUVjEhQ8tF0/6mvGn6LKij/F0PztJUT6RHiAU9g6fD6dm7v7Ugm7+JG+YlXHbGPx Vxm5SBCHrq23ZeZs1EFeAT22CM5NdZgouURKrSfVFSC2ysIvLZSCr5Llyi0Q+FnkcMjP 1m36imEYS4UVCb/DdSE7MILYA9eqXMJ3w1lShuCeVe3G4+pUytHgjaoCSO327G+7rbzF n9sQ== X-Gm-Message-State: AC+VfDwYsGoMkwVhKbqKulg4at7h7QWaFt12hdBc0NWfjyA03uQYefxx tbsVILby2uCk2zkFfnKtxJQ= X-Google-Smtp-Source: ACHHUZ579AIZY73Qy3a6iKMwrNIp7gDrCbxJX6heN1WGAc6DM7i3lpspFtBWN3W/ZOpjva/5mHObxQ== X-Received: by 2002:a05:6a00:2e06:b0:643:aa2:4dcd with SMTP id fc6-20020a056a002e0600b006430aa24dcdmr17279124pfb.16.1684783551968; Mon, 22 May 2023 12:25:51 -0700 (PDT) Received: from [10.64.107.252] (static-198-54-134-172.cust.tzulo.com. [198.54.134.172]) by smtp.gmail.com with ESMTPSA id k25-20020aa792d9000000b0064d34ace753sm4469073pfa.114.2023.05.22.12.25.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 May 2023 12:25:51 -0700 (PDT) Message-ID: <31a43ffb-9aa6-d3f6-5cb5-781ea9e28e04@gmail.com> Date: Mon, 22 May 2023 13:25:50 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [RFC PATCH 07/10] arm: efi_loader: discard hash, unwind information Content-Language: en-US To: Ilias Apalodimas Cc: u-boot@lists.denx.de, Heinrich Schuchardt , Tom Rini References: <20230520205547.1009254-1-CFSworks@gmail.com> <20230520205547.1009254-8-CFSworks@gmail.com> From: Sam Edwards In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Ilias, On 5/22/23 01:00, Ilias Apalodimas wrote: > The reason we end up with both hash and gnu.hash is because the hash > style is set to 'both'. Should we perhaps use (and strip) only one of > them? If we do keep one, it should probably be .hash -- see commit b02bfc4dfc. I admit I'm completely mystified as to why we need the hash tables at all. The ELF spec says those are just for the dynamic linker, but neither the EFI code nor the self-relocating thunk require it, and I don't know of any target where the u-boot ELF itself is the shipped binary. For all I know, there never was a need to include .hash and Albert's commit fixed whatever problem he was facing only accidentally. Do you have any insights? LLD's --hash-style option doesn't appear to have a "none" option or I'd just be making use of that here. Cheers, Sam