From: Johan Jonker <jbx6244@gmail.com>
To: kever.yang@rock-chips.com
Cc: sjg@chromium.org, philipp.tomsich@vrull.eu,
sumit.garg@kernel.org, trini@konsulko.com, u-boot@lists.denx.de,
hl@rock-chips.com, jagan@amarulasolutions.com,
jernej.skrabec@gmail.com, w.egorov@phytec.de, jonas@kwiboo.se,
michael@amarulasolutions.com
Subject: [PATCH v3 3/6] ARM: dts: rockchip: move edp assigned-clocks to edp node on rk3288
Date: Fri, 16 Jan 2026 23:12:20 +0100 [thread overview]
Message-ID: <31a98155-90cd-4896-9dad-002e6a53b4fa@gmail.com> (raw)
In-Reply-To: <a6eba53c-a2db-44fc-9785-d817dbb4ef11@gmail.com>
The rk3288 power-controller node contains an assigned-clocks property
that conflicts with the bindings. From the git history it shows that they
wanted to assign the rk3288 EDP_24M clock input centrally before an edp
node was available. Move the edp assigned-clocks property to the edp node
to reduce dtbs_check output.
Signed-off-by: Johan Jonker <jbx6244@gmail.com>
Link: https://patch.msgid.link/7d6fa223-ab90-4c44-9180-54df78467ea5@gmail.com
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
[ upstream commit: 10712ce694a67304a99dbba20f8cb146ca5f4fd6 ]
(cherry picked from commit e1b4137b6bbc9998b13cde2eba0655cfdd358c69)
---
dts/upstream/src/arm/rockchip/rk3288.dtsi | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/dts/upstream/src/arm/rockchip/rk3288.dtsi b/dts/upstream/src/arm/rockchip/rk3288.dtsi
index 7e284b4fecdc..7477fc5da3ec 100644
--- a/dts/upstream/src/arm/rockchip/rk3288.dtsi
+++ b/dts/upstream/src/arm/rockchip/rk3288.dtsi
@@ -741,9 +741,6 @@
#address-cells = <1>;
#size-cells = <0>;
- assigned-clocks = <&cru SCLK_EDP_24M>;
- assigned-clock-parents = <&xin24m>;
-
/*
* Note: Although SCLK_* are the working clocks
* of device without including on the NOC, needed for
@@ -1193,6 +1190,8 @@
compatible = "rockchip,rk3288-dp";
reg = <0x0 0xff970000 0x0 0x4000>;
interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
+ assigned-clocks = <&cru SCLK_EDP_24M>;
+ assigned-clock-parents = <&xin24m>;
clocks = <&cru SCLK_EDP>, <&cru PCLK_EDP_CTRL>;
clock-names = "dp", "pclk";
phys = <&edp_phy>;
--
2.39.5
next prev parent reply other threads:[~2026-01-16 22:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-16 22:09 [PATCH v3 0/6] rockchip: use OF_UPSTREAM for rk3288 Johan Jonker
2026-01-16 22:11 ` [PATCH v3 1/6] ARM: dts: rockchip: Remove mshc aliases from RK3288 Johan Jonker
2026-03-08 15:42 ` Kever Yang
2026-01-16 22:12 ` [PATCH v3 2/6] ARM: dts: rockchip: Add spi_flash label to rk3288-veyron Johan Jonker
2026-03-08 15:42 ` Kever Yang
2026-01-16 22:12 ` Johan Jonker [this message]
2026-03-08 15:42 ` [PATCH v3 3/6] ARM: dts: rockchip: move edp assigned-clocks to edp node on rk3288 Kever Yang
2026-01-16 22:12 ` [PATCH v3 4/6] rockchip: Switch rk3288-veyron boards to upstream devicetree Johan Jonker
2026-03-08 15:42 ` Kever Yang
2026-01-16 22:13 ` [PATCH v3 5/6] rockchip: Switch remaining rk3288 " Johan Jonker
2026-03-09 3:02 ` Kever Yang
2026-01-16 22:13 ` [PATCH v3 6/6] rockchip: imply OF_UPSTREAM for rk3288 boards Johan Jonker
2026-03-09 3:02 ` Kever Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31a98155-90cd-4896-9dad-002e6a53b4fa@gmail.com \
--to=jbx6244@gmail.com \
--cc=hl@rock-chips.com \
--cc=jagan@amarulasolutions.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=kever.yang@rock-chips.com \
--cc=michael@amarulasolutions.com \
--cc=philipp.tomsich@vrull.eu \
--cc=sjg@chromium.org \
--cc=sumit.garg@kernel.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=w.egorov@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox