public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH 5/8] APM82xxx: Add UIC support
@ 2010-08-26 21:06 tmarri at apm.com
  2010-08-27 10:12 ` Sergei Shtylyov
  2010-08-29  8:56 ` Wolfgang Denk
  0 siblings, 2 replies; 5+ messages in thread
From: tmarri at apm.com @ 2010-08-26 21:06 UTC (permalink / raw)
  To: u-boot

From: Tirumala Marri <tmarri@apm.com>

This patch adds Universal Interrupt Controller support for
APM82XXX processor.

Signed-off-by: Tirumala R Marri <tmarri@apm.com>
---
 arch/powerpc/include/asm/ppc4xx-uic.h |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/powerpc/include/asm/ppc4xx-uic.h b/arch/powerpc/include/asm/ppc4xx-uic.h
index 782d045..238b70b 100644
--- a/arch/powerpc/include/asm/ppc4xx-uic.h
+++ b/arch/powerpc/include/asm/ppc4xx-uic.h
@@ -31,7 +31,7 @@
  */
 #if defined(CONFIG_440GX) || defined(CONFIG_440SPE) || \
     defined(CONFIG_460EX) || defined(CONFIG_460GT) || \
-    defined(CONFIG_460SX)
+    defined(CONFIG_460SX) || defined(CONFIG_APM82XXX)
 #define UIC_MAX		4
 #elif defined(CONFIG_440EPX) || defined(CONFIG_440GRX) || \
     defined(CONFIG_405EX)
@@ -252,7 +252,8 @@
 #define VECNUM_ETH0		(32 + 28)
 #endif /* CONFIG_440SPE */
 
-#if defined(CONFIG_460EX) || defined(CONFIG_460GT)
+#if defined(CONFIG_460EX) || defined(CONFIG_460GT) ||\
+    defined(CONFIG_APM82XXX)
 /* UIC 0 */
 #define VECNUM_UIC2NCI		10
 #define VECNUM_UIC2CI		11
-- 
1.6.1.rc3

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [U-Boot] [PATCH 5/8] APM82xxx: Add UIC support
  2010-08-26 21:06 [U-Boot] [PATCH 5/8] APM82xxx: Add UIC support tmarri at apm.com
@ 2010-08-27 10:12 ` Sergei Shtylyov
  2010-08-30 17:42   ` Tirumala Marri
  2010-08-29  8:56 ` Wolfgang Denk
  1 sibling, 1 reply; 5+ messages in thread
From: Sergei Shtylyov @ 2010-08-27 10:12 UTC (permalink / raw)
  To: u-boot

Hello.

tmarri at apm.com wrote:

> From: Tirumala Marri <tmarri@apm.com>

> This patch adds Universal Interrupt Controller support for
> APM82XXX processor.

> Signed-off-by: Tirumala R Marri <tmarri@apm.com>
[...]
> diff --git a/arch/powerpc/include/asm/ppc4xx-uic.h b/arch/powerpc/include/asm/ppc4xx-uic.h
> index 782d045..238b70b 100644
> --- a/arch/powerpc/include/asm/ppc4xx-uic.h
> +++ b/arch/powerpc/include/asm/ppc4xx-uic.h
[...]
> @@ -252,7 +252,8 @@
>  #define VECNUM_ETH0		(32 + 28)
>  #endif /* CONFIG_440SPE */
>  
> -#if defined(CONFIG_460EX) || defined(CONFIG_460GT)
> +#if defined(CONFIG_460EX) || defined(CONFIG_460GT) ||\

    Please add space before \ to keep the style consistent.

> +    defined(CONFIG_APM82XXX)

WBR, Sergei

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [U-Boot] [PATCH 5/8] APM82xxx: Add UIC support
  2010-08-26 21:06 [U-Boot] [PATCH 5/8] APM82xxx: Add UIC support tmarri at apm.com
  2010-08-27 10:12 ` Sergei Shtylyov
@ 2010-08-29  8:56 ` Wolfgang Denk
  2010-08-30 18:45   ` Tirumala Marri
  1 sibling, 1 reply; 5+ messages in thread
From: Wolfgang Denk @ 2010-08-29  8:56 UTC (permalink / raw)
  To: u-boot

Dear tmarri at apm.com,

In message <1282856765-24544-1-git-send-email-tmarri@apm.com> you wrote:
> From: Tirumala Marri <tmarri@apm.com>
> 
> This patch adds Universal Interrupt Controller support for
> APM82XXX processor.

Again. This is NOT a separate, independent commit.  Please reread the
documentation andfix your patch splitting.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Vulcans never bluff.
	-- Spock, "The Doomsday Machine", stardate 4202.1

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [U-Boot] [PATCH 5/8] APM82xxx: Add UIC support
  2010-08-27 10:12 ` Sergei Shtylyov
@ 2010-08-30 17:42   ` Tirumala Marri
  0 siblings, 0 replies; 5+ messages in thread
From: Tirumala Marri @ 2010-08-30 17:42 UTC (permalink / raw)
  To: u-boot

>
> > This patch adds Universal Interrupt Controller support for
> > APM82XXX processor.
>
> > Signed-off-by: Tirumala R Marri <tmarri@apm.com>
> [...]
> > diff --git a/arch/powerpc/include/asm/ppc4xx-uic.h
> b/arch/powerpc/include/asm/ppc4xx-uic.h
> > index 782d045..238b70b 100644
> > --- a/arch/powerpc/include/asm/ppc4xx-uic.h
> > +++ b/arch/powerpc/include/asm/ppc4xx-uic.h
> [...]
> > @@ -252,7 +252,8 @@
> >  #define VECNUM_ETH0		(32 + 28)
> >  #endif /* CONFIG_440SPE */
> >
> > -#if defined(CONFIG_460EX) || defined(CONFIG_460GT)
> > +#if defined(CONFIG_460EX) || defined(CONFIG_460GT) ||\
>
>     Please add space before \ to keep the style consistent.
[Marri] Sure will fix it.

Regards,
Marri

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [U-Boot] [PATCH 5/8] APM82xxx: Add UIC support
  2010-08-29  8:56 ` Wolfgang Denk
@ 2010-08-30 18:45   ` Tirumala Marri
  0 siblings, 0 replies; 5+ messages in thread
From: Tirumala Marri @ 2010-08-30 18:45 UTC (permalink / raw)
  To: u-boot

> -----Original Message-----
> From: Wolfgang Denk [mailto:wd at denx.de]
> Sent: Sunday, August 29, 2010 1:57 AM
> To: tmarri at apm.com
> Cc: u-boot at lists.denx.de; open-source-review at apm.com
> Subject: Re: [U-Boot] [PATCH 5/8] APM82xxx: Add UIC support
>
> Dear tmarri at apm.com,
>
> In message <1282856765-24544-1-git-send-email-tmarri@apm.com> you
> wrote:
> > From: Tirumala Marri <tmarri@apm.com>
> >
> > This patch adds Universal Interrupt Controller support for
> > APM82XXX processor.
>
> Again. This is NOT a separate, independent commit.  Please reread the
> documentation andfix your patch splitting.

Mr Wolfgang,
  Sure will fix it.
Regards,
Marri

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2010-08-30 18:45 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-26 21:06 [U-Boot] [PATCH 5/8] APM82xxx: Add UIC support tmarri at apm.com
2010-08-27 10:12 ` Sergei Shtylyov
2010-08-30 17:42   ` Tirumala Marri
2010-08-29  8:56 ` Wolfgang Denk
2010-08-30 18:45   ` Tirumala Marri

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox