Re: [PATCH v3 2/2] usb: gadget: Add Renesas RZ/N1 USBF controller support

[Romain Gantois via U-Boot <u-boot@lists.u-boot-project.org>]

[-- Attachment #1: Type: text/plain, Size: 1622 bytes --]

Hi Marek,

On Thursday, 23 July 2026 21:53:08 CEST Marek Vasut wrote:
> On 7/23/26 11:09 AM, Romain Gantois wrote:
> > From: Herve Codina <herve.codina@bootlin.com>
> > 
> > Add support for the Renesas USBF controller. This is an USB2.0 UDC
> > controller available in the RZ/N1 SoC.
> > 
> > This driver was originally written by Hervé Codina for the Linux kernel.
> > 
> > Linux revision this was ported from:
> > 
> > 74851fbb6d64 ("usb: gadget: renesas_usbf: Handle devm_pm_runtime_enable()
> > errors")
> > 
> > The following features were removed to reduce the memory footprint of the
> > 
> > driver, and to avoid including features not relevant to U-Boot:
> >   - Suspend/resume
> >   - Handling of endpoints > 2
> 
> The code seems to handle 3 endpoints ?
> 

Yes, I'm talking in terms of USB endpoint numbers here, so endpoints 0-2 are 
handled.

> > +/* Only handle the first three endpoints for now. This is sufficient to
> > + * expose classic bootloader gadgets such as Fastboot or DFU.
> > + */
> > +#define USBF_NUM_ENDPOINTS	3
> 
> But why not handle the additional endpoints ?
> 

Because I didn't see a major use case for them in U-Boot, and removing their 
handling allowed a reduction in code and program volume which seems relevant 
for U-Boot.

> Also, can you test whether 'ums 0 mmc 0.1,0.2,0' works to expose eMMC HW
> BOOT partitions and HW USER partition as three separate UMS devices over
> the same USB connection ?

Sure, I'll give it a try.

Thanks,

-- 
Romain Gantois, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]