[U-Boot] [PATCH v2 4/9] sunxi: initial generic sun7i cpu, board and start of day support

Wolfgang Denk
2014-03-22T06:52:54Z

Dear Ian Campbell,

In message <1395438866-1193-4-git-send-email-ijc@hellion.org.uk> you wrote:
> This has been stripped back for mainlining and supports only sun7i. These
> changes are not useful by themselves but are split out to make the patch sizes
> more manageable.
>
> As well as the following signed-off-by the sunxi branch shows commits to these
> files authored by the following:
> Almo Nito
> Carl van Schaik
> FUKAUMI Naoki
> hehopmajieh
> j
> Sergey Lapin
> Tom Cubie

Sorry, this is a NAK for these patches.

"These changes are not useful by themselves but are split out to make
the patch sizes more manageable." This is not how we work. Patches
have to implement specific features, or fix specific bugs. And they
have to maintain bisectability of the code.

And we need a useful commit message that explains clearly what the
patch is doing, and why.

And we implement the same Developer's Certificate of Origin as used in
Linux, so we need real names and working e-mail addresses in the
Signed-off-by lines - a cursory mentioning that some mysterious "j" or
some "hehopmajieh" authored some code is not sufficient.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Nail here --X-- for new monitor.