[U-Boot] [PATCH v2 4/9] sunxi: initial generic sun7i cpu, board and start of day support

Ian Campbell
2014-03-22T15:28:46Z

On Sat, 2014-03-22 at 13:27 +0100, Wolfgang Denk wrote:
> Dear Hans de Goede,
>
> In message <532D5238.6080606@redhat.com> you wrote:
> >
> > > "These changes are not useful by themselves but are split out to make
> > > the patch sizes more manageable." This is not how we work. Patches
> > > have to implement specific features, or fix specific bugs. And they
> > > have to maintain bisectability of the code.
> >
> > These patches do implement specific features, like dram init, timer/clk
> > init, etc. They just don't enable them yet as by themselves they are not useful.
>
> Well, then at least the commit meSsage needs some serious rework.

I will add some more description for the next round.

> > The patches also maintain bisectability since they don't touch any existing
> > files until the patch 5 and 6 come into play, and the changes in patch 5 keep
> > things compiling just fine.
>
> I think I have seen some interdependencies between the patches - like
> referring to stuff that gets only added in later patches?

I don't believe so, bisectability is maintained because there are no
build targets until patch #5 and from that point on every step builds.
Obviously at every step (including #1..#5) there is no impact on any
other platform.

Ian.