[U-Boot] [PATCH v2 4/9] sunxi: initial generic sun7i cpu, board and start of day support

Ian Campbell
2014-03-22T09:37:21Z

On Sat, 2014-03-22 at 10:04 +0100, Hans de Goede wrote:
> > Sorry, this is a NAK for these patches.
> >
> > "These changes are not useful by themselves but are split out to make
> > the patch sizes more manageable." This is not how we work. Patches
> > have to implement specific features, or fix specific bugs. And they
> > have to maintain bisectability of the code.
>
> These patches do implement specific features, like dram init, timer/clk
> init, etc. They just don't enable them yet as by themselves they are not useful.
>
> The patches also maintain bisectability since they don't touch any existing
> files until the patch 5 and 6 come into play, and the changes in patch 5 keep
> things compiling just fine.

That's correct, the initial 4 patches add specific subsystem support for
sunxi but none of it is built until patch 5 at which point things work.

> FWIW I believe the split-up Ian has done makes sense. But if you insist I
> guess we can merge patch 1-6 (the minimum set to get something working)
> into 1 big patch.

Personally I think that would hinder review more than help, but if that
is what is required I'll do it.

Ian.