From: Nikhil Jain <n-jain1@ti.com>
To: Devarsh Thakkar <devarsht@ti.com>, <u-boot@lists.denx.de>,
<sjg@chromium.org>, <agust@denx.de>, <trini@konsulko.com>
Cc: <bmeng@tinylab.org>, <xypron.glpk@gmx.de>,
<patrick.delaunay@foss.st.com>, <patrice.chotard@foss.st.com>,
<hvilleneuve@dimonoff.com>, <michal.simek@amd.com>,
<troykiskyboundary@gmail.com>, <j-humphreys@ti.com>, <afd@ti.com>,
<praneeth@ti.com>, <nm@ti.com>, <vigneshr@ti.com>,
<a-bhatia1@ti.com>, <j-luthra@ti.com>
Subject: Re: [PATCH 2/4] video: Assume video to be active if SPL is passing video hand-off
Date: Wed, 6 Mar 2024 16:16:09 +0530 [thread overview]
Message-ID: <323cfe8a-ab8d-491d-af98-db839bb90484@ti.com> (raw)
In-Reply-To: <20240222130811.3878567-3-devarsht@ti.com>
Hi Devarsh,
On 22/02/24 18:38, Devarsh Thakkar wrote:
> If SPL is passing video handoff structure to U-boot then it is safe to
> assume that SPL has already enabled video and that's why it is passing
> video handoff structure to U-boot so that U-boot can preserve the
> framebuffer.
>
> Signed-off-by: Devarsh Thakkar <devarsht@ti.com>
> ---
> drivers/video/video-uclass.c | 4 ++++
> 1 file changed, 4 insertions(+)
Reviewed-by: Nikhil M Jain <n-jain1@ti.com>
>
> diff --git a/drivers/video/video-uclass.c b/drivers/video/video-uclass.c
> index 3571e62ba2..7b5d1dfbb3 100644
> --- a/drivers/video/video-uclass.c
> +++ b/drivers/video/video-uclass.c
> @@ -404,6 +404,10 @@ bool video_is_active(void)
> {
> struct udevice *dev;
>
> + /* Assume video to be active if SPL passed video hand-off to U-boot */
> + if (IS_ENABLED(CONFIG_SPL_VIDEO_HANDOFF) && spl_phase() > PHASE_SPL)
> + return true;
> +
> for (uclass_find_first_device(UCLASS_VIDEO, &dev);
> dev;
> uclass_find_next_device(&dev)) {
Thanks,
Nikhil
next prev parent reply other threads:[~2024-03-06 12:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 13:08 [PATCH 0/4] Simplefb and fb reservation related updates Devarsh Thakkar
2024-02-22 13:08 ` [PATCH 1/4] boot: fdt_simplefb: Enumerate framebuffer info from video handoff Devarsh Thakkar
2024-03-06 10:42 ` Nikhil Jain
2024-02-22 13:08 ` [PATCH 2/4] video: Assume video to be active if SPL is passing video hand-off Devarsh Thakkar
2024-03-06 10:46 ` Nikhil Jain [this message]
2024-02-22 13:08 ` [PATCH 3/4] boot: Move framebuffer reservation to separate helper Devarsh Thakkar
2024-03-06 10:51 ` Nikhil Jain
2024-02-22 13:08 ` [PATCH 4/4] board: ti: am62x: evm: Update simple-framebuffer node in device-tree Devarsh Thakkar
2024-03-05 10:28 ` Devarsh Thakkar
2024-03-08 11:08 ` [PATCH 0/4] Simplefb and fb reservation related updates Devarsh Thakkar
2024-04-05 14:49 ` Devarsh Thakkar
2024-04-20 23:09 ` Anatolij Gustschin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=323cfe8a-ab8d-491d-af98-db839bb90484@ti.com \
--to=n-jain1@ti.com \
--cc=a-bhatia1@ti.com \
--cc=afd@ti.com \
--cc=agust@denx.de \
--cc=bmeng@tinylab.org \
--cc=devarsht@ti.com \
--cc=hvilleneuve@dimonoff.com \
--cc=j-humphreys@ti.com \
--cc=j-luthra@ti.com \
--cc=michal.simek@amd.com \
--cc=nm@ti.com \
--cc=patrice.chotard@foss.st.com \
--cc=patrick.delaunay@foss.st.com \
--cc=praneeth@ti.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=troykiskyboundary@gmail.com \
--cc=u-boot@lists.denx.de \
--cc=vigneshr@ti.com \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox