From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pali =?ISO-8859-1?Q?Roh=E1r?= Date: Sun, 29 Apr 2012 09:29:29 +0200 Subject: [U-Boot] [PATCH v2 06/11] cfb_console: Add support for some ANSI terminal escape codes In-Reply-To: <201204290019.04086.marex@denx.de> References: <1335634011-9104-1-git-send-email-pali.rohar@gmail.com> <1335634011-9104-7-git-send-email-pali.rohar@gmail.com> <201204290019.04086.marex@denx.de> Message-ID: <3284404.3VX1zBQJtc@pali> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sunday 29 April 2012 00:19:03 Marek Vasut wrote: > > + > > + if (ansi_buf_size > 0) { > > + /* > > + 0 - ESC > > + 1 - [ > > + 2 - num1 > > + 3 - .. > > + 4 - ; > > + 5 - num2 > > + 6 - .. > > + 7 - cchar > > wrong comment ... did you even run these patches through > checkpatch? Run them and resubmit please, I'm ending my review > here. > Yes, I all patches except first is OK for checkpatch. It show no errors and no warnings. -- Pali Roh?r pali.rohar at gmail.com -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 198 bytes Desc: This is a digitally signed message part. URL: