From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4983BC001E0 for ; Tue, 1 Aug 2023 10:32:21 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 03D0186B53; Tue, 1 Aug 2023 12:32:19 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=ti.com header.i=@ti.com header.b="OfTX2+9Y"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9B94486B53; Tue, 1 Aug 2023 12:32:17 +0200 (CEST) Received: from lelv0143.ext.ti.com (lelv0143.ext.ti.com [198.47.23.248]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 749F786BB0 for ; Tue, 1 Aug 2023 12:32:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=devarsht@ti.com Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 371AWCTI084821; Tue, 1 Aug 2023 05:32:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1690885932; bh=Dr3jZoQi7VxlZNTBPrKfX5ZL32dXnn8BNUWHzitCRHY=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=OfTX2+9Y9Jhhm9iDtsqL1NswtSgo10n5XI1cbc6bbf+jzHI6HwTEu/owIk4NJuijm DGDmLQT+VaK46JuqaLpfMoVOPTOANGE8AKCWr267rOEXgbbkEjoxJvUsr92MDRmwN2 HOxhPvxQFi65oo2FjGp+VgSYKvDTzsGPGdYBB33I= Received: from DLEE104.ent.ti.com (dlee104.ent.ti.com [157.170.170.34]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 371AWC99000596 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 1 Aug 2023 05:32:12 -0500 Received: from DLEE114.ent.ti.com (157.170.170.25) by DLEE104.ent.ti.com (157.170.170.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Tue, 1 Aug 2023 05:32:11 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE114.ent.ti.com (157.170.170.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Tue, 1 Aug 2023 05:32:12 -0500 Received: from [172.24.227.6] (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 371AW9LG045646; Tue, 1 Aug 2023 05:32:10 -0500 Message-ID: <330ab7ba-2c67-3e02-eb84-9131b6b6eac4@ti.com> Date: Tue, 1 Aug 2023 16:02:09 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 2/2] drivers: video: tidss: tidss_drv: Use kconfig VIDEO_REMOVE to remove video Content-Language: en-US To: "Jain, Nikhil" , "u-boot@lists.denx.de" CC: "trini@konsulko.com" , "Raghavendra, Vignesh" , "Nori, Sekhar" References: <20230727063126.53347-1-n-jain1@ti.com> <20230727063126.53347-3-n-jain1@ti.com> From: Devarsh Thakkar In-Reply-To: <20230727063126.53347-3-n-jain1@ti.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 27/07/23 12:01, Jain, Nikhil wrote: > Perform removal of DSS if kconfigs VIDEO_REMOVE or SPL_VIDEO_REMOVE is > set by user. Otherwise if above Kconfigs are not selected, it is assumed > that user wants splash screen to be displayed until linux kernel boots > up. In such scenario, leave the power domain of DSS as "on" so that > splash screen stays intact until kernel boots up. > > Signed-off-by: Nikhil M Jain Reviewed-by: Devarsh Thakkar > --- > drivers/video/tidss/tidss_drv.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/drivers/video/tidss/tidss_drv.c b/drivers/video/tidss/tidss_drv.c > index 623bf4cf31..e285f255d7 100644 > --- a/drivers/video/tidss/tidss_drv.c > +++ b/drivers/video/tidss/tidss_drv.c > @@ -901,9 +901,11 @@ static int tidss_drv_probe(struct udevice *dev) > > static int tidss_drv_remove(struct udevice *dev) > { > - struct tidss_drv_priv *priv = dev_get_priv(dev); > + if (CONFIG_IS_ENABLED(VIDEO_REMOVE)) { > + struct tidss_drv_priv *priv = dev_get_priv(dev); > > - VP_REG_FLD_MOD(priv, 0, DSS_VP_CONTROL, 0, 0, 0); > + VP_REG_FLD_MOD(priv, 0, DSS_VP_CONTROL, 0, 0, 0); > + } > return 0; > } > > @@ -929,5 +931,9 @@ U_BOOT_DRIVER(tidss_drv) = { > .probe = tidss_drv_probe, > .remove = tidss_drv_remove, > .priv_auto = sizeof(struct tidss_drv_priv), > +#if CONFIG_IS_ENABLED(VIDEO_REMOVE) > .flags = DM_FLAG_OS_PREPARE, > +#else > + .flags = DM_FLAG_OS_PREPARE | DM_FLAG_LEAVE_PD_ON, > +#endif > };