From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 26236C43334 for ; Wed, 22 Jun 2022 18:18:43 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3933984265; Wed, 22 Jun 2022 20:18:37 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="nMs+WnSr"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1C71C8428C; Wed, 22 Jun 2022 20:18:35 +0200 (CEST) Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8DA6A84101 for ; Wed, 22 Jun 2022 20:18:32 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=alpernebiyasak@gmail.com Received: by mail-ed1-x52c.google.com with SMTP id z11so18897130edp.9 for ; Wed, 22 Jun 2022 11:18:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:from:subject:to:cc :references:content-language:in-reply-to:content-transfer-encoding; bh=ZL229A40zPPQMVGLtJGNSpqrgQNa08ioZT5f3o7AZ+A=; b=nMs+WnSrmk+blhacVisXaExc0xnYpGRm5/pwM9FldIYwkEOevwPF/2wXti7b+EHuRG u19zntYohmDi/4yygRX+UCfCgxuCUFf0XRu7/nGnwVbohedpMcxEa4SQCXS0cdnoYGox mH7racGTNnyGaDysh9p17MnugqTO8hskoipMP5+X98BdL4kv5GoSxL456sNpTwJulDEj Iaawo3/sXXPzojv2j5654MUQOa5Rfk/8xe+GoBRWBLhVrwLAdKYWMGXmSz9ovkyho956 anamKYxzs04yfrxMIW4QRga08txIZc4mEQ8HN0rZt9kDo4gZAktEsgZaWeOQJ8FHVktg t3fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:from :subject:to:cc:references:content-language:in-reply-to :content-transfer-encoding; bh=ZL229A40zPPQMVGLtJGNSpqrgQNa08ioZT5f3o7AZ+A=; b=Wy2eOsZANEvEfgwS7wSgsqjSfMm0EBWi6HOZMddngle1281Bw0O7liCzfBvk6+E+bV XwUU+RQi/tfpfcjBr/U3opMd4UvB/M/QFHTAik4v3988EuhmpLPGacW+ypg+9tp1f0fp D8adgbLpz8ieyfbQ7wyPKKV17Vl4uqbriNVk/E+0AiYW+wbhV8pZNkiJ8a05ahxXtC9J tY+Dc6oEKbU6pHVEEeCvH1uxZFx741Mt4UTNqX+Njt9yo11OuyRqaNqbcT1zp/vJnOi7 PlmIczYj7o4SCzc3mqLKTtBV8UGrMqQUdUXGCe/Tn7rpk5oNf6iTEfqEJt1XRuI2RXK4 +E1g== X-Gm-Message-State: AJIora8Rh2lPQc2PqIgdCwxc5rxRKMhRSkAmiAYKFarZBdlr2gYAS69V p29IrILbmci9WUqzUPJGCJ8= X-Google-Smtp-Source: AGRyM1tnuT/y2ZkjHAwUIwZqWT27VTi79dtdxST2DIHPaBrLS0H9rkxDhP8rq9AL43FvZlbiNUU0iA== X-Received: by 2002:a05:6402:11:b0:431:680c:cca1 with SMTP id d17-20020a056402001100b00431680ccca1mr5705088edu.420.1655921912177; Wed, 22 Jun 2022 11:18:32 -0700 (PDT) Received: from [192.168.0.74] ([178.233.178.185]) by smtp.gmail.com with ESMTPSA id p1-20020a05640210c100b004357dca07cdsm8671218edu.88.2022.06.22.11.18.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Jun 2022 11:18:31 -0700 (PDT) Message-ID: <330e62ca-2d80-03a6-2a0b-fa0e364b295d@gmail.com> Date: Wed, 22 Jun 2022 21:16:58 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 From: Alper Nebi Yasak Subject: Re: [PATCH v2 2/2] ARM: imx: imx8mn-evk: use one common u-boot.dtsi for the evk boards To: Heiko Thiery , Tim Harvey Cc: u-boot , Ying-Chun Liu , Peng Fan , Fabio Estevam , Marek Vasut , Marcel Ziswiler , Sean Anderson , =?UTF-8?Q?Thomas_Sch=c3=a4fer?= , Stefano Babic , Simon Glass References: <20220609204926.26580-1-heiko.thiery@gmail.com> <20220609204926.26580-2-heiko.thiery@gmail.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 10/06/2022 00:38, Heiko Thiery wrote: > Hi Tim, Hi Simon, > > [SNIP] > >> >> Heiko, >> >> You can add multi-dtb support to this so that it's usable by the other >> imx8mn boards with the following: >> >> [...] >> >> I don't mind sending this as a follow-up to your patch here. > > Since this patch moves the parts from the 2 imx8mn-evk boards to one > "common" file it would be better to do more changes on that in a > separate patch. > >> It looks like there are only the following boards in mainline that >> would benefit from using this shared include: >> imx8mn-beacon-kit-u-boot.dtsi >> imx8mn-var-som-symphony-u-boot.dtsi >> imx8mn-venice-u-boot.dtsi There's also 'imx8mn-bsh-smm-s2-u-boot-common.dtsi'. Slightly different because only half of the blobs are there with IMX8M_DDR3L. >> Have you compared the binman portions of imx8m{m,n,p}-u-boot.dtsi? > > No not yet. I looked a bit and they look very much alike. I suspect it's possible to eventually unify everything into a shared 'imx8m-u-boot.dtsi', but I didn't actually try. >> There are a lot of differences due to different property ordering and >> label/node naming conventions. I would like to see these normalized >> but i'm not clear which is the best example to normalize to. >> Specifically I don't know: >> 1. what is the convention for property ordering in dt... is it simply >> alphabetical order? AFAIK property order doesn't matter for binman. Node order is very significant though. For names, I think we should: - Prefer hyphens to underscores - Prefer lowercase to uppercase - Prefer meaningful names to things like 'blob-ext@1' - Avoid first char being a number (because labels can't have that) >> 2. have we settled on a convention for the blob naming, if so what is >> the best example? I had suggested 'ddr-1d-imem-fw' etc. on a series from Peng, see latest version of it [1]. [1] arm: dts: imx8m: update binman ddr firmware node name https://lore.kernel.org/u-boot/20220603071715.15212-4-peng.fan@oss.nxp.com/ > I am not aware that there is a conventional here. But maybe simon can > give some hints here. >